Login Authenicating thing help

Archbob

<?

include "common.php";
$SQL=mysql_query("select username, password FROM cl_logintable");
while($row=mysql_fetch_array($SQL))
  {
   if($username === $row[1] && $password === $row[2])
        {       

            return true;
            print "You have logged in";
        }
  }

return false;
print "Login Failed";

?>

Umm, I just get a blank screen when I try to log in from thsi form;

<html>
<form action="reguser.php">
Type Username Here: <input type="text" name="username" size="15"><br>
Type Password Here: <input type="text" name="password" size="15"><br>
Retype password: <input type="text" name="pass2" size="15"><br>
<input type="submit" value="submit">


</form>
</html>

Any ideas?

cgraz

You need a method on your form

Cgraz

Archbob

That wasn't the problem, one of my queries must be wrong.

Any ideas?

lemist

Would not this part:
if($username === $row[1] && $password === $row[2])
need to be
if($username === $row["username"] && $password === $row["password"])

Archbob

Nope, I'm still drawing up a blank screen. HELP!!!

JimD

Then something in common.php must be wrong.

Archbob

Common is just the databse connection. I'm sure its right, it works for all other parts of the script and if it didn't it'd give me an error.

sgoku01

And what happens if you do this:

if($username == $row[1] && $password == $row[2])

(so minus the =)

cgraz

Can you post your updated code.

As lemist said, row 1 and 2 won't work. With numeric based indexing, remember arrays start at 0, so username would be $row['0'] and password would be $row['1']. OR if you're going to use associate arrays (easier to keep track of), lemist posted the code, although i'm not sure if you need 3 equal signs instead of just two. . ?

Also, what's blank? The page that displays the form, or when you hit submit? Did you add an action to your form? If not, $username doesn't mean anything to reguser. if you're using method post, $POST['username'] and $POST['password']

Cgraz

sgoku01

Originally posted by cgraz
although i'm not sure if you need 3 equal signs instead of just two. . ?

I checked it, and it doesn't matter if you use 2 or 3 equal-signs. The result is the same.

cgraz

Didn't know that. When I'm not sure, I always go with the safe side. 😉 I never use 3, so since I knew 2 worked for sure I just suggested that just in case.

Anyways, glad you checked; learn something new everyday.

Cgraz

sgoku01

another thing to learn: 3 equal signs check if the two things are identical (so the type is also the same). 😃

cgraz

Ahhh, i didn't even see your "And what happens if you do this:" post.

That's what I get for not reading all the posts. I guess I just prefer to skim. 😉

Cgraz

Archbob

<?

include "common.php";
$SQL = mysql_query('SELECT username, password FROM cl_logintable LIMIT 0, 30'); 

while($row=mysql_fetch_array($SQL))
  {

print "hi";
if($username === $row["username"] && $password === $row["password"])
        {       

            return true;
            print "You have logged in";
        }
  }

return false;
print "Login Failed";

?>

I tried with two also, it doesn't work. Three equals is mainly to prevent hacking. I added the hi for error tracking. There's two entires of username and password in the table so it should print hi twice, it only prints it once. I tried both get and post, none of them seemed to work.

sgoku01

Are you using this as a function?

cgraz

Are you not using any encryption on your passwords? If not, try this:

$query = "SELECT * FROM cl_logintable WHERE username='$username' AND password='$password'";
$result = mysql_query($result);

if (mysql_num_rows($result) > '0') {
   echo "You are in the database. I need to log you in";
} else {
   echo "Sorry. Didn't find you in the database";
}

Cgraz

stolzyboy

use this

<?
$conn = mysql_connect("localhost", "username", "password") or die ("Could not connect to database!");
$db = mysql_select_db("database") or die ("Could not select database");
if (isset($signin)) // name of submit button
{
	$query = "select * from table where username='$username' and password=(password('$password'))"; // don't use password() function if you didn't use it to input into the database
	$result = mysql_query($query) or die ("Could not select records");

$isAuth = false; //set to false originally

while($row = mysql_fetch_array($result))
{
	if($row['username'] == $username) // if true set $isAuth to true, if not it will stay false
	{
		$isAuth = true;
	}  
}  

if($isAuth)
{
             echo "username and password successfully";
}
else
{
echo "no username/password found";
}
?>

Archbob

Thanks a lot, I will try those.

Thanks guys, took me a while and had to make a few adjustments, but it finally works, not to start on sessions...