help with while & mysql_fetch_row

[Juha]

hi,

I've made this script:

if (!$kysely = mysql_query("select id,paivays,otsikko,teksti,nimi from kommentti"))
{
// query failed
print "<LI>Haku epäonnistui!";
}
else
{
// query success

if (!$kommentti=mysql_fetch_row($kysely)) print "no comments";
else {

  while ($kommentti = mysql_fetch_row($kysely))
  {

$paivays=$kommentti[1];
$vuosi=substr($paivays, 0, 4);
$kuukausi=substr($paivays, 6, 2);
$paiva=substr($paivays, 4, 2);
$tunti=substr($paivays, 8, 2);
$minuutti=substr($paivays, 10, 2);
$lukema= $kuukausi."-".$paiva."-".$vuosi." ".$tunti.":".$minuutti;

print "<table width='527' border='0' cellspacing='0' cellpadding='4' class='boksi'>";
print "<tr bgcolor='#99CC99'><td height='20' width='369' class='kysely'>" . htmlentities($kommentti[2]) . "</td>";
print "<td colspan='2' height='20' class='kysely'>" . $lukema . "</td>";
print "</tr><tr><td colspan='3' class='kysely'>" . htmlentities($kommentti[3]) . "</td>";
print "</tr><tr><td colspan='3' class='kysely'>" . htmlentities($kommentti[4]) . "</td>";

print "</tr><tr bgcolor='#99CC99'><td height='20' colspan='3'></td>";
print "</tr></table>";
print "<br>";
}
}

}

Sorry about the variables (in Finnish). Anyhow, this script is supposed to fetch comments from MYSQL database (with a topic title, text, date and writer's name) unless the table is empty, in which case it is supposed to print 'no comments'

It works well enough, except that the first comment doesn't print: only the second and subsequent comments show. I am guessing that the problem lies with the while statement but since I am a hopless newbie, can't really tell what's wrong.

Any help would be appreciated!

Juha

[tserbis]

if (!$kommentti=mysql_fetch_row($kysely)) - NO !!!
if (!mysql_num_rows($kysely)) - YES !!!

[Juha]

eh?

Ok, but that still doesn't solve my problem: the first row of the table doesn't print.

Juha

[tserbis]

Do you really replace

if (!$kommentti=mysql_fetch_row($kysely)) print "no comments";

for this

if (!mysql_num_rows($kysely)) print "no comments";

???

[Juha]

This may be a dumb guess but does the first if clause that checks the status of fetch_row actually 'waste' the first row of the table so that only the second and subsequent rows are printed?

If so, how would I go about fixing it?

Juha

[Juha]

Originally posted by tserbis
Do you really replace

if (!$kommentti=mysql_fetch_row($kysely)) print "no comments";

for this

if (!mysql_num_rows($kysely)) print "no comments";

???

Both ways seem to work but this doesn't solve my dilemma

Juha

[balweb]

Well I've read somewhere mysql_fetch_rows start with [0],
Try $Kommentti[0] in your while loop

by the way your website is wonderful

[Juha]

Originally posted by balweb
Well I've read somewhere mysql_fetch_rows start with [0],
Try $Kommentti[0] in your while loop

by the way your website is wonderful

$kommentti [0] would be the id of the row, can't see how that would help.

Maybe I explained my problem in unclear terms: the purpose of the script is to fetch comments stored in MYSQL table. Each comment takes one row, with id, title, text, date and author.

The problem is the script only prints from the second comment onwards, the first comment (or row) is left unprinted, that's the problem. I am guessing that the if clause which checks whether mySQL_fetch_row is valid 'uses up' the first row of the table, and starts to print from the second onward. But that's just my guess.

I'd really appreciate any answer!

And thanks looking at my pages! I thought those would be closed by now, and in fact when I tried to go there I got an 'access denied' note! Odd. BTW that site has nothing to do with the PHP matter I am asking here.

Juha