OOP - grrr

[stezz]

hey! Iv'e recently written some db code handled by objects in PHP..

I ran the code and got the following wrror message..

Warning: Missing argument 1 for sql_connect() in c:\documents and settings\stezzy\desktop\files\projects\slackernet\
include\database.php on line 27

Warning: Missing argument 2 for sql_connect() in c:\documents and settings\stezzy\desktop\files\projects\slackernet\
include\database.php on line 27

Warning: Missing argument 3 for sql_connect() in c:\documents and settings\stezzy\desktop\files\projects\slackernet\
include\database.php on line 27

Warning: Missing argument 4 for sql_connect() in c:\documents and settings\stezzy\desktop\files\projects\slackernet\
include\database.php on line 27

line 27 happends to be the function definition which is stated below. Please could somebody give me an idea as to why that error got returned? It doesn't mae any sense to me.

function sql_connect($host, $user, $pass, $db)
{
$this->host = $host;
$this->user = $user;
$this->pass = $pass;
$this->dbname = $db;

	$this->db_status = @mysql_connect($this->host, $this->user, $this->pass);
	if($this->db_status)
	{
		if($db != "")
		{
			$this->dbname = $db;
			$dbselect = @mysql_select_db($this->dbname);
			if(!$dbselect)
			{
				@mysql_close($this->db_status);
				$this->db_status = $dbselect;
			}
		return $this->db_status;
		}
	}
	else
	{
		return false;
	}
}

[daphreeek]

well - I have one question - why did you make your own function to connect to a mysql database? just use mysql_connect() and mysql_select_database(). There is no point making a function as you only call them once per page anyway.

What I do is make a file called db_info.inc.php that contains these lines:

<?php
$db = mysql_connect("localhost", "username", "password");
mysql_select_db("database",$db);
?>

then in any page i want to access the database i just use include("db_info.inc.php");

Thats much easier - your function is doing a simple thing in a really complicated way.

Remember - often the easiest solution works the best.

• Matt

[diego25]

I think it's because you have an error BEFORe line 27, which makes PHP not understand line 27...Maybe you forgot the previous curly bracket or something?

And daphreeek, it seems to me like steez is writing a class for database abstraction.

Diego

[stezz]

hey.. I checked the file and there are no errors previously to the function definition. The only thing that's before thr sql_connect function is the class definition and member variable definitions.

class sql_connect
{
var $db_status;
var $query_result;
var $host;
var $user;
var $pass;
var $dbname;

// constructor time..

function sql_connect($host, $user, $pass, $db)
{

etc

This still doesn't make any sense to me..

Regards, Stezz.

[Weedpacket]

Well, cut and pasting the supplied code into a single intact file, I get:

<?php

class sql_connect
{

var $db_status;
var $query_result;
var $host;
var $user;
var $pass;
var $dbname;

function sql_connect($host, $user, $pass, $db)
{
$this->host = $host;
$this->user = $user;
$this->pass = $pass;
$this->dbname = $db;

$this->db_status = @mysql_connect($this->host, $this->user, $this->pass);
if($this->db_status)
{
if($db != "")
{
$this->dbname = $db;
$dbselect = @mysql_select_db($this->dbname);
if(!$dbselect)
{
@mysql_close($this->db_status);
$this->db_status = $dbselect;
}
return $this->db_status;
}
}
else
{
return false;
}
} 

}

?>

Which runs (trivially) without any errors at all.
So the problem's not there.

[stezz]

could it be something to do with my PHP configuration? Is there anything for OOP in there? I think the $dodgy_script_parse var has been set to true in my config 😛

Regards, Stezz.

[stezz]

in that case.. it's pretty obvious that the error is coming when the function is actually called! But it still doesn't make any sense.. all four arguments are supplied when the function is called.

Regards, Stezz.

[Weedpacket]

I agree that the error is signalled when you try instantiating the class, but it's not until the constructor definition is read that PHP realises that you didn't supply enough arguments (at least, it says you didn't supply enough arguments....)

<?php
class boo
{ function boo($this,$that,$the_other)
  { echo 'do nothing, go nowhere.';
  }
}

$t = new boo('a',41);
?>

PHP Warning: Missing argument 3 for boo() in c:\test.php on line 4

Giving default values in the function declaration makes the problem go away, of course, but that does nothing to determine why you're getting in the first place...

[stezz]

It works.. like you said... give the function default values..

I simply did..

<?php
function sql_connect($host = "", $user = "", $pass = "", $db = "")
{
// code here
}

Thanks very much for the help!

Regards, Stezz.