random image displyer help

[danville]

Here is my code and errors, can someone help me here?

<?
$folder=opendir("rndimgs/");
while ($file = readdir($folder));
$names[count($names)] = $file;
closedir($folder);

sort($names);

$tempvar=0;
for ($i=0; $names [$i]; $i++){
$ext=strtlolower(substr($names[$i],-4));
if ($ext==".jpg"||$ext==".gif"||$ext==".jpeg"||$ext==".png"){
$names1[$tempvar]=$names[$i];
$tempvar++;
}
}

srand ((double) microtime() * 10000000);
$rand_keys = array_rand ($names1, 2);

$slika=$names1[$rand_keys[0]];

$dimensions = GetImageSize($slika);
if (isset($pic)){
header ("Location: $slika");
}
else {echo "<img src=\"$slika\" $dimensions[3]>";
}
?>

Errors:
Warning: Argument to array_rand() has to be an array in C:\Inetpub\wwwroot\Danville_Main\rndimgs.php on line 19

Warning: getimagesize: Unable to open '' for reading. in C:\Inetpub\wwwroot\Danville_Main\rndimgs.php on line 23

[jnuneznyc]

OK let's see if I get this? You want to load in the image file names into an array and then retrieve it randomly?

First don't store any info you don't need, filter out the files before storing them.

Second using $names[count($names)] is the same as $names[]

Finally, you forgot to put the file paths in with the image names.

<?
$folder=opendir("rndimgs/");
while ($file = readdir($folder)){
    $ext=strtolower(substr($file,-4));
    if ($ext==".jpg"||$ext==".gif"||$ext==".jpeg"||$ext==".png"){
        $names[] = $file;
    }
}
closedir($folder);

sort($names);

srand ((double) microtime() * 10000000);
$rand_key = array_rand ($names);

$slika=$names[$rand_key];

$dimensions = GetImageSize($slika);
if (isset($pic)){
    header ("Location: rndimgs/$slika");
}
    else {echo "<img src=\"rndimgs/$slika\" $dimensions[3]>";
}
?>

[xblue]

good suggestion already 🙂

some more (I hope):

Will substr($file,-4) ever match ".jpeg" which has 5 characters? you could use explode or simply compare the last 4 characters to "jpeg" (no dot) in this case.

And I'd suggest to replace
$rand_key = array_rand ($names);
with something like
$rand_key = rand(0, count($names)-1);
- this returns a random number between 0 and the last array index, which is what you need to access the random array element in $slika=$names[$rand_key];

Hope this helps!