Assistance with Update

[[deleted]]

The below code is not update the columns in my database. It executes the SELECT without any problems.
I am using almost the exact code for another form which works without any problem. The value of $id is echoed in the form, but I don't think it is being passed to the UPDATE sql. WHen I echo the UPDATE query I get a value of 1 which, to me, indicates the query is valid.

Any help you can render would be greatly appreciated.

Steve

<?php

// EDIT
include_once ("../includes/login3.php");
include_once ("../includes/functions.php");
?>

<?php

if (!isset($submitok))
{

// generate and execute query

$qryEditNews = " SELECT NewsID,Headline,Content,Date
FROM tblNews
WHERE NewsID = '$id'";
$rsltEditNews = mysql_query($qryEditNews) or die ("Error in query: $qryEditNews. " . mysql_error());

// if a result is returned
if (mysql_num_rows($rsltEditNews) > 0)
{
	// turn it into an object
	$EditNews_row = mysql_fetch_object($rsltEditNews);

	// print form with values pre-filled
}

?>
&nbsp;<a class="intro" href="?action=editnews">Edit News</a>

<table cellspacing="5" cellpadding="5">
<form action="<?=$PHP_SELF?>?action=listnews" method="POST">
<tr>
<td width="109" valign="top" class="txthdr">NewsID =<?php echo $id; ?>
</td>

	 		  <td width="332" class="intro"> </td>
</tr>
<tr> 
  <td valign="top" class="txthdr">Headline</td>
  <td class="intro"><input name="newHeadline" type="text" value="<?php echo $EditNews_row->Headline; ?>" size="75"> 
</tr>
<tr> 
  <td valign="top" class="txthdr">Content</td>
  <td class="intro"><textarea cols="75" rows="20" name="newContent"><?php echo $EditNews_row->Content; ?></textarea></td>
</tr>
<tr> 
  <td colspan=2><input type="Submit" name="submitok" value="Update"></td>
</tr>

</form>
</table>

<?php
}
else
{
if ($newHeadline=="" or $newContent=="") {
error("One or more required fields were left blank.\n".
"Please fill them in and try again.");

		  }

	$qUpdateNews = mysql_query ("UPDATE tblNews
							SET Headline = '$newHeadline', newContent = '$newContent'
							WHERE NewsID = '$id'");


echo "<font size=-1>Update successful.</a>.</font>";

}

?>
</td>
</tr>
</table>
<table width="100%" border="0" cellpadding="0" cellspacing="0">
<!--DWLayoutTable-->
<tr>
<td height="12" colspan="2" valign="top" bgcolor="#163BA3"><!--DWLayoutEmptyCell-->&nbsp;</td>
</tr>
<tr>

<td width="100%" height="54" valign="top"> 
  <?php
include_once ("../includes/footer.php");
?>
</td>

</tr>
</table>

[jstarkey]

Sounds like register_globals may be off on the new machine.

If so, for your if statement below, you'll need to do:

if ( !isset( $_POST['submitok'] ) )
{
.....
}

Use $_POST the same way for the rest of the form variables.

[cgraz]

jstarkey makes a good point, you may want to try using $POST to access your variables; but i'm wondering what's going on. You've never had to use $POST on this server before?

What i'd do is echo the variables right before the update query. If they don't echo properly, then you know they're not getting passed on correctly.

echo "New Headline: " . $newHeadline . "<br>\n";
echo "New Content: " . $newContent . "<br>\n";
echo "News ID: " . $id . "<br>\n";

$qUpdateNews = mysql_query ("UPDATE tblNews 
SET Headline = '$newHeadline', newContent = '$newContent' 
WHERE NewsID = '$id'"); 

Now if they all echo correctly, then there shouldnt' be a problem. If none of them echo, then use $POST['newContent'], $POST['newHeadline'], and $_POST['id']. If New headline and new content echo but not the news id, then what you can do is make a hidden input field in your form with the value for the news id so it gets passed.

<input type="hidden" name="id" value="<? echo $id; ?>">

Then try echoing the variables again before your update. Should work.

Cgraz

[[deleted]]

I used $_POST and now it works. Thanks.