Object/Array error

laeelin

The script below is part of something i'm useing to expand my php abilities =) ...

It takes a text log from a game, finds the start and end of every fight and passes that log...

$fights->storelog($log2);
$fights->nextfight();

as an array resulting in an array that looks like this.

log[1] = 426 Vabarn tells you, 'Attacking guardian wurm Master.'
log[2] = 432 You begin casting Neurotoxin.
log[3] = 439 guardian wurm was hit by non-melee for 1423 points of damage.
log[4] = 451 You gained raid experience!

the numbers are how many seconds we are from the start of the log, and the fighttime function should be subtracting the number of seconds in the first line from the number in the last line to tell me how many seconds the fight lasted.

the comments after each echo say what I actually get when I echo that line.

Does anyone know where my problem is?

Thanks
Laeelin

class fight {//fight
     var $spells, $totaldamage, $fightstart, $fightend, $fightlogs, $fightnum;

function fight(){
$this->fightnum='1';
}


function fighttime($num){
	$log = $this->fightlogs[$num];
/* this is where the strange things are echoing */
		echo $log . '<BR>'; // echos "ARRAY"
		echo join('<BR>',$log); // echos the contents of the array with a <BR> after each line.
		echo $log[0]; // echos nothing ..(same with $log[1], $log[2]....)
/* this is where the strange things are echoing */
		$time=explode (' ',$a, 2);
		$this->fightstart = $time[0];
		$time=explode (' ',$a, 2);
		$this->fightend = $time[0];
		return $this->fightend-$this->fightstart;
	}

function storelog($log){
	//$log=join('<!--line--><BR>',$log);
	$num = $this->fightnum;
	$this->{fightlogs}[$num]=$log;
}

function nextfight(){
	$this->fightnum++;
}

function returnfight($num){
return $this->fightlogs[$num];
}

}//fight

Bijan

Hi, don't you think that it's better if you defined $fightlogs as an array in the first line of your class?

class fight {//fight
     var $spells, $totaldamage, $fightstart, $fightend, $fightlogs, $fightnum;

Also I can't understand why you're using curly braces around fightlogs in here:

    function storelog($log){
        //$log=join('<!--line--><BR>',$log);
        $num = $this->fightnum;
        $this->{fightlogs}[$num]=$log;

laeelin

I forgot i had the curlies in from earlier when I was testing to see how they worked.

I removed them and also declared $fightlogs as an array...

I still get the same output.

however.....

I'm something to do with the way the Array is being created and handled.

I'm takeing an array and assigning it to an array... like this..

$otherarray[0] = $array;

$newarray = $otherarray[0];

Then

echo $newarray; // shows "array" like it should... after all, it is an array.. even if it isnt being used correctly...

but...

echo $newarray[0]; // shows nothing....

and even stranger...

echo $join(':',$newarray); // results in the same output as $join(':',$array);

I can understanding it not working at all (that what I actually expected to happen when I tried this) .. but $join(':',$newarray); is working for some reason...

Anyone know why?

thanks
laeelin

cgraz

I just briefly skimmed through your post, but you could count newarray[] to see how many values it has

echo count($newarray);

Then if it is more than 1, and you want to see what these values are

for ($i=0; $i < count($newarray); $i++) {
   echo $i . "). " . $newarray[$i] . "<br>\n";
}

should echo something like

0). value
1). value 1
2). value2

I always do that to troubleshoot when I'm having problems with arrays.

Hope this helps.

Cgraz

Bijan

Well, I'm not sure, but it might be the answer to your problem.
If you have an array, it doesn't mean that you always have the 0, 1 or 10 index available to you! It's no need that someone indexes his/her array by numbers, or even starts from zero. Something like:

$hash = array( "First" => "Hello!", "Whatever!" => "Yup!!");

So, let's go back to your problem:

$otherarray[0] = $array; 

$newarray = $otherarray[0]; 


//Then 

echo $newarray; // shows "array" like it should... after all, it is an array.. even if it isnt being used correctly... 

//but... 

echo $newarray[0]; // shows nothing.... 
[b]
//and even stranger... 

echo $join(':',$newarray); // results in the same output as $join(':',$array); 
[/b]

by the first line you're assigning $array to the zero index of $otherarray and then you put $otherarray[0] into $newarray. So, speaking about $array, how're you sure that it has something in it's zero index? maybe it doesn't?
Now you understand that looping through an array by for isn't really a good way, we can always use foreach that doesn't depend on numbers as the indexes of the array.

foreach ($newarray as $key=>$val) {
   echo $key . "). " . $val . "<br>\n";
}

Back to the quote, where I made it bold, you said that the join of $newarray is exactly like joining $array, right? What's so strange about that? I think it should be like that! You're using $otherarray[0] as a temporary holder in here, so, what is in $array should go exactly to $newarray, don't you think so?

Also I can't understand what phppenishedpunk wrote. What did you mean by showing your array? Do you have the same problem or just wanted to show what you populated in it?