rename not working

[ptbsG_Man]

Hi all i am tring to get this code to rename a file

if($_GET["rename"]){
	rename($path_full/$_GET["old"], $_GET["new"]);
}

but when i try the URL http://www.dlgnetworks.com/test.php?rename=1&old=doom.wad&new=doom1.wad

it dose not rename the file 😕

Now for some info about the script

$path_full is set after this snipit, if I remember that dose not bother PHP, is equal to the users home DIR witch in this case is "/home/testsize" and the file is in "/home/testsize/doom.wad"
(i am on a WINbox)
any ideas??

Also i was thinking would it be better if i used a switch, because i right now have 5 if statments for the rename and deleate type things. Should i do something like this

switch($function) {
  case 'rename':
    rename(old, new);
    break;
  case 'deleate':
    unlink(file);
    break;
  ETC...

Thanks in advance

[Weedpacket]

Have you tried a copy-then-delete instead?

[ptbsG_Man]

hmm didnt think of it that way, also i would not know how to implament that, and fore code size would that be better then using the rename function ?

[ptbsG_Man]

hmm didnt think of it that way, also i would not know how to implament that, and fore code size would that be better then using the rename function ?

[xblue]

What about

$path_full/$_GET["old"]

This is not a string, so I'd think the parser would probably interpret the / as devision operator.
Try

"$path_full/".$_GET["old"]

or

$path_full."/".$_GET["old"]

[Weedpacket]

Very very true.

[ptbsG_Man]

Hmm doses not work 🙁 im going to put the whole code up so you can get the big piture as to what it dose and help me cause i cant get any file commands to work "unlink, mkdir, EC..." and because i have changed it around from what it was befor

so without further adue the code

<?
header("Cache-Control: no-store, no-cache, must-revalidate");
header("Cache-Control: post-check=0, pre-check=0", false);
session_start();

if(!$_REQUEST['login']) {
    include("login.php");
}
else{
$path        = "C:/home";
$path_name   = $_SESSION["user"];
$path_folder = $_REQUEST['path_folder']; 
$path_full   = "$path/$path_name$path_folder";
$func        = $_REQUEST['function'];
$file_in     = $_REQUEST['file'];
$dir_in      = $_REQUEST['dir'];
$old_file    = $_REQUEST['oldfile'];
$new_file    = $_REQUEST['newfile'];

chdir ( $path_full );
$cur_dir = opendir( $path_full ) or die ("unable to open Directory $path_full");
while (false !== ($file = readdir($cur_dir)))
{
    if(is_dir ($file)) {
        $dirs[] = $file;
    }
    else {
        $files[] = $file;
    }
}
closedir($cur_dir);

switch($func) {
	case 'renamefile':
		rename ("$full_path/" .$old_file, "$full_path/" .$new_file);
		break;
	case 'deletefile':
		unlink ("$full_path/" .$file);
		break;
	case 'createdir':
		mkdir ("$full_path/" .$dir);
		break;
}

function dirsize($iniDir) {
    $totalsize = 0;
    $file = "";
    $dirsleft = array();
    array_push($dirsleft, $iniDir);
    while (count($dirsleft)>0) {
        $curdir = array_pop($dirsleft);
        if ($handle = opendir($curdir)) {
            while (false !== ($file = readdir($handle))) { 
                if ($file != "." && $file != "..") { 
                    if (is_dir($curdir."/".$file)) array_push($dirsleft, $curdir."/".$file);
                    else $totalsize += filesize($curdir."/".$file);
                }
            }
            closedir($handle); 
        }
    }
	$kb = 1024; // Kilobyte
	$mb = 1024 * $kb; // Megabyte
	$gb = 1024 * $mb; // Gigabyte
	$tb = 1024 * $gb; // Terabyte
	if($totalsize < $kb) {
	return $totalsize." B";
	}
	else if($totalsize < $mb) {
		return number_format($totalsize/$kb,2)." KB";
	}
	else if($totalsize < $gb) {
		return number_format($totalsize/$mb,2)." MB";
	}
	else if($totalsize < $tb) {
		return number_format($totalsize/$gb,2)." GB";
	}
	else {
		return number_format($totalsize/$tb,2)." TB";
	}
}

function my_mdate($file) {
	$mdate = filemtime($file);
	return date("m/d/Y h:i A" ,$mdate);
}

function my_filesize($file) {

$kb = 1024; // Kilobyte
$mb = 1024 * $kb; // Megabyte
$gb = 1024 * $mb; // Gigabyte
$tb = 1024 * $gb; // Terabyte

$size = filesize($file);

if($size < $kb) 
	{
	return $size." B";
	}
else if($size < $mb)
	{
	return number_format($size/$kb,2)." KB";
	}
else if($size < $gb)
	{
	return number_format($size/$mb,2)." MB";
	}
else if($size < $tb)	
	{
	return number_format($size/$gb,2)." GB";
	}
else	
	{
	return number_format($size/$tb,2)." TB";
	}
}
?>
<html>
<head>
<LINK TYPE="text/css" HREF="mstyle.css" REL="stylesheet">
<title>
Test PHP DIR list page done by the G_Man
</title>
</head>
<body bgcolor="#FFFFFF" text="#0F0F0F" link="000000" vlink="#000000">
  <table class="shadowA" border="0" cellspacing="0" cellpadding="0" align="center" width="800">
    <tr>
      <td class="shadowA-topLeft"></td>
      <td class="shadowA-top"></td>
      <td class="shadowA-topRight"></td>
    </tr>
    <tr>
      <td class="shadowA-left"></td>
      <td class="shadowA-center" align="center">
      <form method="post" action="test.php" name="yes_this_is_a_form">
	  <table border="1" bordercolor="FFFFAA" align="center" width="100%" cellpadding="0" cellspacing="0">
    <tr>
      <td colspan="5">You are in <?= $path_full; ?> with <?= dirsize($_SESSION["home"]); ?><br></td>
    </tr>
	<tr>
	  <td align="center">&nbsp;</td>
      <td align="center">&nbsp;</td>
	  <td align="center" width="480">File Name</td>
	  <td align="center">Size</td>
  	  <td align="center">last modified</td>
      </tr>
	  <?
      foreach ($dirs as $file) {
	  	  $my_size = my_filesize($file);
          echo "<tr><td><input type=\"checkbox\" name=\"file\" value=\"checkbox\"></td><td><img src=\"imgs/directory.gif\"></td><td><a href=\"test.php?login=true&path_folder=$path_folder/$file\">$file</a></td><td>&nbsp;</td><td>&nbsp;</td></tr>\n";
      }
      foreach ($files as $file) {
		  if(eregi(".exe", $file))
			  {
			  $my_size = my_filesize($file);
			  $my_mtime = my_mdate($file);
			  echo "<tr><td><input type=\"checkbox\" name=\"file\" value=\"checkbox\"></td><td><img src=\"imgs/executable.gif\"></td><td><a href=\"$path_name$path_folder/$file\">$file</a></td><td align=\"right\">$my_size</td><td width=150 align=\"right\">$my_mtime</td></tr>\n";
		   	  }
		  else if(eregi(".bmp", $file) || eregi(".jpg", $file) || eregi(".jpeg", $file) || eregi(".gif", $file))
			  {
			  $my_size = my_filesize($file);
			  $my_mtime = my_mdate($file);
			  echo "<tr><td><input type=\"checkbox\" name=\"file\" value=\"checkbox\"></td><td><img src=\"imgs/image.gif\"></td><td><a href=\"$path_name$path_folder/$file\">$file</a></td><td align=\"right\">$my_size</td><td width=150 align=\"right\">$my_mtime</td></tr>\n";
			  }
		  else if(eregi(".html", $file) || eregi(".htm", $file) || eregi(".php", $file) || eregi(".txt", $file) || eregi(".css", $file))
			  {
			  $my_size = my_filesize($file);
			  $my_mtime = my_mdate($file);
			  echo "<tr><td><input type=\"checkbox\" name=\"file\" value=\"checkbox\"></td><td><img src=\"imgs/text.gif\"></td><td><a href=\"$path_name$path_folder/$file\">$file</a></td><td align=\"right\">$my_size</td><td width=150 align=\"right\">$my_mtime</td></tr>\n";
			  }
		  else if(eregi(".mp3", $file) || eregi(".wav", $file) || eregi(".midi", $file) || eregi(".wma", $file) || eregi(".aif", $file))
			  {
			  $my_size = my_filesize($file);
			  $my_mtime = my_mdate($file);
			  echo "<tr><td><input type=\"checkbox\" name=\"file\" value=\"checkbox\"></td><td><img src=\"imgs/audio.gif\"></td><td><a href=\"$path_name$path_folder/$file\">$file</a></td><td align=\"right\">$my_size</td><td width=150 align=\"right\">$my_mtime</td></tr>\n";
			  }
		  else
			  {
			  $my_size = my_filesize($file);
			  $my_mtime = my_mdate($file);
			  echo "<tr><td><input type=\"checkbox\" name=\"file\" value=\"checkbox\"></td><td><img src=\"imgs/unknown.gif\"></td><td><a href=\"$path_name$path_folder/$file\">$file</a></td><td align=\"right\">$my_size</td><td width=150 align=\"right\">$my_mtime</td></tr>\n";
			  }
      }
	  ?>
       </table>
      </td>
      <td class="shadowA-right"></td>        

    </tr>
    <tr>
      <td class="shadowA-bottomLeft"></td>
      <td class="shadowA-bottom"></td>
      <td class="shadowA-bottomRight"></td>
    </tr>
  </table>
</table>
</body>
</html>
<?
}
?>

Again Thank you for your help 🙂