Need Js help

RedDragon

Well on my forum i have a bb code and smilies inserter which uses

javascript:insert('tags')

for inserting a tags into a text boy which worked fine...

i was using

to insert the tags/smilies at the cursor and not at the end of the text, a friend told me that there seem to be problems with netscape and opera,

does anyone know how to do it for all 3 browsers ?
complete code would be nice!

mikeatrpi

<script type="text/javascript" language="javascript"> 
<!--
function storeCaret (textEl) 
{
	if (textEl.createTextRange) 
	{
    	textEl.caretPos = document.selection.createRange().duplicate();
	}
}


function insertAtCaret (textEl, text) 
{
    if (textEl.createTextRange && textEl.caretPos) 
	{
		var caretPos = textEl.caretPos;
        caretPos.text = caretPos.text.charAt(caretPos.text.length - 1) 
== ' ' ? text + ' ' : text;
    }
    else
	{
    	textEl.value += text;
	}     

}

//duplicate this function a zillion times, or you can mess with the 
code a bit and pass the tags as additional parameters
function boldThis(Lo) 
{ 
	strSelection = document.selection.createRange().text
	if (strSelection == "") {
		insertAtCaret(eval("document.all."+Lo), "<b></b>");
		return;
	} 
	document.selection.createRange().text = "<b>" + strSelection + "</b>"
	return;
} 
-->
</script>

<textarea name="header" rows=10 cols=72 max=16777215 wrap=soft ONSELECT="storeCaret(this);" ONCLICK="storeCaret(this);" ONKEYUP="storeCaret(this);">STUFF!</textarea>

<!--this is the code I use to make buttons -->
<img SRC="imgs/bold.gif" onclick="boldThis('header')">

RedDragon

//duplicate this function a zillion times, or you can mess with the
code a bit and pass the tags as additional parameters

hmm i would also need this for many other tags, any way that you can give me the fuction with parameters, coz im not sure how to handle variables in js

RedDragon

i noticed if no text is marked it gives the following error:
createTextRange is 0 or no object

how can i surpress this?

btw:

if i mark the word "Hello" and click the button it encloses the word by the tags but the cursor disappears, is it possible to place the cursor after the closing tag ?

mikeatrpi


<html>
<head>
	<title>Test</title>


<script type="text/javascript" language="javascript"> 

function storeCaret (textEl) 
{
	if (textEl.createTextRange) 
	{
    	textEl.caretPos = document.selection.createRange().duplicate();
	}
}


function insertAtCaret (textEl, text) 
{
    if (textEl.createTextRange && textEl.caretPos) 
	{
		var caretPos = textEl.caretPos;
        caretPos.text = caretPos.text.charAt(caretPos.text.length - 1) 
== ' ' ? text + ' ' : text;
    }
    else
	{
    	textEl.value += text;
	}     

}

function tagThis(Lo, opener, closer) 
{ 
	var div_string;
	strSelection = document.selection.createRange().text
	if (strSelection == "") {
		insertAtCaret(eval("document.all."+Lo), opener+closer);
		return;
	} 
	document.selection.createRange().text = opener + strSelection + closer
	return;
} 

</script>
</head>

<body topmargin="0" marginleft="0" marginheight="0" leftmargin="0" alink="#BC0016" link="#BC0016" vlink="#BC0016">

<p>&nbsp;
<p>&nbsp;
<p><font size="+2"><b>Front Page Edit:</b></font>

<form action="index.html" method="POST">

<p><input type="button" value="Bold" onclick="tagThis('frontpage', '<b>', '</b>')">
<p><input type="button" value="Italics" onclick="tagThis('frontpage', '<i>', '</i>')">

<br><b>Frontpage</b>
<textarea name="frontpage" rows=20 cols=80 max=16777215 wrap=soft ONSELECT="storeCaret(this);" ONCLICK="storeCaret(this);" ONKEYUP="storeCaret(this);"></textarea>
<p><div align="center"><input type="submit" name="submit" value="submit"></div></form>


</body>
</html>

I do not know how to get the cursor back. I got this code by trial and error and lots of help from a different forum over a year ago. Also, I tried to recreate your error but couldn't get it to show. Sorry?

Ultimater

Originally posted by mikeatrpi


//duplicate this function a zillion times, or you can mess with the 
code a bit and pass the tags as additional parameters
function boldThis(Lo) 
{ 
	strSelection = document.selection.createRange().text
	if (strSelection == "") {
		insertAtCaret(eval("document.all."+Lo), "<b></b>");
		return;
	} 
	document.selection.createRange().text = "<b>" + strSelection + "</b>"
	return;
}

[/B]

mikeatrpi, why would I duplicate that function a zillion times if it's not perfect?

Only an amateur would use eval("document.all."+Lo)

eval is a "should be avoided when possible" function.
most of the time eval can be replaced with window.
i.e. window["document.all"+Lo]
But in this case we can go one step further:
document.all[Lo]