IF-else statement problem

NSH

I hate when I have to resort to bothering people with questions. I however have pulled my hair out on this one. Basically I am trying to get the first part of the code for checking a username against the db.

Description:

I have a user add feature, I want to check to make sure the user doesn't already exist, if so echo it. If not add it.
I think what has complicated the issue, for me anyway, is the fact I am using PHP SELF with a form.

I can't seem to get the else function to work within an if:. The code will echo that it exists if it is already there, but won't do a thing if it's not..:

if (isset($useradd)) {
require("config.php");


mysql_select_db($DB_NAME);

$userquery = mysql_query("SELECT username FROM user WHERE username = '".$username."'");


// was it correct?
$exist = mysql_num_rows($userquery);

while ($v = mysql_fetch_array($userquery)) {

$uname = $v[0];


if($exist == 1)	{
echo "The username,<B>'$uname'</B> already exists.";
} else { 
echo "It doesn't exist";
}
}
}

hand

<?
if (isset($useradd)) {
   require("config.php");
   mysql_select_db($DB_NAME);
   $userquery = mysql_query("SELECT username FROM user WHERE username = '$username'")
      or print "&gt;&gt;&gt; MySQL-Error: ".mysql_errno()." -&gt; ".mysql_error()."<br>\n";
   $exist = mysql_num_rows($userquery);
   if($exist != 0) {
      while ($row = mysql_fetch_array($userquery)) {
         $uname = $row['username'];       

         echo "The username,<B>'$uname'</B> already exists.";
      }
   } else { 
      echo "The username, <B>'$username'</B> doesn't exist";
   }
}

ahundiak

First off, do you have a mysql_connect() statement?

Secondly, since username is going to be unique then

$userquery = mysql_query('whatever');
$cnt = mysql_num_rows($userquery);
if ($cnt == 0) {
  echo "It does not exist";
}
else {
  /* There is only one record so no need to loop
     Nor is there really any need to read the record but it can be done
 */
  $v = mysql_fetch_array($userquery);
  echo 'User ',$v[0],' Already in database';
}

The other thing to consider is that you have probably created a unique index on username (otherwise the query can be slow). With an unique index, you could just go ahead and try to insert the record and then check the results with mysql_affected_rows(). If username is duplicated then the insert will fail and mysql_affected_rows will be 0. This saves you from having to do the initial query.

NSH

Thanks for the help guys. works now
My mysql_connect is located in the config.php file

I do have the username as unique, but never crossed my mind to attempt to insert it and let it fail.

I really appreciate the help though!