Erorr Dividing Result

[Tommy-girl]

when i ran this script it gave erorr in line 26

<?
$db = mysql_pconnect("localhost", "q8smsm" , "808080") or die("ERROR--CAN'T CONNECT TO SERVER");
$select = mysql_select_db("q8smsm") or die("ERROR--CAN'T CONNECT TO Db");



 $limit        = 25;
 $query_count    = "select * from noemails where status = '1' ORDER BY stamp DESC";
 $result_count    = mysql_query($query_count);
 $totalrows    = mysql_num_rows($result_count);

 if(empty($page))
     $page = 1;


 $limitvalue = $page * $limit - ($limit);
 $query     = "select * from noemails where status = '1' ORDER BY stamp DESC LIMIT $limitvalue, $limit";
 $result    = mysql_query($query) or die("Error: " . mysql_error());

 if(mysql_num_rows($result) == 0)
     echo("Nothing to Display!");

 $bgcolor = #E0E0E0; // light gray

 echo("<table>");

 while($row = mysql_fetch_array($result)){
     if($bgcolor == #E0E0E0)
         $bgcolor = #FFFFFF;
     else
         $bgcolor = #E0E0E0;

 echo("<tr bgcolor=".$bgcolor.">\n<td>");
 echo($row["vic_user"]);
 echo("<td>\n\<td>");
 echo($row["password"]);
 echo("<td>\n</tr>");
 }

 echo("</table>");

 if($page != 1){
     $pageprev = $page--;

     echo("<a href=\"$PHP_SELF&page=$pageprev\">PREV</a>&nbsp;");
 }else
     echo("PREV&nbsp;");

 $numofpages = $totalrows / $limit;

 for($i = 1; $i <= $numofpages; $i++){
     if($i == $page)
         echo($i."&nbsp;");
     else
         echo("<a href=\"$PHP_SELF&page=$i\">$i</a>&nbsp;");


 if(($totalrows % $limit) != 0){
     if($i == $page)
         echo($i."&nbsp;");
     else
         echo("<a href=\"$PHP_SELF&page=$i\">$i</a>&nbsp;");

 if(($totalrows - ($limit * $page)) > 0){
     $pagenext     = $page++;

     echo("<a href=\"$PHP_SELF&page=$pageprev\">NEXT</a>");
 }else
     echo("&nbsp; NEXT ".$limit);

 mysql_free_result($result);

 ?>

[rapmonkey]

I see several things wrong with your if/else statements. All if/else statements must be as follows:

if (STATEMENT) {

WHATEVER

} else {

WHATEVER

}

Notice the usage of the { and }'s. That is what you are doing wrong.

[altexis]

which one is line 26???

if it is the one saying:
$numofpages = $totalrows / $limit;

then $limit might be 0 so $numofpages becomes infinent (which is not valid for computers). if that is the case take extra care for not allowing your script to reach this line with a $limit value of 0.

[altexis]

no!! rapmonkey you don't always have to put curly braces!!

if you use curly braces { } you just have to make sure you close them

and in this case I also see two sentences with curly braces not closed:
for($i = 1; $i <= $numofpages; $i++){
..and..
if(($totalrows % $limit) != 0){

[rapmonkey]

Well, uh... I was telling her that cause I saw she used the curly braces the wrong way. 😉

[Tommy-girl]

<?
$db = mysql_pconnect("localhost", "q8smsm" , "808080") or die("ERROR--CAN'T CONNECT TO SERVER");
$select = mysql_select_db("q8smsm") or die("ERROR--CAN'T CONNECT TO Db");



 $limit        = 25;
 $query_count    = "select * from noemails where status = '1' ORDER BY stamp DESC";
 $result_count    = mysql_query($query_count);
 $totalrows    = mysql_num_rows($result_count);

 if(empty($page))
     $page = 1;


 $limitvalue = $page * $limit - ($limit);
 $query     = "select * from noemails where status = '1' ORDER BY stamp DESC LIMIT $limitvalue, $limit";
 $result    = mysql_query($query) or die("Error: " . mysql_error());

 if(mysql_num_rows($result) == 0)
     echo("Nothing to Display!");

 $bgcolor = "#E0E0E0"; // light gray

 echo("<table>");

 while($row = mysql_fetch_array($result)){
     if($bgcolor == "#E0E0E0")
         $bgcolor = "#FFFFFF";
     else
         $bgcolor = "#E0E0E0";

 echo("<tr bgcolor=".$bgcolor.">\n<td>");
 echo($row["vic_user"]);
 echo("<td>\n<td>");
 echo($row["password"]);
 echo("<td>\n</tr>");
 }

 echo("</table>");

 if($page != 1){
     $pageprev = $page--;

     echo("<a href=\"$PHP_SELF&page=$pageprev\">PREV</a>&nbsp;");
 }else
     echo("PREV&nbsp;");

 $numofpages = $totalrows / $limit;

 for($i = 1; $i <= $numofpages; $i++){
     if($i == $page)
         echo($i."&nbsp;");
     else
         echo("<a href=\"$PHP_SELF&page=$i\">$i</a>&nbsp;");


 if(($totalrows % $limit) != 0){
     if($i == $page)
         echo($i."&nbsp;");
     else
         echo("<a href=\"$PHP_SELF&page=$i\">$i</a>&nbsp;");

 if(($totalrows - ($limit * $page)) > 0){
     $pagenext     = $page++;

     echo("<a href=\"$PHP_SELF&page=$pageprev\">NEXT</a>");
 }else
     echo("&nbsp; NEXT ".$limit);

}
}
 mysql_free_result($result);
 ?>

when i ran this script it show me this
PREV 1 1 NEXT2 2 NEXT

you can check it in this site

http://www.q8smsm.com/pages.php

[cgraz]

Wow that is some messy code. 😉

echo("<a href=\"$PHP_SELF&page=$pageprev\">NEXT</a>");

should be

echo("<a href=\"$PHP_SELF?page=$pageprev\">NEXT</a>");

use ? instead of & on the first variable you pass in the url. Then after that, if you need to pass more variables, then you use &.

Anyways, try something like this instead (you can copy and paste, I modified the code to fit your site)

<?

$db = mysql_connect("localhost", "q8smsm" , "808080") or die(mysql_error());
$select = mysql_select_db("q8smsm") or die(mysql_error());

$pagelimit = "25";

$query = mysql_query("SELECT * FROM noemails WHERE status = '1' ORDER BY stamp DESC");

$totalrows = mysql_num_rows($query);

$pagenums = ceil ($totalrows/$pagelimit);

if ($page=='') {
    $page='1';
}


$start = ($page-1) * $pagelimit;

echo "<b>" . $totalrows . " matches found</b><br>\n";

$starting_no = $start + 1;

if ($totalrows - $start < $pagelimit) {
   $end_count = $totalrows;
} elseif ($totalrows - $start >= $pagelimit) {
   $end_count = $start + $pagelimit;
}


echo "Results $starting_no to $end_count shown.<br>\n";

if ($totalrows - $end_count > $pagelimit) {
   $var2 = $pagelimit;
} elseif ($totalrows - $end_count <= $pagelimit) {
   $var2 = $totalrows - $end_count;
}

$space = "&nbsp;";

// previous link

if ($page>1) {
        echo "« <a href='$PHP_SELF?page=".($page-1)."' class=main>Previous" . $space . $pagelimit . "</a>" . $space . $space . "";
    }

// dynamic page number links

for ($i=1; $i<=$pagenums; $i++) {
    if ($i!=$page) {
        echo " <a href='$PHP_SELF?page=$i' class=main>$i</a>";
    }
    else {
        echo " <b class='red'>$i</b>";
    }
}


// next link

if ($page<$pagenums) {
    echo "" . $space . $space . $space . $space . " <a href='$PHP_SELF?page=".($page+1)."' class=main>Next " . $var2 . "</a> »";
}

// run query again using LIMIT
$strSQL = mysql_query("SELECT * FROM noemails WHERE status='1' ORDER BY stamp LIMIT $start,$pagelimit");


 if (mysql_num_rows($strSQL) == '0') {
     echo("Nothing to Display!");
 } else {


// row colors
      $row_color="#FFFFFF"; 
      $count_rows = "0"; 

echo "<table width=400 cellpadding=0 cellspacing=0 border=0>\n";


while ($row = mysql_fetch_array($strSQL)) {

       $count_rows++; 
             if ($count_rows%2==0) 
                 { $row_color="#FFFFFF"; } // Even-numbered rows 
             else 
                 { $row_color="#E0E0E0"; } // Odd-numbered rows 


      print "<tr bgcolor=" . $row_color . ">\n";
      print "<td width=200>&nbsp; " . $row["vic_user"] . "</td>\n";
      print "<td width=200>&nbsp; " . $row["password"] . "</td>\n";
      print "</tr>\n";

}



}


?>

Cgraz

[Tommy-girl]

thanx cgras ....
but i found some trouble in how can i move the next and the numbers of pages

in the footer??

[cgraz]

the code is all commented!!!!!

Change this part of the code (starting at the <table> tag to this:

echo "<table width=400 cellpadding=0 cellspacing=0 border=0>\n";


while ($row = mysql_fetch_array($strSQL)) {

       $count_rows++; 
             if ($count_rows%2==0) 
                 { $row_color="#FFFFFF"; } // Even-numbered rows 
             else 
                 { $row_color="#E0E0E0"; } // Odd-numbered rows 


      print "<tr bgcolor=" . $row_color . ">\n";
      print "<td width=200>&nbsp; " . $row["vic_user"] . "</td>\n";
      print "<td width=200>&nbsp; " . $row["password"] . "</td>\n";
      print "</tr>\n";

}

echo "</table>";

// previous link

if ($page>1) {
        echo "« <a href='$PHP_SELF?page=".($page-1)."' class=main>Previous" . $space . $pagelimit . "</a>" . $space . $space . "";
    }

// dynamic page number links

for ($i=1; $i<=$pagenums; $i++) {
    if ($i!=$page) {
        echo " <a href='$PHP_SELF?page=$i' class=main>$i</a>";
    }
    else {
        echo " <b class='red'>$i</b>";
    }
}


// next link

if ($page<$pagenums) {
    echo "" . $space . $space . $space . $space . " <a href='$PHP_SELF?page=".($page+1)."' class=main>Next " . $var2 . "</a> »";
}

}

Notice the comments on next link, previous link, and dynamic page links.

Cgraz