repeat repeat repeat

sonicfusion

right....
i hve a problem... 1st lets look at the code...

news_inc.php

<? 
include('HIDDEN FOR SECURITY');
mysql_pconnect("$host","$user","$pass"); 
mysql_select_db("$base"); 
$news_inc_result = mysql_query("SELECT `type` FROM `tbl_sf_news` ORDER BY `type` ASC"); 
while($news_inc=mysql_fetch_array($news_inc_result)) 
{     

    $type=$news_inc["type"]; 
	include('inc/news_mini.php');
} 
?>

news_mini.php

<? 
/* $type = ''; required before include*/
include('HIDDEN FOR SECURITY');
echo("$type:<br>");
mysql_pconnect("$host","$user","$pass"); 
mysql_select_db("$base"); 
$news_mini_result = mysql_query("SELECT `id`,`title` FROM `tbl_sf_news` WHERE 1 AND `type` LIKE '$type' ORDER BY `date` ASC LIMIT 0, 3"); 
while($news_mini=mysql_fetch_array($news_mini_result)) 
{     

    $id=$news_mini["id"]; 
    $title=$news_mini["title"]; 
	$date=$news_mini["date"];
echo("<a href='http://www.sonicfusion.co.uk/news.php?id=$id'>//$title - $date</a><br>");
} 
echo("<br>");
?>

right and now look at the results at www.sonicfusion.co.uk

why are the types repeting how can i make it so each typ only appears once?

thanks in advance

keith73

You have nested while loops.

In news_inc.php you have a while loop that uses the result of your first query. Inside the loop you are calling news_mini.php which itself is iterating through a while loop.

You should do a mysql_num_rows to see how many results you're getting back from the first query. I'm guessing it's returning 2 rows. That loop goes around twice and the news_mini.php gets displayed twice.

Keith

I just thought of something. Try combining your two queries. It seems unnecessary to have them both.

Try this (I'm not 100% sure it will work)

SELECT type,id,title FROM tbl_sf_news ORDER BY type,date ASC

then use one loop to go through the whole thing.

sonicfusion

where might i find a tutorial for mysql_nom_rows in this kinda situation... sorry if i'm considered a time waster but i'm not quite understanding the whole php/mysql bit properly yet.

sonicfusion

thanks keith i'll give it a go

sonicfusion

i don't think the query...

SELECT type,id,title FROM tbl_sf_news ORDER BY type,date ASC

...will work because i want only three results for each type.

keith73

Sorry, just add the LIMIT 3 to the end of the query.

SELECT type,id,title FROM tbl_sf_news ORDER BY type,date ASC LIMIT 3

as for mysql_num_rows, it's simple.
here's a link to it in the php manual:
http://www.php.net/manual/en/function.mysql-num-rows.php

just pass your result to it in a print or echo statement before entering your loop.

print mysql_num_rows($news_inc_result) . "<br>;
 while($news_inc=mysql_fetch_array($news_inc_result))
{
...do something here...
}

sonicfusion

your query doesn't work as i'ld like it to... it only shows three results. i would like to show three results for each type.

also call me stupid but i STILL cannot work out the mysql_num_rows bit.

sorry for your inconvenience:rolleyes:

Weedpacket

mysql_num_rows is pretty simple.

If you run a SELECT query
$result = mysql_query("SELECT blahblahblah");
then mysql_num_rows($result);
will say how many rows were returned in the result. So if there were three results returned by the query, mysql_num_rows() will tell you so.

Here's how I usually loop over a database query:

$sql = "SELECT blahblahblah";
$result = mysql_query($sql);
$result_count = mysql_num_rows($result);
if($result_count==0)
{  // Gracefully handle the situation when
   // no results are returned.
}
else
{  for($i=0; $i<$result_count; ++$i)
   {  $row = mysql_fetch_array($result);
      // And I can also use $i for indexing,
      // alternating background colours, or whatever.
   }
}

Faster than a while($result=mysql_fetch_array()) in particular, because I don't need to do an entire fetch_array just to find out I'm already at the end.

Now, your problem.

The thing is that you're asking for all the types listed, however many times they appear. You only want each distinct type in the table, not the type from every row in the table, which is what you're asking for now.

So try this query when getting the types:
SELECT DISTINCT type FROM tbl_sf_news ORDER BY type