parse error line 146... can't see the error at all...

touchY

Okay thanks to keith the parse error is fixed but I used the script 3-4 times and it worked and now it wont update the info anyone think they know how to fix it ?

<?php
include ("include.inc.php");
if ($Username == "")
{
header("Location: login.php");
}else{

mysql_query("SELECT * FROM NP_Users WHERE id = '$id'");

$gender = $User_Info[mygender];
$name = $User_Info[myname];
$email = $User_Info[myemail];
$age = $User_Info[myage];
$password = $User_Info[password];
$username = $User_Info[username];
$id = $User_Info[id];
$profile = $User_Info[profile];

switch ( $go ) {
default:
echo "Edit your details below.<BR>If you don't want to change your password, Leave it blank.<BR><BR>
<center>
<form method=\"post\" action=\"$PHP_SELF?go=alter\">
<table>
<tr>
<td>Username:</td>
<td>$username</td>
</tr>
<tr>
<td>Password:</td>
<td><input type=\"password\" name=\"pass\" value=\"\"></td>
</tr>
<tr>
<td>
Confirm Password:</td>
<td><input type=\"text\" name=\"cpass\" value=\"\"></td>
</tr>
<tr>
<td>Name:</td>
<td><input type=\"text\" name=\"name\" value=\"$name\"></td>
</tr>
<tr>
<td>Email:</td>
<td><input type=\"text\" name=\"email\" value=\"$email\"></td>
</tr>
<tr>
<td>Age:</td>
<td><select name=age class=\"drop\"><option value='$age'>$age</option>
<option value='5'>5</option>
<option value='6'>6</option>
<option value='7'>7</option>
<option value='8'>8</option>
<option value='9'>9</option>
<option value='10'>10</option>
<option value='11'>11</option>
<option value='12'>12</option>
<option value='13'>13</option>
<option value='14'>14</option>
<option value='15'>15</option>
<option value='16'>16</option>
<option value='17'>17</option>
<option value='18'>18</option>
<option value='19'>19</option>
<option value='20'>20</option>
<option value='21'>21</option>
<option value='22'>22</option>
<option value='23'>23</option>
<option value='24'>24</option>
<option value='25'>25</option>
<option value='26'>26</option>
<option value='27'>27</option>
<option value='28'>28</option>
<option value='29'>29</option>
<option value='30'>30</option>
<option value='31'>31</option>
<option value='32'>32</option>
<option value='33'>33</option>
<option value='34'>34</option>
<option value='35'>35</option>
<option value='36'>36</option>
<option value='37'>37</option>
<option value='38'>38</option>
<option value='39'>39</option>
<option value='40'>40</option></td>
</tr>
<tr>
<td>Gender:</td>";

if ($gender == "Male") {
$gender2="Female";
} else {
$gender2="Male";
}
echo "
<td><select name=gender class=\"drop\"><option value=\"$gender\">$gender</option>
<option value=\"$gender2\">$gender2</option>
</td>
</tr>
<tr>
<td>Profile:</td>
<td><textarea name=\"profile\" value=\"$profile\"></textarea></td>
</tr>
<tr>
<td cellspan=\"2\">
<input type=\"submit\" value=\"Edit\">
</td>
</tr>
</table>
</form>";

break;

case "alter":

if ((!$pass) || (!$cpass)) {
if ((!$name) || (!$age) || (!$email) || (!$gender)) {
header("Location: $PHP_SELF?error=Please fill in all details.");
exit;
}
mysql_query("UPDATE NP_Users SET myname='$name',myage='$age',mygender='$gender',myemail='$email',profile='$profile' WHERE id='$id'");
}
if ($pass != "") {

if ($pass != $cpass) {
header("Location: $PHP_SELF?error=Passwords do not match.");
exit;
}

if ((!$name) || (!$age) || (!$email) || (!$gender)) {
header("Location: $PHP_SELF?error=Please fill in all details.");
exit;
}
$epass = md5($pass);

mysql_query("UPDATE NP_Users SET myname='$name',myage='$age',mygender='$gender',myemail='$email',profile='$profile',password='$epass' WHERE id='$id'");

}

break;

case "edited":
echo "Your account has been edited!";
break;
}
}
?>

keith73

I copied your code into homesite where I can view line #'s and this is where I see line 146

echo "Your account has been edited!";

If the problem is not on that line, then it must be on a line above it. Usually that you didn't close a " or ' or }

I see another problem with line 21:

	echo "Edit your details below.<BR>If you don't want to change your password, Leave it blank.<BR><BR>

here you didn't close the " or place a ; at the end of the line. The text you are outputting should probably be in a here document.

print <<END
HTML CODE HERE
END;

or by concatenating lines with .
echo "line1" .
"line2".
"line3";

Keith

touchY

thats just one long echo command that shouldnt cause any harm

keith73

thats just one long echo command that shouldnt cause any harm

The problem isn't in the echo statement. But I was right about the problem being somewhere other than on line 146.

is line 146 where you close the php with

?>

I think the last } in your code closes the switch statement, but you never close the opening if-else.

throw a } at the end of the code.

Keith

touchY

thanks kieth it worked when you told me that I kept looking at the closing of the ifstatements but tottally ignored the very top thank you again =D

touchY

any ideas on the new problem i didn't edit the script it just stopped updating the database ..

sgoku01

Maybe it's because you're closing the switch, and then you tell to break??
(You're doing this🙂

<?php 
include ("include.inc.php"); 
	if ($Username == "") 
	{ 
	header("Location: login.php"); 
	}
	else
	{ 

mysql_query("SELECT * FROM NP_Users WHERE id = '$id'"); 

$gender = $User_Info[mygender]; 
$name = $User_Info[myname]; 
$email = $User_Info[myemail]; 
$age = $User_Info[myage]; 
$password = $User_Info[password]; 
$username = $User_Info[username]; 
$id = $User_Info[id]; 
$profile = $User_Info[profile]; 

	switch ( $go ) 
	{ 
	default: 
	echo "Edit your details below.<BR>If you don't want to change your password, Leave it blank.<BR><BR> 
	<center> 
	<form method=\"post\" action=\"$PHP_SELF?go=alter\"> 
	<table> 
	<tr> 
	<option value='40'>40</option></td> 
	</tr> 
	<tr> 
	<td>Gender:</td>"; 
		if ($gender == "Male") 
		{ 
		$gender2="Female"; 
		}
		else 
		{ 
		$gender2="Male"; 
		} 
	echo " 
	<td><select name=gender class=\"drop\"><option value=\"$gender\">$gender</option> 
	<option value=\"$gender2\">$gender2</option> 
	</td> 
	</tr> 
	<tr> 
	<td>Profile:</td> 
	<td><textarea name=\"profile\" value=\"$profile\"></textarea></td> 
	</tr> 
	<tr> 
	<td cellspan=\"2\"> 
	<input type=\"submit\" value=\"Edit\"> 
	</td> 
	</tr> 
	</table> 
	</form>"; 
	break; 

	case "alter": 

		if ((!$pass) || (!$cpass)) 
		{ 
			if ((!$name) || (!$age) || (!$email) || (!$gender)) 
			{ 
			header("Location: $PHP_SELF?error=Please fill in all details."); 
			exit; 
			} 
		mysql_query("UPDATE NP_Users SET myname='$name',myage='$age',mygender='$gender',mye
		mail='$email',profile='$profile' WHERE id='$id'"); 		
		} 
		if ($pass != "") 
		{ 

			if ($pass != $cpass) 
			{ 
			header("Location: $PHP_SELF?error=Passwords do not match."); 
			exit; 
			} 

		if ((!$name) || (!$age) || (!$email) || (!$gender)) 
		{ 
		header("Location: $PHP_SELF?error=Please fill in all details."); 
		exit; 
		} 
	$epass = md5($pass); 

	mysql_query("UPDATE NP_Users SET myname='$name',myage='$age',mygender='$gender',mye
mail='$email',profile='$profile',password='$epass' WHERE id='$id'"); 


	} 
	break; 

	case "edited": 
	echo "Your account has been edited!"; 
	break; 
} 
} 
?>

Now count all the { and } again 🙂

touchY

hmm thanks for poitning that out but it still doesnt update the table the only thing it updates is the new password if you enter it but nothing else

sgoku01

And what happens when you change this:

mysql_query("UPDATE NP_Users SET  myname='$name',myage='$age',mygender='$gender',myemail='$email',profile='$profile',password='$epass' WHERE id='$id'");

into this:

mysql_query("UPDATE NP_Users SET  myname='".$HTTP_GET_VARS['name']."', myage='".$HTTP_GET_VARS['age']."', mygender='".$HTTP_GET_VARS['gender']."', myemail='".$HTTP_GET_VARS['email']."', profile='".$HTTP_GET_VARS['profile']."', password='".$HTTP_GET_VARS['epass']."' WHERE id='$id'");