if statement problems

[Demel]

Hi there
Great forum. I was reading quietly already and decided to register as I am having difficulties getting some stuff to work.

I am having a form sending variables to a process.php file in the background. That process.php file looks for a value of a variable and assigns it to another variable for processing purposes. I use 5 "if statements" to do this.

if ($data2= 13) {  $data3 = "13";}   

if ($data2 = 26) {  $data3 = "26";} 
if ($data2 = 39) {  $data3 = "39";} 
if ($data2 = 52) {  $data3= "52";} 
if ($data2 = 65) {  $data3 = "65"; }

However - instead of accepting a condition it meets, it runs through all the "if" statements selecting the very last value and therefore messing up everything else that follows further down that script.

Any idea why this happens and how I could solve it?

Thanks!

D.

[bastien]

single equal signs are assignment factors setting the variable to the value onthe right hand side of the equal signs

try changing to two equal signs (==) to make a comparison test
also can use the elseif statement to make it look better since they all test the same variable $data2...

if ($data2 == 13) {

$data3 = "13";
}elseif ($data2 == 26) {
$data3 = "26";
}elseif ($data2 == 39) {

$data3 = "39";
}elseif ($data2 == 52) {
$data3= "52";
}elseif ($data2 == 65) {

$data3 = "65";
}

hth

[Demel]

Does not work. After I made the suggested change it does not recognize the amount value anymore.

Any other idea why this might happen?

D.

[ahundiak]

Better post your new code. The == should have done the trick. Are you sure $data2 is being set? Might try echoing it out.

Another way to wrtie this is with a switch statement.

switch($data2)
{
case 13: $data3 = 13; break;
case 26: $data3 = 26; break;
// Rest of the case statements

default:
echo 'Unknown value for data2 ',$data2;
}

Even better would be to use an array.

[Demel]

The echo does not display any data for $data2 - so, I guess there is a problem sending the variable from the order form to process.php.

switch($time_period){
     case 0:
          print 'Not a valid time period';
          break;
     default:
          $x_data2=$period*13.00;
          echo 'Registration fee: '.number_format($data2,2);

This is how I specify the value of $data2 in my order form. Should not that bring it over to the process.php once the form is submitted?

D.

[Demel]

If I do it like this

if ($data2 == 13) {  $data3 = "13";
}   

elseif ($data2 == 26) {  $data3 = "26";
} 
elseif ($data2== 39) {  $data3 = "39";
} 
elseif ($data2 == 52) {  $data3 = "52";
} 
elseif ($data2 == 65) {  $data3 = "65";

it uses the last value.

If I do it like this

if ($data2 = 13) {  $data3 = "13";
}   

elseif ($data2 = 26) {  $data3 = "26";
} 
elseif ($data2 = 39) {  $data3 = "39";
} 
elseif ($data2 = 52) {  $data3 = "52";
} 
elseif ($data2 = 65) {  $data3 = "65";

it uses the very first value.

I don't know what to do? As seen above - I set the variable in my order form (before it gets submitted). What am I doing wrong?

D.

[ahundiak]

Post your complete order form code. You need to be creating a form with the $data2 value in some submit field.

Not matter what you do, it's not going to work unles $data2 is set.

[Demel]

In the beginning I store data collected earlier in my database. I now collect payment information. $period needs to translate into the dollar amount ($13.00 x whatever period selected). That dollar amount needs to be processed and does not seem to arrive at the process.php file.

D.

<?
  $db = mysql_connect("localhost", "database_user", "password"); 
        mysql_select_db ("database_name"); 

  $uniqueid = md5(uniqid(rand(),1)); 

  mysql_query("insert into customer values('$uniqueid', '$domain', '$reg_username', '$reg_password', '$reg_domain', '$reg_type', '$bulk_order', '$period', '$affiliate_id', '$owner_first_name', '$owner_last_name', '$owner_org_name', 
'$owner_address1', '$owner_address2', '$owner_address3', '$owner_city', '$owner_state', '$owner_postal_code', '$owner_country', '$owner_email', '$owner_phone', '$owner_fax', 
'$admin_first_name', '$admin_last_name', '$admin_org_name', '$admin_address1', '$admin_address2', '$admin_address3', '$admin_city', '$admin_state', '$admin_postal_code', '$admin_country', 
'$admin_email', '$admin_phone', '$admin_fax', '$billing_first_name', '$billing_last_name', '$billing_org_name', '$billing_address1', '$billing_address2', '$billing_address3', '$billing_city', '$billing_state', '$billing_postal_code', '$billing_country', '$billing_email', '
$billing_phone', '$billing_fax', '$p_cc_num', '$p_cc_type', '$p_cc_exp_mon', '$p_cc_exp_yr', '$action', '$mldn', '', 'client254', '$app_purpose', '$nexus_category', '$nexus_validator')");

  mysql_close($db);

  $fp = fopen("../templates/reg_system/base.html","r");
  while (!feof($fp)){
    $line=fgets($fp,1024);
		$pos = strpos($line, "{{CONTENT}}");
    if ($pos === false) { 
      echo $line;
		} else {
		  $line1 = substr($line, 0, $pos);
			$line2 = substr($line, $pos+11);
			echo $line1;
      break;
    }
  }
?>
<html>
<head>
<title>Order Form</title>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
</head>

<body bgcolor="#FFFFFF">

<table width="344" border="0">
  <tr> 
    <td width="338" align="left" valign="top"> 
<form method="post" action="process.php">

<table width="223" border="0">
        <tr align="left" valign="top"> 
          <td width="90"> 
            <p><font face="Verdana, Arial, Helvetica, sans-serif" size="1"><b>First 

	      Name:</b></font> 

    <input type="text" name="first_name" size="15" value="" style="font-family:verdana; font-size:10px; border-top-width:1px; border-left-width:1px;">

        </p>
      </td>
      <td width="123"><font face="Verdana, Arial, Helvetica, sans-serif" size="1"><b>Last 
        Name:</b></font> 
        <input type="text" name="last_name" size="15" style="font-family:verdana; font-size:10px; border-top-width:1px; border-left-width:1px;">
      </td>
    </tr>
    <tr align="left" valign="top"> 
      <td width="90"><font face="Verdana, Arial, Helvetica, sans-serif" size="1"><b>Phone 
        Number:</b></font> 
        <input type="text" name="day_phone" size="15" style="font-family:verdana; font-size:10px; border-top-width:1px; border-left-width:1px;">
      </td>
      <td width="123"><font face="Verdana, Arial, Helvetica, sans-serif" size="1"><b>Fax 
        Number:</b></font> 
        <input type="text" name="fax" size="15" style="font-family:verdana; font-size:10px; border-top-width:1px; border-left-width:1px;">
      </td>
    </tr>
  </table>
  <table width="223" border="0">
    <tr> 
      <td> 
        <p><font face="Verdana, Arial, Helvetica, sans-serif" size="1"><b>Email 
          Address: </b></font> 
          <input type="text" name="email" size="40" style="font-family:verdana; font-size:10px; border-top-width:1px; border-left-width:1px;">
          <font face="Verdana, Arial, Helvetica, sans-serif" size="1">(must 
          be a valid e-mail address)</font></p>
      </td>
    </tr>
  </table>
  <table width="223" border="0">
    <tr> 
      <td> 
        <p><font face="Verdana, Arial, Helvetica, sans-serif" size="1"><b>Company 
          Name: </b></font> 
          <input type="text" name="company" size="40" style="font-family:verdana; font-size:10px; border-top-width:1px; border-left-width:1px;">
        </p>
      </td>
    </tr>
  </table>
  <table width="223" border="0">
    <tr> 
      <td> 
        <p><font face="Verdana, Arial, Helvetica, sans-serif" size="1"><b> 
          Address - Line1: </b></font> 
          <input type="text" name="address" size="40" style="font-family:verdana; font-size:10px; border-top-width:1px; border-left-width:1px;">
        </p>
      </td>
    </tr>
  </table>
  <table width="223" border="0">
    <tr> 
      <td> 
        <p><font face="Verdana, Arial, Helvetica, sans-serif" size="1"><b>Address 
          - Line2: </b></font> 
          <input type="text" name="address2" size="40" style="font-family:verdana; font-size:10px; border-top-width:1px; border-left-width:1px;">
        </p>
      </td>
    </tr>
  </table>
  <table width="298" border="0">
    <tr align="left" valign="top"> 
      <td width="70" height="7"> 
        <div align="center"> <b><font face="Verdana, Arial, Helvetica, sans-serif" size="1">City: 
          </font></b></div>
      </td>
      <td width="81" height="7"> 
        <div align="center"> <b><font face="Verdana, Arial, Helvetica, sans-serif" size="1">State/Province:</font></b></div>
      </td>
      <td width="133" height="7"> 
        <div align="center"> <b><font face="Verdana, Arial, Helvetica, sans-serif" size="1">Zip:</font></b></div>
      </td>
    </tr>
    <tr align="center"> 
      <td width="70"> 
        <input type="text" name="city" size="12" style="font-family:verdana; font-size:10px; border-top-width:1px; border-left-width:1px;">
      </td>
      <td width="81"> 
        <input type="text" name="state" size="2" style="font-family:verdana; font-size:10px; border-top-width:1px; border-left-width:1px;">
      </td>
      <td width="133"> 
        <input type="text" name="zip" size="5" style="font-family:verdana; font-size:10px; border-top-width:1px; border-left-width:1px;">
      </td>
    </tr>
  </table>
  <table width="223" border="0">
    <tr align="left" valign="top"> 
      <td> <font face="Verdana, Arial, Helvetica, sans-serif" size="1"><b>Country: 
        <br>
        <br>
        </b></font> 
        <select name="country" style="font-family:verdana; font-size:10px; border-top-width:1px; border-left-width:1px;">
          <option SELECTED value="">Choose a Country 
          <option value="USA">United States of America 
          <option value="CAN">Canada 

          <option value="UNK">Not Listed___________________________ 
        </select>
      </td>
    </tr>
  </table>

<br>
<table width="223" border="0">

<tr> 

<td> 

<p><font face="Verdana, Arial, Helvetica, sans-serif" size="1"><b>Credit Card 
                Number:</b></font> 
                <input type="text" name="credit_card_number" size="40" style="font-family:verdana; font-size:10px; border-top-width:1px; border-left-width:1px;">
              </p>
              <p><font size="1" face="Arial, Helvetica, sans-serif"><strong>Security 
                Code</strong> </font><br>
                <input name="card_code" type="text" id="card_code">
              </p>
              </td>
</tr>

</table>
<table width="223" border="0">

<tr align="left" valign="top"> 

<td width="90" height="47"> 

<p><font face="Verdana, Arial, Helvetica, sans-serif" size="1"><b>Month:</b></font>

<br>
                <select name="expmo" style="font-family:verdana; font-size:10px; border-top-width:1px; border-left-width:1px;">
                  <option value="01">01</option>
<option value="02">02</option>
<option value="03">03</option>
<option value="04">04</option>
<option value="05">05</option>
<option value="06">06</option>
<option value="07">07</option>
<option value="08">08</option>
<option value="09">09</option>
<option value="10">10</option>
<option value="11">11</option>
<option value="12">12</option>
</select>

        </p>
</td>
<td width="123"><font face="Verdana, Arial, Helvetica, sans-serif" size="1"><b>Year:</b></font>

<br>
              <select name="expyr" style="font-family:verdana; font-size:10px; border-top-width:1px; border-left-width:1px;">

<option value="2002">2002</option>
<option value="2003">2003</option>
<option value="2004">2004</option>
<option value="2005">2005</option>
<option value="2006">2006</option>
<option value="2007">2007</option>
<option value="2008">2008</option>
</select>
          </td>
</tr>


</table>
<br>

<?



switch($period){
     case 0:
          print 'Please select a registration period!';
          break;
     default:
          $data2=$period*13.00;
          echo 'Registration fee: '.number_format($data2,2);
}





?>
<p><br>

<input type="submit" value="Submit Order Information">
</p>
</form>
      <br>
    </td>
  </tr>
</table>

</body>
</html>

[siwis]

Where's the value of $period assigned?

I can't see any place in the code you posted where $period is assigned a value. Therefore because $period is assumed to be false $data2 will similarl;y never be assigned a value.

Could be wildly off mark but from a quick glance I'd guess that was your problem.

Try echoing the value of $period and $data2 at relevant points in your 2 scripts.

[Demel]

$period gets its value on the page before. The customer would select a value between 1 and 10.

This part

<?



switch($period){
     case 0:
          print 'Please select a registration period!';
          break;
     default:
          $data2=$period*13.00;
          echo 'Registration fee: '.number_format($data2,2);
}


?>

will echo the value based on the $period (i.e. 1 = 13, 2 = 26, etc.). That part works fine - depending on the period value I see the proper amount displayed below the cc part.

So, what else might cause this problem?

D.

[ahundiak]

You just need to add $data2 to the form. Probably as a hidden field so the process.php script can see it.

[Demel]

Probably a dumb question (here speaks the newbie in me) - but how would I do that and will it needs to be place before I 'echo' the value or after?

Thanks!

D.

[ahundiak]

Right after
echo 'Registration fee: '.number_format($data2,2);

echo
'<input type="hidden" name="data2" value="',
number_format($data2,2),
'" />';

I didn't test it but that should do the trick.

[Demel]

I added this line to the html part:

<input type="hidden" name="data2" value="">

Is this what you meant?

Please let me know!

D.

[ahundiak]

Not quite. You need to get the value of $data2 in it which means it needs to be inside of some php code.

Just paste the new echo command in right after the existing echo command.

Then run the script and use your browser's view source to verify it got added correctly.

Then hit the submit button and see if the process.php script got the value.

[Demel]

It does not work!🙁 It still uses the wrong dollar amount in the end. This is very frustrating as it does not make sense to me. Everything is in place and it processes my order - but using the wrong amount.

[Demel]

I got it to work!! Yeehaaaaaaa!

I left the code in the order form the way it was (including your 'echo' command. I added this to my process file - removing the if statements:

switch($data2){
     case 0:
          print 'Please select a registration period!';
          break;

case 13: case 26: case 39: case 52: case 65: case 78: case 91: case 104: case 117: case 130:
          $data3=$data2;
          break;
}

I tried 2 different periods and it works like a champ!!!!!!!!!!!!

Thank you for your help!!!!!!! I really appreciate it!

D.

[ahundiak]

Well, you starting off with a pretty big project.

You might need to backup a bit and focus a bit more on learning.

Try making a simple script where all the user does is specify the $period and posts it.

Then make a second script which calculates $data2
and add it to a form.

Then make the third script which calculates $data3 from $data2.

[Demel]

I know, I know. The thing is - I had a friend doing this for me. He is experienced in PHP. However - he left me in the dark half-way through. Here I am working my way through code that I haven't written and that actually comes from 2 different sources. I have to marry it together. 🙂

I spend the whole day on this thing but finally got it to work! So, I am now 2/3 done. I need to get started on the passback value handling now. So, please be not surprised if you see me again soon. 😉

D.