Form broke under PHP 4.3.0

hunterp

I have some forms that worked fine under earlier versions of PHP but don't work anymore after an upgrade to PHP 4.3.0. The form takes the data and sends it as a email. The data assigned to the variable names does not seem to be getting passed between the form and script. Does anybody know if there were changes made the might affect this? My code is below:

<?
$message = "Name: $firstn $lastn\n";
$message .= "Email Address: $email\n\n";
$message .= "Address:\n";
$message .= "$address1\n";
$message .= "$address2\n";
$message .= "$address3\n";
$message .= "$city\n";
$message .= "$state\n";
$message .= "$zip\n";
$message .= "$country\n\n";
$message .= "Telephone Information:\n";
$message .= "Country Code: $ccode\n";
$message .= "($acode) $phone\n\n";
$message .= "Comments:\n";
$message .= "$comments";

mail("phunter@hass.usu.edu", "Request for Information from HASS Web Site", $message);
?>

Thanks for any tips.

Patrick Hunter

sgoku01

Did you try to use $HTTP_POST_VARS['variable'] ??

e.g.

$message = "Name: $HTTP_POST_VARS['firstn'] $HTTP_POST_VARS['$lastn']\n";

hunterp

Originally posted by sgoku01
Did you try to use $HTTP_POST_VARS['variable'] ??

e.g.
$message = "Name: $HTTP_POST_VARS['firstn'] $HTTP_POST_VARS['$lastn']\n"; 
[/B]

I tried it and no luck.

Patrick

rohithmr

can u plz post the HTML for the form?

Also theres a small typo in the previous suggestion. There shuddnt b a '$' sign on the second $HTTP_POST_VARS's index.

$HTTP_POST_VARS['variableName'];

NOT

$HTTP_POST_VARS['$variableName'];

hunterp

Originally posted by rohithmr
can u plz post the HTML for the form?

Here is the code:

<form method="post" action="request.php" name="request">
<table width="100%" border="0" cellspacing="5">
<tr>
<td valign="top" width="126" bgcolor="#507098"><font face="Tahoma, Verdana, Arial, sans-serif" size="-1" color="#FFFFFF">First
Name:</font></td>
<td width="328" valign="top">
<input type="text" name="firstn" size="25">
</td>
</tr>
<tr>
<td valign="top" width="126" bgcolor="#507098"><font face="Tahoma, Verdana, Arial, sans-serif" size="-1" color="#FFFFFF">Last
Name: </font></td>
<td width="328" valign="top">
<input type="text" name="lastn" size="25">
</td>
</tr>
<tr>
<td valign="top" width="126" bgcolor="#507098"><font face="Tahoma, Verdana, Arial, sans-serif" size="-1" color="#FFFFFF">Email
Address: </font></td>
<td width="328" valign="top">
<input type="text" name="email" size="35">
</td>
</tr>
<tr>
<td valign="top" width="126"> </td>
<td width="328" valign="top"> </td>
</tr>
<tr>
<td valign="top" width="126"> </td>
<td width="328" valign="top"><font face="Tahoma, Verdana, Arial, sans-serif"><b>Address
Information </b></font></td>
</tr>
<tr>
<td valign="top" width="126" bgcolor="#507098"><font face="Tahoma, Verdana, Arial, sans-serif" size="-1" color="#FFFFFF">Address
1: </font></td>
<td width="328" valign="top">
<input type="text" name="address1" size="40">
</td>
</tr>
<tr>
<td valign="top" width="126" bgcolor="#507098"><font face="Tahoma, Verdana, Arial, sans-serif" size="-1" color="#FFFFFF">Address
2: </font></td>
<td width="328" valign="top">
<input type="text" name="address2" size="40">
</td>
</tr>
<tr>
<td valign="top" width="126" bgcolor="#507098"><font face="Tahoma, Verdana, Arial, sans-serif" size="-1" color="#FFFFFF">Address
3: </font></td>
<td width="328" valign="top">
<input type="text" name="address3" size="40">
</td>
</tr>
<tr>
<td valign="top" width="126" bgcolor="#507098"><font face="Tahoma, Verdana, Arial, sans-serif" size="-1" color="#FFFFFF">City:</font></td>
<td width="328" valign="top">
<input type="text" name="city" size="30">
</td>
</tr>
<tr>
<td valign="top" width="126" bgcolor="#507098"><font face="Tahoma, Verdana, Arial, sans-serif" size="-1" color="#FFFFFF">State/Province:</font></td>
<td width="328" valign="top">
<input type="text" name="state" size="30">
</td>
</tr>
<tr>
<td valign="top" width="126" bgcolor="#507098"><font face="Tahoma, Verdana, Arial, sans-serif" size="-1" color="#FFFFFF">Zip/Postal
Code: </font></td>
<td width="328" valign="top">
<input type="text" name="zip" size="11">
</td>
</tr>
<tr>
<td valign="top" width="126" bgcolor="#507098"><font face="Tahoma, Verdana, Arial, sans-serif" size="-1" color="#FFFFFF">Country:</font></td>
<td width="328" valign="top">
<input type="text" name="country" size="30">
</td>
</tr>
<tr>
<td valign="top" width="126"> </td>
<td width="328" valign="top"> </td>
</tr>
<tr>
<td valign="top" width="126"> </td>
<td width="328" valign="top"><b><font face="Tahoma, Verdana, Arial, sans-serif">Telephone
Information </font></b></td>
</tr>
<tr>
<td valign="top" width="126" bgcolor="#507098"><font face="Tahoma, Verdana, Arial, sans-serif" size="-1" color="#FFFFFF">Country
Code (if outside of US):</font></td>
<td width="328" valign="top">
<input type="text" name="ccode" size="10">
</td>
</tr>
<tr>
<td valign="top" width="126" bgcolor="#507098"><font face="Tahoma, Verdana, Arial, sans-serif" size="-1" color="#FFFFFF">Area
Code: </font></td>
<td width="328" valign="top">
<input type="text" name="acode" size="4">
</td>
</tr>
<tr>
<td valign="top" width="126" bgcolor="#507098"><font face="Tahoma, Verdana, Arial, sans-serif" size="-1" color="#FFFFFF">Phone
Number: </font></td>
<td width="328" valign="top">
<input type="text" name="phone" size="8">
</td>
</tr>
<tr>
<td valign="top" width="126"> </td>
<td width="328" valign="top"> </td>
</tr>
<tr>
<td valign="top" width="126"> </td>
<td width="328" valign="top"><b><font face="Tahoma, Verdana, Arial, sans-serif">Questions
or Comments</font></b></td>
</tr>
<tr>
<td valign="top" width="126"> </td>
<td width="328" valign="top">
<textarea name="comments" cols="40" rows="5" wrap="VIRTUAL"></textarea>
</td>
</tr>
<tr>
<td valign="top" width="126" height="42"> </td>
<td width="328" valign="top" height="42">
<table width="100%" border="0">
<tr>
<td align="left" width="50%">
<input type="submit" name="Submit" value="Submit Information">
</td>
<td width="50%" align="right">
<input type="reset" name="reset" value="Reset Form">
</td>
</tr>
</table>
</td>
</tr>
</table>
</form>

rohithmr

there is no reason it shuddnt work if ur using $HTTP_POST_VARS. so it shudd b

<?php 
$message = "Name: $HTTP_POST_VARS['firstn'] $HTTP_POST_VARS['lastn']\n"; 
$message .= "Email Address: $HTTP_POST_VARS['email']\n\n"; 
$message .= "Address:\n"; 
$message .= "$HTTP_POST_VARS['address1']\n"; 
$message .= "$HTTP_POST_VARS['address2']\n"; 
$message .= "$HTTP_POST_VARS['address3']\n"; 
$message .= "$HTTP_POST_VARS['city']\n"; 
$message .= "$HTTP_POST_VARS['state']\n"; 
$message .= "$HTTP_POST_VARS['zip']\n"; 
$message .= "$HTTP_POST_VARS['country']\n\n"; 
$message .= "Telephone Information:\n"; 
$message .= "Country Code: $HTTP_POST_VARS['ccode']\n"; 
$message .= "($HTTP_POST_VARS['acode']) $HTTP_POST_VARS['phone']\n\n"; 
$message .= "Comments:\n"; 
$message .= "$HTTP_POST_VARS['comments']"; 

mail("phunter@hass.usu.edu", "Request for Information from HASS Web Site", $message); 
?>

YOu also might want to check if all these variables are valid b4 attempting to send a mail.

hunterp

Nothing works. It seems like the data is just not getting passed through. Unfortunately, I don't know enough about PHP to know why or where to start investigating. Thanks for the tips.

Patrick

rohithmr

well if u want to debug then u cudd do this:

Comment out everything inside the php file and add this:

<?php
echo '<pre>';
print_r($_POST);
echo '</pre>';
?>

it shud output all teh varibles it gets from the form. Post ur output here.

NOTE that accessing the php file will not show anything. You have to fill out the form and post to this PHP page to get the desired results.

hunterp

Originally posted by rohithmr
well if u want to debug then u cudd do this:

Comment out everything inside the php file and add this:
<?php
echo '<pre>';
print_r($_POST);
echo '</pre>';
?>
it shud output all teh varibles it gets from the form. Post ur output here.

NOTE that accessing the php file will not show anything. You have to fill out the form and post to this PHP page to get the desired results. [/B]

That's a pretty nifty script, I'll have to remember that. Looks like the data is making it to the next page. Not sure what happens to it after that. Here is the output of the script:

Array
(
[firstn] => Patrick
[lastn] => Hunter
[email] => phunter@hass.usu.edu
[address1] => 0700 Old Main Hill
[address2] => Office 338
[address3] => none
[city] => Logan
[state] => UT
[zip] => 84322
[country] => USA
[ccode] => 01
[acode] => 435
[phone] => 797-1195
[comments] => comments
[Submit] => Submit Information
)

Patrick

hunterp

I found my answer. PHP 4.3.0 turns off global variables by default. I turned them back on and everything was good. I will need to go through and re-write my forms in the newer format and then go and turn globals off. Thanks for the help.