Regexp Help

intenz

I'm trying to make a bulletboard code which is very popular today.
I'm succesful with bold, underline, italic, h1 and h2.
I only have a problem with the .

Here's the code...

# Bold
$string = ereg_replace( '\[b\](.*)\[/b\]', '<b>\1</b>', $string );
# Italic
$string = ereg_replace( '\[i\](.*)\[/i\]', '<i>\1</i>', $string );
# Underline
$string = ereg_replace( '\[u\](.*)\[/u\]', '<u>\1</u>', $string );
# Link 1
$string = ereg_replace( '\[url\](.*)\[/url\]', '<a href="\1">\1</a>', $string );
# Header 1
$string = ereg_replace( '\[h1\](.*)\[/h1\]', '<h1>\1</h1>', $string );
# Header 2
$string = ereg_replace( '\[h2\](.*)\[/h2\]', '<h2>\1</h2>', $string );

The outcome of this was just...

<b>gaui</b><br />
<u>gaui</u><br />
<i>gaui</i><br />
<a href="http://www.gaui.is[/url]<br />

Please help me.

ednark

your code works fine on my php4.2.3 XP ....

your regular expression checks out also...

please post the example that is fowling up your script so we can look at it further

intenz

AHH...
I found what's wrong but didn't solve the problem.

Look at this:
http://gaui.is-a-geek.org/foo.php
http://gaui.is-a-geek.org/foo.phps

The reason is because I'm using many [url] [/url] in the string.

I tried this and it worked...

$string = 'Ég sá eina frétt á [url][url]http://www.mbl.is[/url][/url] sem ég var ekki alveg að botna';

Output:

Ég sá eina frétt á <a href="http://www.mbl.is">[url]http://www.mbl.is</a>[/url] sem ég var ekki alveg að botna

Then I tried this and it didn't work...

$string = 'Ég sá eina frétt á [url][url]http://www.mbl.is[/url][/url] sem ég var ekki alveg að botna og líka á [url][url]http://www.batman.is[/url][/url]';

Output:

Ég sá eina frétt á <a href="http://www.mbl.is[/url] sem ég var ekki alveg að botna og líka á [url]http://www.batman.is">http://www.mbl.is[/url] sem ég var ekki alveg að botna og líka á [url]http://www.batman.is</a>

So this tells me my REGULAR EXPRESSION statements don't support many BBcodes in the same string.

How can I fix that?

Here's the function...

function makeBB( $string )
{
	# Bold
	$string = ereg_replace( '\[b\](.*)\[/b\]', '<b>\1</b>', $string );
	# Italic
	$string = ereg_replace( '\[i\](.*)\[/i\]', '<i>\1</i>', $string );
	# Underline
	$string = ereg_replace( '\[u\](.*)\[/u\]', '<u>\1</u>', $string );
	# Link 1
	$string = ereg_replace( '\[url\](.*)\[/url\]', '<a href="\1">\1</a>', $string );
	# Link 2
	#$string = ereg_replace( '\[url=(.*)\](.*)\[/url\]', '<a href="\1">\2</a>', $string );
	# Header 1
	$string = ereg_replace( '\[h1\](.*)\[/h1\]', '<h1>\1</h1>', $string );
	# Header 2
	$string = ereg_replace( '\[h2\](.*)\[/h2\]', '<h2>\1</h2>', $string );

# PHP Table 1
ereg( '\[php\](.*)\[/php\]', $string, $php1 );
$string = ereg_replace( '\[php\](.*)\[/php\]', '<table width="80%" border="0" cellpadding="1" cellspacing="0" bgcolor="#666666"><tr><td><table width="100%" border="0" cellpadding="0" cellspacing="10" bgcolor="#EEEEEE"><tr><td>' . highlight_string( $php1[1], TRUE ) . '</td></tr></table></td></tr></table>', $string );

# PHP Table 2
ereg( '\[php=(.*)\](.*)\[/php\]', $string, $php2 );
$string = ereg_replace( '\[php=(.*)\](.*)\[/php\]', '<table border="0" cellspacing="3" cellpadding="0" bgcolor="#CCCCCC" style="border: #666666 solid; border-width: 1px 1px 0px"><tr><td><b>' . $php2[1] . '</b></td></tr></table><table width="80%" border="0" cellpadding="1" cellspacing="0" bgcolor="#666666"><tr><td><table width="100%" border="0" cellpadding="0" cellspacing="10" bgcolor="#EEEEEE"><tr><td>' . highlight_string( $php2[2], TRUE ) . '</td></tr></table></td></tr></table>', $string );

return $string;
}

intenz

ANYONE! Please help me...

xblue

Hi there,

the PCRE function support ungreedy matching that should solve your problem, you could try:
$string = preg_replace( '#[url](.*?)[/url]#s', "<a href=\"$1\">$1</a>", $string );

or if you'd rather keep with ereg:
$string = ereg_replace( '[url]([^[]*)[/url]', '<a href="\1">\1</a>', $string );
might work, but this will fail to catch nested tags like
http://domain.com
[url][b]http://domain.com[/b][/url]

(this would probably result in invalid links anyway, they way it does here...)

Hope this helps - xblue