arguments passed to page screwed up

[skeppens]

Hi,

I am trying to create a link between 2 pages with some arguments. IThe URL show in the status bar comes alright, but the page itself changes the ? = & to %3F %3D %26

e.g.
going over a link shows teh following link in the status bar:
http://localhost:8075/softwarelib/FirstLoopUp/Company-Products.php?SWCompanyID=42&Company=Adaptec

But clicking brings up this page:

http://localhost:8075/softwarelib/FirstLoopUp/Company-Products.php%3FSWCompanyID%3D42%26Company%3DAdaptec

The URL is constructed via this part of the code:
$id = odbc_result($Companycur, 1);
$company = odbc_result($Companycur, 2);
$row = maketd(makehref("Company-Products.php? SWCompanyID=".$id."&Company=".$company,"",$company)) ;

Can some one help with this?
THANKS

[suntra]

Could you copy your makehref() function ?

[sarah]

Most likely it is an issue with the function, but it also looks like there is some syntax funkiness and an extra space in...

maketd(makehref("Company-Products.php? SWCompanyID=".$id."&Company=".$company,"",$company)) ; 

Also, it might clear some stuff up if you got rid of the concatenation and just did...

maketd(makehref("Company-Products.php?SWCompanyID=$id&Company=$company","$company")) ; 

(I'm assuming the makehref() function has two parts, the url and the company name.)

[skeppens]

i updated the call to
$row = maketd(makehref("Company-Products.php?SWCompanyID=$id&Company=$company,"",$company)) ;

but still the problem remains :
http://localhost:8040/softwarelib/FirstLoopUp/Company-Products.php%3FSWCompanyID%3D42%26Company%3DAdaptec

the function makehref then:
function makehref($contents,$method="", $tag="")
{

/ convert $contents to an HTML HREF
note we wrap $contents with a urlencode
$method defaults to empty (relative reference)
$tag is used only if passed
/

if ($tag) 

{
return '<A HREF="' . $method . urlencode($contents) . '">' . $tag . "</A>";
}
else
{
return '<A HREF="' . $method . urlencode($contents) . '">' . $contents . '</A>';
}
}

All seems fine to me, but still I get these chars.

Any suggestion.

[sarah]

There is still an odd number of quotes in the following. I think there needs to be a closing quote after the first $company.

$row = maketd(makehref("Company-Products.php?SWCompanyID=$id&Company=$company,"",$company)) ;

Also, try removing the urlencode function. I believe the browser will do that behind the scenes automatically.

if ($tag) 
{
return '<A HREF="$method$contents">$tag</A>'; 
} 
else 
{ 
return '<A HREF="$method$contents">$contents</A>'; 
} 

[skeppens]

Jipie,

it worked.
THANKS