Selecting from DB error....

Trid3nt

Here is the error:

Parse error: parse error, expecting T_STRING' orT_VARIABLE' or `T_NUM_STRING' in /path/login.php on line 15

And here is the code:

<HTML>
<HEAD><TITLE>Login</TITLE></HEAD>
<BODY>
<?PHP echo "$error"; ?>
<FORM name=login action="<?=$PHP_SELF?>" method="POST">
Login: <INPUT type=text name="username"><BR>
Password: <INPUT type=password name="password"><BR>
<INPUT type=checkbox name="Remember_Me"> Remember Me<BR>
<INPUT type=submit name=submit value="Login!">
</FORM>
<?PHP
if ($HTTP_POST_VARS['Submit']){
mysql_connect('$host', '$username', '$password');
mysql_select_db('$db');
$query = "SELECT Username, Password FROM DB_Users WHERE Username=\"$HTTP_POST_VARS['username']\"";
$result = mysql_query($query);
$row = mysql_fetch_array($result);
if($row['Username'] == $HTTP_POST_VARS['username'] && $row['Password'] == $HTTP_POST_VARS['password']){
header("Location: http://www.domain.com");
}
else{
$error = "Your Username and Password were incorrect. Please try again."
}
}
?>
</BODY>
</HTML>

More specifically Line 15:

$query = "SELECT Username, Password FROM DB_Users WHERE Username=\"$HTTP_POST_VARS['username']\"";

Any idea what it wants from me?

cgraz

I've always had trouble using $_POST (or in older version $HTTP_POST_VARS in selects). Try this

$username = $HTTP_POST_VARS['username'];
$query = "SELECT Username, Password FROM DB_Users WHERE Username='$username'";

Cgraz

Trid3nt

Now this is line 15 and I'm getting the same error:

$username = $HTTP_POST_VARS['username'];

cgraz

PHP gives the error where it first discovers, so it may be a few lines up. Try changing

mysql_connect('$host', '$username', '$password'); 
mysql_select_db('$db');

mysql_connect($host, $username, $password); 
mysql_select_db($db);

Cgraz

Trid3nt

Those variables aren't in the original code. I just put them in place of the "exact" stuff that I put in before. So right now, I have the precise names for username and database in there... can't be that.

terrabull

Try this?

$query = "SELECT Username, Password FROM DB_Users WHERE Username='".$HTTP_POST_VARS['username']."'";

cgraz

I just tested the code, and the $username = $HTTP_POST_VARS['username']; solved the problem. Copy and paste this code (put in your mysql info), and try it.

<HTML> 
<HEAD><TITLE>Login</TITLE></HEAD> 
<BODY> 

<?PHP echo "$error"; ?> 

<FORM name=login action="<?=$PHP_SELF?>" method="POST"> 
Login: <INPUT type=text name="username"><BR> 
Password: <INPUT type=password name="password"><BR> 
<INPUT type=checkbox name="Remember_Me"> Remember Me<BR> 
<INPUT type=submit name=submit value="Login!"> 
</FORM> 
<?PHP 

if ($HTTP_POST_VARS['Submit']) { 
mysql_connect($host, $username, $password); 
mysql_select_db($db); 
$username = $HTTP_POST_VARS['username'];

$query = "SELECT Username, Password FROM DB_Users WHERE Username='$username'"; 
$result = mysql_query($query); 
$row = mysql_fetch_array($result); 
if($row['Username'] == $HTTP_POST_VARS['username'] && $row['Password'] == $HTTP_POST_VARS['password']){ 
header("Location: [url]http://www.domain.com[/url]"); 
} 
else{ 

$error = "Your Username and Password were incorrect. Please try again.";

} 
} 
?> 
</BODY> 
</HTML>

You had also forgotten a semi-colon on this line:

$error = "Your Username and Password were incorrect. Please try again."

Cgraz

Trid3nt

Now I'm getting a parse error on this code. Ugh, could this be server based? Cause I don't see any problem at all. The parse error happens on line 13 "mysql_select_db('w0rd_test');"

Oh and before, with the exact code that you posted, I was getting a parse error at the first PHP line where we told it to echo the error. What is with that?? This is really strange.

Thanks.

UPDATE:
Ok, I just put the echo for the error back in (this time without quotes around $error) and it doesn't give me the parse error there... instead, I'm getting one here now:

if ($HTTP_POST_VARS['Submit']) {

Why are these errors jumping around like this?

cgraz

Hmm.

One more thing I just noticed

header("Location: <a href="http://www.domain.com" target="_blank">http://www.domain.com</a>");

should be

header("Location: http://www.domain.com");

if you want that to be a link, that opens in a new window, then you shouldn't be using header, but just

<a href="http://www.domain.com" target="_blank">http://www.domain.com</a>

If mysql_select_db has an error, try checking the lins above it. are you using single quotes around all the mysql info? commas?

Cgraz

Trid3nt

Yep, I'm using single quotes and commas in the code. I changed the header as you asked. Still no change in the error.