Terrorble time with php & tables!

evo4ever

Hi. A few moments ago. I decided yet again to change my site's functionality! But this time, i dont want a members.php page. I want it all in the display.php page! In order to do that, ive got to render certain features invisable to "guest" eyes! Esspecially navigation tables. When a user logs in, a php script check to see if $statusCheck equals to either "Admin" or "staff", its its true, the echo statement will execute. In the echo statement is the Members navigation table. It does work. But the page looks all garbled and all the tables are not in the correct places! To see the display.php click the download link. Pls someone help me with this!

To see the problems:
www.clanph.net/display.php This is without the main nav table.
www.clanph.net/display.php?table=show This is with the main nav table AND the errors!

Help much appreciated! thx.

sarahk

bit confused. Partly because I use IE 🙂

you don't always have to echo, you can break out of php within your if statement - know what I mean?

but... the restricted comment should be a finite set of tags, ie start at table then end with table, start with tr, end with tr. that way your layout will be good. If there is a balance problem then have an else with similar tags to balance it out.

What you are trying to do makes sense.

procoder

Warning: Microsoft Internet Explorer 6.0 detected...
Access denied!
Please download Netscape Navigator 7.0!

Objection? E-Mail me.

The reason you have been denied access to the clanph.net site is becuase of IE6's major incompatibility. The server is currently getting optimized for Internet Explorer. But in the meantime we urge your to download Netscape 7.0 to continue to view the site!

...

evo4ever

HEH. Ill remove the IE script. sry.

You can now view the site using IE.

sarahk

Without going through your code carefully I can't see the problem but it's html not php.

consider the page to have zones and each of those zones will be controlled by a table or a div.

You want to get to each zone and ask the question about whether the user can see it. Yes and the html gets placed, no and the appropriate padding gets put in.

I think that the design has got away from you (and your graphics are awesome) and you need to get back to "building blocks" and check it all carefully.

evo4ever

:mad: I really HATE HTML! It screws everything up! I know this is a small problem, but its difficult to correct!

Do you realise that my display.php is 684 lines long!!! And tables get me confused, essecially when theres about 50 in the page!

sarahk

If anyone from my old job reads this I'm going to get hate emails for days... but my catch phrase is modularisation! I'm sorry, had to say it.

that means break it down, keep it simple. And if involves a rewrite then do it, because you'll have to maintain it one day and think what that'll be like. If it makes your head spin now when you're familiar with it, think about when you come in cold.

The java guys say that if code is more than one screens worth then you need to break it down to a separate method (ie function). Bit extreme but they have a point.

There must be code which you are repeating. Should you have a function to do the job?

you might want to put the building blocks into variables to be called later. You might want to use templates. There's a reason why they are so popular.

sorry, I can't give you better news that this but...

evo4ever

I've had this problem before. The EXACT same problem, but I successfully fixed it! But I dont know what is causing this one! I checked to see if this problem inherited the same ones as before, but it doesnt! By my judgement, the table looks fine. I bet its the browser! it cant cope with so many tables. < what ive just said there is probably nonsence!

sarahk

give each of your tables a 1px border with lovely colours like lime and fuschia and see where they go. often when you've been working on it you end up with tables that do nothing and they need to be weeded out anyway.

diego25

Sometimes the problem is also because of an unclosed <td>, <tr>, or <table> tag. To find these errors, run the PHP script from your browser, save the HTML output into an XML file, and then run that XML file through an XML checker. IE (and I believe the newest version of Mozilla too, but I haven't tested) can load XML files and tell you of unclosed tags.

Diego

evo4ever

There wont be any unclosed tags. I deisgned the template in dreamweaver mx. I dont think DW will create unclosed tags. Ok. Ive scrapped that method. I going to use an include. If $statusCheck == "admin"
inc include/template/admin.php

..same for staff..

else
inc include/template/default.php

Im now getting an error from the browser saying:

"Redirection limit for this URL exceeded. Unable to load requested page"

Im about to give up and bin my site. I never thought php would cause this much trouble!

diego25

Are you using header('Location: ...') in your script? Maybe it's creating a redirection 'infinite loop' and your browser won't allow you to bully it that much 🙂

Diego

evo4ever

lol. yeah, ive just fixed it! For Infinite loops are still the worst tho :p