Batling to get code to UpDATE record.

netrepsa

php code

<html>
<head>
<title>Update Personal Data</title>
</head>
<body bgcolor="white" text="black" link="blue" vlink="purple" alink="red">

<div align="center">
<table border="3" width="730" >
<tr>
<td width="730"><p align="center">
<img src="../logo.gif" border="0"></p>
<p align="center"><font face="Arial" size="7"><b>UPDATE PERSONAL DATA </b></font></td>
</tr>
<tr>
<td width="100%" bgcolor="white">

<?php

include "/home/misite/public_html/flatland/cgi-bin/whoami.php";

include "/home/misite/public_html/cgi-bin/set_var.php";

<input type=hidden name="id" value="<?php echo $id ?>">
<td>
Your Name:</td><td><input SIZE="60" type="Text" name="yourname" value="<?php echo $yourname ?>"><br>
</td></tr><tr><td>
Your Address:</td><td><input size="60" type="Text" name="youraddress" value="<?php echo $youraddress ?>"><br>
</td></tr><tr><td>
Your City:</td><td><input size="60" type="Text" name="yourcity" value="<?php echo $yourcity ?>"><br>
</td></tr><tr><td>
Your Postal Code:</td><td><input size="60" type="Text" name="yourpcode" value="<?php echo $yourpcode ?>"><br>
</td></tr><tr><td>
Your Tel Code & Number:</td><td><input size="60" type="Text" name="yourtel" value="<?php echo $yourtel ?>"><br>
</td></tr><tr><td>
Your E-Mail Address:</td><td><input size="60" type="Text" name="youremail" value="<?php echo $youremail ?>"><br>
</td></tr><tr><td>
Your Contact Persons Name:</td><td><input size="60" type="Text" name="yourcontact" value="<?php echo $yourcontact ?>"><br>
</td></tr><tr><td>
Your Bank Name:</td><td><input size="60" type="Text" name="yourbank" value="<?php echo $yourbank ?>"><br>
</td></tr><tr><td>
Your Branch Name:</td><td><input size="60" type="Text" name="yourbranch" value="<?php echo $yourbranch ?>"><br>
</td></tr><tr><td>
Your Branch Code:</td><td><input size="60" type="Text" name="yourbranchcode" value="<?php echo $yourbranchcode ?>"><br>
</td></tr><tr><td>
Your Account Number:</td><td><input size="60" type="Text" name="youraccount" value="<?php echo $youraccount ?>"><br>
</td></tr><tr><td>
Your Business Name:</td><td><input size="60" type="Text" name="farmname" value="<?php echo $farmname ?>"><br>
</td></tr><tr><td>
Your Hunter Type:</td><td><input size="60" type="Text" name="hunttype" value="<?php echo $hunttype ?>"><br>
</td></tr><tr><td>
Your Web Sub Title:</td><td><input size="60" type="Text" name="subtitle" value="<?php echo $subtitle ?>"><br>
</td></tr><tr><td>
Your Web Theme:</td><td><input size="2" type="Text" name="theme" value="<?php echo $theme ?>"><br>
</td></tr><tr><td>
<input type="Submit" name="personel" value="Enter information">
</td>
</tr>
</table>
</form>

<?php

if ($personel) {

// here if no ID then adding else we're editing

$sql = "UPDATE admin SET yourname='$yourname', youraddress='$youraddress', yourcity='$yourcity', yourpcode='$yourpcode', yourtel='$yourtel', youremail='$youremail', yourcontact='$yourcontact', yourbank='$yourbank', yourbranch='$ourbranch', yourbranchcode='$yourbranchcode', youraccount='$youraccount', farmname='$farmname', hunttype='$hunttype', subtitle='$subtitle', theme='$theme' WHERE ID='$id'";

// run SQL against the DB

$result = mysql_query($sql);

echo "Record updated/edited!<p>";

}
?>

</td>
</tr>
</table>
</div>
</body>
</html>

It show that record updated but does not update record!

What am I doing wrong?

sarah

The reason that it is saying that it updated regardless of whether it actually worked, is because there is no error checking. It prints that it worked because it is not told NOT to print it if it didn't...does that make sense?

There may be a number of reasons that the db isn't updating...there could be a ' or " in the submitted data that is cracking things up...it might not be connecting...there might be a typo in a table name...

Try having it print the mysql error if it doesn't work:

if(!($result = mysql_db_query($DB,$sql))) die(mysql_error());

netrepsa

I do not understand.

With the error message it gives me "NO DATABASE SELECTED"

where did it find the variables that it display in the form?

ahundiak

As sarah has suggested following each query with a test is a good thing. I think you will find the that the problem is that the id field is an integer and thus $id (in the where clause) should not be surrounded by quotes.

For updates, you should also confirm that the expected number of records were actually updated

if (mysql_affected_rows() != 1) echo "An update problem";

sarah

The "NO DATABASE SELECTED" error means that there is something funky with the way that you are connecting to and/or querying the database. I think, more specifically, it means that you are connecting fine, but it doesn't know which database to connect to?