what is wrong with this query?

[seanpaulcail]

function display_books()
{
  //display all books in the array passed in
  $conn = db_connect();
   $query = "select * from books where catid='$catid'";
   $result = @mysql_query($query);
   print_r($row); //just to check array
   if (!$result)
     return false;
   $num_books = @mysql_num_rows($result);
   if ($num_books ==0)
     echo "no books are in this category";


//create table
echo "<table width = \"100%\" border = 0>";

//create a table row for each book    
while ($row = mysql_fetch_array($result))
{
  $url = "show_book.php?isbn=".($row["isbn"]);
  echo "<tr><td>";
  if (@file_exists("images/".$row["isbn"].".jpg"))
  {
    $title = "<img src=\"images/".($row["isbn"]).".jpg\" border=0>";
    do_html_url($url, $title);
  }
  else
  {
    echo "&nbsp;";
  }
  echo "</td><td>";
  $title =  $row["title"]." by ".$row["author"];
  do_html_url($url, $title);
  echo "</td></tr>";
}
echo "</table>";
echo "<hr>";
}

[code=php]

I keep getting "no books are in this categorie when the catid being passed is one and I have several books whose catid is 1 in the database.

Am I doing something wrong with the query?
because I'm not getting the expected results.

Thanks

[planetsim]

Its not your query

its this

$num_books = @mysql_num_rows($result);
if ($num_books ==0)
echo "no books are in this category";

try

this

$num_books = @mysql_num_rows($result);
if($num_books < 1)
{
echo "no books are in this category";
}
else
{
//show books
}

And use this on mysql statements or die(mysql_error()) should help get any errors

Also

Where is this coming from

print_r($row); //just to check array

The $row

[seanpaulcail]

then I hardwired catid to "1"

function display_books()
{
//display all books in the array passed in

$query = "select * from books where catid='1'";
$result = mysql_query($query);

if (!$result)
return false;
$num_books = mysql_num_rows($result);
if($num_books < 1) {
echo "no books are in this category";
}
else
//do table with books

this works so the catid must not be getting passed.

BUt when I click on a link it shows in the browser filed the following

http://www.caillouette.com/CHAPTER26a/show_cat.php?catid=1

So the catid is being passed just not received.

any idea where the problem is?

Thanks