Undefined index

Newbie567

When i am sending variables from a form i am getting these three errors:

Undefined index email on line 33
Undefined index message on line 33
Undefined index name on line 33

I would appriciate if someone could help me out.
Here is my code:


<!doctype html public "-//W3C//DTD HTML 4.0 //EN">
<html>
<head>
       <title>Title here!</title>
</head>
<body>

<FORM ACTION = "<? echo $_SERVER['PHP_SELF'] ?>" METHOD = "POST" >

<input type = "text" name = "name" >
<br>
<input type = "text" name = "email" >
<br>
<input type = "text" name = "message" >
<br>

<input type = "submit" namevalue = "send">
</FORM>

<?

if ($_POST){


mysql_connect("localhost", "user", "password") or
        die("could not connect");

mysql_select_db("db");



$query = "insert into table(name, email, message text)
values ('$_POST'name']', '$_POST['email']', '$_POST['message']')";

mysql_query($query);

mysql_close();
}


?>
</body>
</html>

Thanx,,, a newbie

pyfsapple

Are you sure you have a field named "message text"?

$query = "insert into table(name, email, message text)
values ('$POST'name']', '$POST['email']', '$_POST['message']')";

The following

$query = "insert into table values ('$name', '$email', '$message')";

should also work fine.

Have a nice day~

Newbie567

I cant do that when i have register globals set to off.

Norman_Graham

... you just need to alter the sequence of your existing code

$name=$_POST['name'];
$email=$_POST['email'];
$message=$_POST['message'];

$query = "insert into table (name, email, message)
values ('$name', '$email', '$message')";

So you extract the variables using $_POST before you do the query.

I think that should work - sorry I can't try it on this computer.

Best o luck

Norman

ahundiak

Missing a bracket in
values ('$_POST'name']',

Also, "text" following message should not be in here
$query = "insert into table(name, email, message text)

Newbie567

Thanks alot, it is working now.

sanu

whats different in just writing
ok say this is my form
<form action="msg_in.php">
<input type="text" name="message">
<input type="submit" name="Submit">

</form>

and this is my msg_in.php
if(isset($Submit){

insert into $table(message)values('$message');
}

instead of writing

$message=$_POST['message']

why use $_POST or $HTTP_POST_VARS 😕

ahundiak

sanu,
Starting with php4.1 a global setting called register_globals is set to off by default. This means that for many sites, just using $message won't work.

In addition, by using $_POST you make it very clear as to where the data is coming from. Good documentation.

There are also some security reasons but I think they are a bit thin.

sanu

thanks ahundiak
now i got it ...can you explain security reason to use $_POST
thanks anyway