Switch Statement

anthill

Hi,

I have written two pages, but rather than keep having news.php, news2.php, new3.php for each page i've decided to use the switch statement.

My code looks similar to:

<?
switch($page)
{
case 1:
echo "ignore case one for now";
break;

    case 2:

?>
<table>
<tr>
<td>News page 2</td>
</tr>
</table>

<?
;
break;
default:
?>

<?
]
?>

</body>
</html>

It works fine, only IE comes up witha syntax error in the status bar (similar to what you get with javascript errors, i.e. error on page) when clicking between page 1 and 2. Only if the page is refreshed no syntax error is displayed. So i'm confused?

How can i get rid of the syntax error in IE?

Thanks

Ant

kamy99

It seems to me you've made some typos:

case 2:
?>
<table>
<tr>
<td>News page 2</td>
</tr>
</table>

<?
;
break;
default:

should read:

case 2:
?>
<table>
<tr>
<td>News page 2</td>
</tr>
</table>

<?
break;
default;

and I didn't see the need for this line:

<?
]
?>

Hope this helps

anthill

still does it, let me just say what i did again:

<?
switch($page) <--start switch
{
case 1:
echo "ignore case one for now";
break;

case 2: <--start case 2
?>
<table>

<tr>

<td>News page 2</td>
</tr>
</table>

<?
break; <--end case 2
default: <--start default
?>

<?
break; <--end default
} <-- end switch
?>

</body>
</html> <--end html

kamy99

OK, I copied your code into my server (deleted the <-- sections)
And it works!

it displays
News page 1

Let me know.

anthill

Ok, thanks. I guess thats fine then. I knew it worked I just didn't understand the "error on page" in the status bar..darn Internet Explorer.

Ant

If you wanna see what i mean goto:

http://www.metasoma.com/sounds/domestic.php

and flick back and forth from page one to two, then look in the status bar 🙁

kamy99

OK, I checked your pages and see what you mean.

That's a Javascript error.
I didn't go through the source code, but did notice that you have some onClick events.
Check all your JS code.

HTH

sdizier

Here is your problem

"window.open("../donate.htm","wind_ref","height=400,width=400,scrollbars");">Donations</a>

you have used quotes inside quotes Thats a redflag in javascript

so instead use <a href="#" onClick="window.open('../donate.htm','wind_ref','height=400,width=400,scrollbars');">

notice i'm using single quotes instead of double quotes with in the javascript. makesure you change that in all your onClicks

Cheers
Slan

anthill

🙁 ok its still doing it, i'm starting to believe it isn't a javascript problem. Every page has the same javascript code and its only the one i used the switch statement that gives the error. I've changed the " to ' but still the same. Probably 'm thinking I should just go back to domestic.php and domestic2.php 🙁

On page 1 the error is on line 97
On page 2 the error is on line 85

82 </tr>
83 </table>
84
85 </div>
86
87 </span>
88
89 </td>
90 </tr>
91 </table>
92
93<?
94break;
95default:
96?>
96
97

98 <table width="750" border="1" cellspacing="10" 99cellpadding="5">
100

I bet this answer is sooo simple!! Anybody help?

thanks

Ant

anthill

82 </tr>
83 </table>
84
85 </div>
86
87 </span>
88
89 </td>
90 </tr>
91 </table>
92
93<?
94break;
95default:
96?>
97
98
99 <table width="750" border="1" cellspacing="10" 100cellpadding="5">
101

xblue

This definitely is a javascript error (a php error would be different). You corrected the mistake sdizier pointed out, and right the next line there is the same mistake again:

onClick="window.open("../t&c.htm","wind_ref","height=200,width=400,scrollbars");"

If you see errors like this, search for the line in the html page, not in your php code, and take a look at any javascript that is close to this line (it may be off by a few lines).

anthill

Thanks, Its sorted now, just strange that it only did it on the page with the switch statement. Javascript has never been my strongest point.

Thanks for all your help xblue, sdizier and kamy99!

Ant