what's wrong with this code?

itworks

i have a php page with a voting form but before the user can vote i want to create a file with his ip address or see if it exists, all of this is for preventing that the user votes several time, but i can't put the script to work. i've tried cookies but i can't figure them out.

<html>
<head>
<title> omdb - oscar movies data base </title> </head>
<body bgcolor="#FFFFFF" text="#000000">
<div align="center">
  <table width="825" border="0" cellpadding="0" cellspacing="0">
    <!--DWLayoutTable-->
    <tr valign="middle"> 
      <td width="825" height="50" bgcolor="#CCCCCC"> <div align="right"><font face="Verdana, Arial, Helvetica, sans-serif" size="5"><b>Top 
          Winner Movies Voting List<font color="#CCCCCC">.</font></b></font></div></td>
    </tr>
    <tr> 
      <td height="400" valign="top"> <div align="left"> 
          <p><font face="Verdana, Arial, Helvetica, sans-serif">Select your <strong>10</strong> 
            favorite movies from the list.</font></p>
          <p>
<?php
$connection=mysql_connect("localhost","","");
if (!$connection) {
print ("problems connecting to Mysql server");
}
$sql="select * from movies order by votes desc";
$result = mysql_db_query ("omdb", $sql);
if ($result) {

$ficdest=explode(".",basename($PHP_SELF)); 
$ficdest=$ficdest[0].".dat"; 

if(file_exists($ficdest)) { 
     $user=fopen($ficdest, "r"); 
     $old_votes=file($ficdest); 
     $votes=explode("|", $old_votes); 
     fclose($user); 
     } 
     $ip_hit=$REMOTE_ADDR; 
     $user=fopen($ficdest, "w"); 
     fputs($user, "$ip_hit"); 
     fclose($user); 
} 
else { 
     $new_user=fopen($ficdest, "w"); 
     fputs($new_user, "$REMOTE_ADDR"); 
     fclose($new_user); 
} 

if (!empty($envoi)) { 
     $vote=fopen($ficdest, "r"); 
     $old_votes=file($ficdest); 
     $votes=explode("|", $old_votes); 
     fclose($vote); 
     if ($votes != $REMOTE_ADDR) { 
        $vote=fopen($ficdest, "w"); 
     	$new_votes=fputs($vote, "$ip_vote"); 
     	fclose($vote); 
     } 
else { echo "<font face=Verdana size=2 color=red>You have already voted</font>"; } 
     $ip_vote=$REMOTE_ADDR; 
     $vote=fopen($ficdest, "w"); 
     $new_votes=fputs($vote, "$ip_vote"); 
     fclose($vote); 
} 
print ('<form method="post" action="vote.php">');
print ("<table width=\"75%\" align=center border=1 bordercolor=#CCCCCC>");
print ("<tr><td width=\"10%\" bgcolor=\"CCCCCC\"><font face=\"Verdana, Arial, Helvetica, sans-serif\">SELECT</font></td><td width=\"50%\" bgcolor=\"CCCCCC\"><font face=\"Verdana, Arial, Helvetica, sans-serif\">TITLE</font></td><td width=\"10%\" bgcolor=\"CCCCCC\"><font face=\"Verdana, Arial, Helvetica, sans-serif\">VOTES</font></td></tr>");
while ($regist=mysql_fetch_array($result)) {
$tit=$regist["title"];
$vot=$regist["votes"];
$id=$regist["id"];
print ("<tr><td><input type='checkbox' name='assign_name[]' value='" . $regist["id"] . "'></td><td><font face=\"Verdana, Arial, Helvetica, sans-serif\">$tit<font></td><td><font face=\"Verdana, Arial, Helvetica, sans-serif\">$vot</font></td></tr>");
}
echo "</table>";
echo '<p align="center"><input type="submit" value="Vote" />';
echo '</form>';
}else{
print ("there are no entries");
}
mysql_free_result ($result);
?>
          </p>
        </div></td>
    </tr>
  </table>
</div>
</body>
</html>

i hope anyone can help me with this and i thank you in advance.

jesus_hairdo

Here's a script that i have recently used as a survey.
It will set a cookie on the user's PC which has an expiry date set to (i think) a couple of months.
It also records the User's IP and wont let a user vote from the same IP as has been used before within an hour of the last vote.

<?
/* lets see if the user has voted, we'll use 2 methods, 1st a cookie check, then an IP check using MySQL */

/* cookie check */
if (isset($HTTP_COOKIE_VARS[dresscode]))
{
	//user has already voted once
	?>
	<html>
	<head><title>Sorry - you've already voted</title>
	</head>
	<body onload="alert('Sorry you\'ve already voted'); self.close()">
	</body>
	</html>
	<?
	exit;
}
/* end of cookie check */
/* IP check using MySQL*/
/* connect to database */
include ('/var/www/includes/dbinfo.php');//this just provides login information for the mysql server.
$dbname = "surveys";
$conn = mysql_connect($dbhost, $dbuser, $dbpass);
mysql_select_db($dbname);
/* connection established */
$ip_check_sql = "SELECT id, time FROM dress_code WHERE ip ='" .getenv("REMOTE_ADDR"). "' ORDER BY time DESC";
$ip_check_result = mysql_query($ip_check_sql) or die( "Error in SQL<BR><STRONG>$vote_sql</STRONG><BR>". mysql_error());
while ($ip_check_row = mysql_fetch_array($ip_check_result))
{
	/* see if the time on the db, is within 1 hour of when the last vote was cast from this IP */
	if ($ip_check_row[time] >= time() - 300)
	{
		/* someone voted from this IP address less than an hour ago */
		?>
		<html>
		<head>
		<title>Sorry - you've already voted
		</title></head>
		<body onload="alert('Sorry - someone from this machine has already voted - come back in 5 minutes'); self.close()">
		</body>
		</html>
		<?
		exit;
	}
}
/* end of user has voted */

/* user is submitting a response */
if (isset($submit))
{
	/* user is submitting a response */

/* create the insert query, then submit to the db, and then setup the cookie */
$cookie_expiration_date = time() + 1814400 ;
$cookie_value = time(); 
$vote_sql = "INSERT INTO dress_code SET answer = '$answer', ip = '". getenv("REMOTE_ADDR") ."', time = '".time()."'";
$vote_result = mysql_query($vote_sql) or die( "Error in SQL<BR><STRONG>$vote_sql</STRONG><BR>". mysql_error());
setcookie("dresscode", $cookie_value, $cookie_expiration_date);
?>
<html>
<head><title>Vote Counted - Thank You</title>
</head>
<body onload="alert('Thank you for voting!'); self.close()">
</body>
</html>
<?
exit;
}
/* end of user submitting a response */
?>
<html>
<head><title>Dress Code Survey</title>
<style type="text/css">
<!--
.title {
	font-family: Verdana, Arial, Helvetica, sans-serif;
	font-size: 16px;
	color: #000000;
	padding: 5px;
	font-weight: bold;
}
.subtitle {
	font-family: Verdana, Arial, Helvetica, sans-serif;
	font-size: 14px;
	color: #000000;
	padding: 5px;
}
.caption {
	font-family: Verdana, Arial, Helvetica, sans-serif;
	font-size: 12px;
	color: #000000;
}
.button {
	font-family: Verdana, Arial, Helvetica, sans-serif;
	font-size: 12px;
	color: #000000;
	background-color: #CCCCCC;
	border: 1px solid #000000;
}
-->
</style>
</head>
<body onload="self.focus()">
<form name="form1" method="post" action="">

  <table align="center">
    <tr> 
      <td colspan="2" class="title"><center>
          Dress Code Survey</center></td>
    </tr>
    <tr> 
      <td colspan="2" class="subtitle"><center>
          Please select your answer and click on Vote!</center></td>
    </tr>
    <tr> 
      <td align="center"> <input type="radio" name="answer" value="a"></td>
      <td class="caption">Smart All of the Time</td>
    </tr>
    <tr> 
      <td align="center"> <input type="radio" name="answer" value="b"></td>
      <td class="caption">One dress down day a month</td>
    </tr>
    <tr> 
      <td align="center"> <input type="radio" name="answer" value="c"></td>
      <td class="caption"> Dress as you like (with some exceptions)</td>
    </tr>
    <tr> 
      <td>&nbsp;</td>
      <td>&nbsp;</td>
    </tr>
    <tr align="center"> 
      <td colspan="2"> 
        <input name="submit" type="submit" class="button" value="Vote!">
      </td>
    </tr>
  </table>
</form>
</body>
</html>

You should be able to modify this to suite your needs.

Jamie

itworks

thanks a lot, but in the meen time i've solved it, i opted for cookies which i had already tried before, at the time it didn't work but now it does.

anyway i apretiate your help very much.

best regards. 🙂