mysql_fetch_array help

Madwacker

Hi-
I have this working with just one value; either the screen name or the password, but not both. Can anyone help?

// create SQL statement
$sql = "SELECT name, password FROM users
		WHERE name='$screen_name' AND password='$password';";

// execute SQL query and get result
$sql_result = mysql_query($sql,$connection) or die("Couldn't execute query");

$data = mysql_fetch_array($sql_result);
// this if statement isn't working with the 2 values, but works just fine with one
if (($data['name'] != $screen_name) && ($data['password'] != $password)){

// if the name and password didn't work, set login = 0
$login = 0;

//set the cookie and return to login page

With that if statement as is, it sets a cookie and just returns me to my homepage (where i tell it to go if i'm logged in), but I'm not logged in because a value on my homepage doens't change like its supposed to.

Thanks =)

stolzyboy

instead of

<?
if (($data['name'] != $screen_name) && ($data['password'] != $password)){
?>

use

<?
if (($data['name'] != $screen_name) || ($data['password'] != $password)){
?>

the first one requires that both are not, the second only requires
one or the other

Madwacker

Thanks, that worked... but I need it to make sure BOTH are correct, not just one or the other. I think you misread my first statement. I can get name OR password to work in that if statement, but I cannot get both of them to work.

Would something like this also work:

$sql = "SELECT count(*) AS counted FROM users
     WHERE name='$screen_name' AND password='$password';";

//query and fetch statements...yadda yadda...

if ($data['counted] > 0 ) {
   // login is good

} else {
  // login is bad
}

stolzyboy

i'd say probably only because i haven't tested it, but your first way is safer

Madwacker

Sorry I was editing while you were replying.

stolzyboy

so you want to make sure that $username and $password are both correct, right, well the way you did it is correct with the || as i showed you, this way it checks to see if either the $username is correct AND the $password is correct, if EITHER of them is incorrect you say GO AWAY, of they are both correct you say COME IN. The OR (||) makes sure both are correct, you just need to think outside of what you are doing to get the logic straight in your head, kinda confusing when you want both to be correct you would think i need this AND this correct, but you need to check with OR

volleytotal_ch

Your query will return a row if an entry was found with the username and password. So use

if(mysql_num_rows($res))
   // User with this login infos found
else
  // No user found

instead of all the other stuff 😉

hth

stolzyboy

yes that is a valid point, however i have seen this fooled, and always safer to get stuff straight in your mind before writing it to logic

Madwacker

Thanks stolzyboy - the more I thought about that, the more I see the way of it =) Early morning friday..heheh =) Thanks to all of you.