alternating colors

sirTemplar

i am trying to work out a script to alternate colors of the output, this is the code:

$color1 = "#c0c0c0";
$color2 = "#9690cc";

do {

echo "<table border=0 cellpadding=0 cellspacing= style=border-collapse: collapse bordercolor=#111111 width=100% id=AutoNumber1>

<?
for($i = 0; $i < 10; $i++) {
$color_var = "color". ($i % 2 + 1);
?><tr bgcolor="<? echo ${$color_var} ?>">
<td width=50% bgcolor=#E1FFFF align=left width=80% valign=top><li>{$row['NOMRL']} {$row['CNOMEN']}</td>
<td width=50% bgcolor=#E1FFFF align=left width=80% valign=center> from {$row['PROVEN']}:
{$row['PROFTDAT']}</tr><?
} </td></li>?></table>";<?

} while($row = mysql_fetch_array($result));

} else {print "There are no temporary professions!";}

?>

however it outputs this:

Parse error: parse error, expecting ','' or';'' in /conecttion/et.etc/ on line 104

line 104 is:

$color_var = "color". ($i % 2 + 1);

any idea? help!

keith73

Heres an easy way.

put your color codes into an array.

$BGcolors = ('#c0c0c0','9690cc');
$colors = count($BGcolors);//# of colors in array.
$row = 0;
//enter loop here
{

print "<tr bgcolor=\"" . $BGcolors[$row%$colors] . "\">";
$row++;// if a for loop, use row as the iterating variable, then this line is not needed.
}//end loop

keith

stolzyboy

arent you missing the $ in front of "color" . $i......

or am i not looking at it thoroughly enough

keith73

arent you missing the $ in front of "color" . $i......
or am i not looking at it thoroughly enough

He's creating the var name on the fly, then trying to evaluate the name.

I'm not sure what is causing that error, but I know the array method works well.

Keith

sirTemplar

this is what i did keith:

do {

$BGcolors = ('#c0c0c0','9690cc');
$colors = count($BGcolors);//# of colors in array.
$row = 0;

echo "<table border=0 cellpadding=0 cellspacing= style=border-collapse: collapse bordercolor=#111111 width=100% id=AutoNumber1>
<tr>
<td width=50% bgcolor=#E1FFFF align=left width=80% valign=top><li>{$row['NOMRL']} {$row['CNOMEN']}</td>
<td width=50% bgcolor=#E1FFFF align=left width=80% valign=center> from {$row['PROVEN']}:
{$row['PROFTDAT']}</tr></td></li></table>";

} while($row = mysql_fetch_array($result));

} else {print "There are no temporary professions!";}

{

print "<tr bgcolor=\"" . $BGcolors[$row%$colors] . "\">";
$row++;// if a for loop, use row as the iterating variable, then this line is not needed.
}//end loop

and now it's giving me this error:

Parse error: parse error in /var/www/html/blah/blah.php on line 96

line 96 is:

$BGcolors = ('#c0c0c0','9690cc');

sorry for the trouble. thanx for the patience!

sarah

Is it the # that is funking stuff up?

keith73

Originally posted by sarah
Is it the # that is funking stuff up?

nope, it's my forgetfulness.

$BGcolors = ('#c0c0c0','9690cc'); 
// SHOULD BE
$BGcolors = array("#c0c0c0","#9690cc");

the # may have been a problem because the items were in single quotes.

keith

sirTemplar

i tried to remove the # sign but the same problem, same line! 😕 🙁

sarah

Often it is a line before the error message says...what's before the do{ ?

keith73

I modified your code. See below. comments are made where needed.

<?php


// place these outside the loop
$BGcolors = array("#c0c0c0","#9690cc"); // use double quotes and specifiy as array
$colors = count($BGcolors);//# of colors in array.
$rownum = 0; //formerly $row

do {
	//use proper indentation
	echo "<table border=0 cellpadding=0 cellspacing= style=border-collapse: collapse bordercolor=#111111 width=100% id=AutoNumber1>
	<tr>
	<td width=50% bgcolor=#E1FFFF align=left width=80% valign=top><font face=Verdana size=2 color=#800000><b><li>{$row['NOMRL']} {$row['CNOMEN']}</b></td>
	<td width=50% bgcolor=#E1FFFF align=left width=80% valign=center><font face=Verdana size=2 color=#000000> from {$row['PROVEN']}:</br>
	<font face=Verdana size=2 color=#FF0000>{$row['PROFTDAT']}</tr></td></font></li></table>";

} while($row = mysql_fetch_array($result));
} else { print "<font face=Verdana size=2 color=#FF0000><b>There are no temporary professions!</font></b>"; }
//{ <- this shouldn't be here remove it

//change the iterating variable $row to $rownum since $row is your assoc array in $row = mysql_fetch_array

print "<tr bgcolor=\"" . $BGcolors[$rownum%$colors] . "\">";
$rownum++;
//}//end loop <- this shouldn't be here remove it

?>

sarah

Or just use this type of deal where you want to print the alternating rows?

<table>
<?
$bgColor="c0c0c0";
while(whatever makes you print the row){
	print("<tr bgcolor=\"$bgColor\"><td>Row Content</td><tr>");
	if($bgColor=="c0c0c0"){
		$bgColor="9690cc";
	}else{
		$bgColor="c0c0c0";
	}
}
?>
</table>

keith73

if($bgColor=="c0c0c0"){

    $bgColor="9690cc";

}else{

    $bgColor="c0c0c0";

}

Sara, I used to use that method, but it's tedious if you need to use more than 2 colors. I like the array method because it's less code and more scalable.

keith

sirTemplar

it's really hard to be a newbie! 😕 how much more without you guys🙁 !

this is the code right now:

if ($row = mysql_fetch_array($result)) {

// place these outside the loop

$BGcolors = array("#c0c0c0","#9690cc"); // use double quotes and specifiy as array
$colors = count($BGcolors);//# of colors in array.
$rownum = 0; //formerly $row

do {
//use proper indentation

echo "<table border=0 cellpadding=0 cellspacing= style=border-collapse: collapse bordercolor=#111111 width=100% id=AutoNumber1>
<tr>
<td width=50% bgcolor=#E1FFFF align=left width=80% valign=top><font face=Verdana size=2 color=#800000><b><li>{$row['NOMRL']} {$row['CNOMEN']}</b></td>
<td width=50% bgcolor=#E1FFFF align=left width=80% valign=center><font face=Verdana size=2 color=#000000> from {$row['PROVEN']}:</br>
<font face=Verdana size=2 color=#FF0000>{$row['PROFTDAT']}</tr></td></font></li></table>";

} while($row = mysql_fetch_array($result));
} else { print "There are no temporary professions!";
//{ <- this shouldn't be here remove it

//change the iterating variable $row to $rownum since $row is your assoc array in $row = mysql_fetch_array

print "<tr bgcolor=\"" . $BGcolors[$rownum%$colors] . "\">";
$rownum++;
}

?>
</td>
</tr>
</table>
</td>

</tr>

</table>
<?
echo "<table bgcolor=#FFFEEF border=0 cellpadding=1 cellspacing=0 style=border-collapse: collapse bordercolor=#111111 width=100%>
<td align=left width=70% valign=top>$totalrows out of $totalrecs record(s) found !</td></table>";

it's not giving any errors! but it was as before! no alternating colors!

sigh... sigh

keith73

it's not giving any errors! but it was as before! no alternating colors!

You're table row that has the background color is not inside the loop. You have in the else statement. That way you'll only see a row with the first bg color only once if there are no results returned. You need to work it into the loop.

Also, your table is created in the loop, but not closed in the loop. The table should start outside the loop and the dynamic rows should be inside the loop.

<?php
if(mysql_num_rows($result) > 0){
	$BGcolors = array("#c0c0c0","#9690cc");
	$colors = count($BGcolors);//# of colors in array.
	$rownum = 0;
	print "<table>";
	while($row = mysql_fetch_array($result)){
		//display your results in here with alternating background colors
		print "<tr bgcolor=\"" . $BGcolors[$rownum%$colors] . "\">";
		print "<td>" . $row['fieldname'] . "</td>\n";
		print "<td>" . $row['fieldname2'] . "</td>\n";
		print "</tr>";
		$rownum++;
	}//end while-loop
	print "</table>";
} else {
	print "No results returned!";
}//end if-else
?>

keith

sirTemplar

thx keith, it seems to work little by little! 🙂 but this code:

print "<td align=left valign=top><li>" . $row['NOMRL' ] . $row['CNOMEN'] . "</td>\n";

give me the NOMRL and CNOMEN but attached (putting a space with the spacebar wont work!)! something like

PAULEdwards instead of PAUL EDWARDS and i would like to have PAUL bold and not Edwards, where do i insert the <tags>?

thanks!

keith73

print "<td align=left valign=top><li>" . $row['NOMRL' ] . $row['CNOMEN'] . "</td>\n";

 print "<td align=left valign=top><font face=Verdana size=1 color=#FF0000><li><b>" . $row['NOMRL' ] . "</b> " . $row['CNOMEN'] . "</td>\n";

keith

siwis

print "<td align=left valign=top><li>" . $row['NOMRL' ] . " " . $row['CNOMEN'] . "</td>\n";

siwis

beat me to it 😉

sirTemplar

. $row['NOMRL' ] . " " . $row['CNOMEN'] .

sirTemplar

thanks for all the help guys! all is working well now! 😃
special thanks to keith!