Form Update Problem

Ivains

Hi Everyone,
I am having a little trouble with this form. I looked it over several times and search the forum to no avail. The problem is probably staring me in the face.

Anyway when the info is submitted the form tells me it was successful, however the database was not updated. I know I had to miss something, can someone help me out a little.

Thanks
:o) Ivan

Partial Code:

$sql = "SELECT * FROM lsv WHERE vid = \"$vid\"";

$sql_result = mysql_query($sql,$link) or die ("Couldn't execute Query!");

while ($row = mysql_fetch_array($sql_result)) {

$vid = $row['vid'];
$reg = $row['reg'];
$stopdate = $row['stopdate'];
$stop = $row['stop'];
}
}

$form_block = "

<table border='0' width='300' cellpadding='1' cellspacing='1'>
<tr>
<td>Update mileage on: $reg </td>
</tr>
</table>

<table border='0' width='300' cellpadding='1' cellspacing='1'>
<tr>
<td>Date:</td>
<td><input type=\"text\" name=\"stopdate\" value=\"$stopdate\" size=\"10\" maxlength=\"50\">   (YYYY-MM-DD)</td>
</tr>
<tr>
<td valign='top'>Total Mileage:</td>
<td><input type=\"text\" name=\"stop\" value=\"$stop\" size=\"10\" maxlength=\"30\">   </td>
</tr>
<tr>
<td></td>
<td><input type=\"hidden\" name=\"op\" value=\"ds\">
<input type=\"submit\" name=\"submit\" value=\"Update Mileage\"></td>
</tr>
</table>
</form>

<center>[ <a href=\"?\" onClick=window.close();>Close Window</a> ]</center>

if ($op != "ds") {
echo "$form_block";
}

elseif ($op == "ds") {

if ($stopdate == "0000-00-00") { $stopdate_error = "Please Enter Date! ";
$submit = "no"; }

if ($stopdate == "") { $stopdate_error = "Please Enter Date! ";
$submit = "no"; }

if ($stop == "0") { $stop_error = "Please Enter Mileage! ";
$submit = "no"; }

if ($stop == "") { $stop_error = "Please Enter Mileage! ";
$submit = "no"; }

if ($submit != "no") {

$sql = "UPDATE lsv
SET
stopdate = \"$stopdate\",
stop = \"$stop\"
WHERE vid = \"$vid\"
";

echo "$reg Mileage Update Successful!";

echo "<center>[ <a href=\"?\" onClick=window.close();>Close Window</a> ]</center>";

$sql_result = mysql_query($sql,$link) or die ("Couldn't execute Query!");

}

if ($submit == "no") {

echo "$stopdate_error";
echo "$stop_error";
echo "$form_block";

}
}

YES, register_globals is "on".

bastien

echo out the sql statement

if ($submit != "no") {

$sql = "UPDATE lsv
SET
stopdate = \"$stopdate\",
stop = \"$stop\"
WHERE vid = \"$vid\"
";

does it have the correct values? or any values?

one coding tip here to place the form in a function and call it when needed. then the code flows something like this....

<?
//load page with initial form

if (!$submit){

show_form();    //load the form and show the data

}else{ //submit pressed and need to make changes

//validate data....could even be a function on its on
// [b]if[/b] all data correct then 
//         [b]update[/b] database
// [b]else[/b] not all data correct
//         [b]show_form()[/b]
//  [b]end if statement[/b]

} //end main if loop

this will simplify the flow of the program and keep the main program simple and the functions are then easier to debug...

hth

Ivains

Yes. What I am doing is calling it from another page which displays the stopdate (date entered), stop (stop mileage) and calling it with this tag so I can update it: <a href=\"UpdateMileage.php?vid=$vid\" onclick=\"NewWindow(this.href,'name','340','210','yes');return false;\">.

Once the UpdateMileage.php comes up it displays the vehicle reg number with the last mileage update information. I then fill in the cells with the new info and submit. It states it was successful however the db was never updated.

This is the entire code:

include("config.inc");

$link = mysql_connect ($server, $user, $password);
if (! $link)
{
die ("Couldn't connect to mySQL server");
}
if (!mysql_select_db ($db, $link) )
{
die ("Couldn't open $db: ".mysql_error() );
}

$chk_id = "SELECT vid from lsv WHERE vid = \"$vid\"";
$chk_id_res = @($chk_id,$link) or die("Couldn't execute query.");
$chk_id_num = mysql_num_rows($chk_id_res);

if ($chk_id_num == "0") {

echo "  Sorry, No Records Found!";

echo "<center>[ <a href=\"?\" onClick=window.close();>Close Window</a> ]</center>";

exit;

} else {

$sql = "SELECT * FROM lsv WHERE vid = \"$vid\"";

$sql_result = mysql_query($sql,$link) or die ("Couldn't execute Query!");

while ($row = mysql_fetch_array($sql_result)) {

$vid = $row['vid'];
$reg = $row['reg'];
$stopdate = $row['stopdate'];
$stop = $row['stop'];
}
}

$form_block = "

<table border='0' width='300' cellpadding='1' cellspacing='1'>
<tr>
<td>Update mileage on: $reg </td>
</tr>
</table>

<center>[ <a href=\"?\" onClick=window.close();>Close Window</a> ]</center>

if ($op != "ds") {
echo "$form_block";
}

elseif ($op == "ds") {

if ($stopdate == "0000-00-00") {$stopdate_error = "Please Enter Date! ";
$submit = "no"; }

if ($stopdate == "") { $stopdate_error = "Please Enter Date! ";
$submit = "no"; }

if ($stop == "0") { $stop_error = "Please Enter Mileage! ";
$submit = "no"; }

if ($stop == "") { $stop_error = "Please Enter Mileage! ";
$submit = "no"; }

if ($submit != "no") {

$sql = "UPDATE lsv
SET
stopdate = \"$stopdate\",
stop = \"$stop\"
WHERE vid = \"$vid\"
";

echo "$reg Mileage Update Successful!";

echo "<center>[ <a href=\"?\" onClick=window.close();>Close Window</a> ]</center>";

$sql_result = mysql_query($sql,$link) or die ("Couldn't execute Query!");

}

if ($submit == "no") {

echo "$stopdate_error";
echo "$stop_error";
echo "$form_block";

}
}
?>

Once Again
Thanks

Ivains

Solved. Broke into 2 seperate files. Thx.