array_pop() kills script in 4.3.0. doesnt in 4.1?

[ElectusUnum]

I have a function that reads all the post variables from a form and then formats them to be inserted info a mysql database. On my Mac, running apache 1.3 and php 4.1.2 I use array_pop to take off the last post variable which is Submit - I don't need that. When i moved my script over to a server running apache 2.0 and php 4.3.0 the script dies. Any idea whats going wrong?

[planetsim]

I think that was a depreciated function in 4.1 so most likely it isnt in 4.3

[ElectusUnum]

So what do I do now? Whats the equivalent function in 4.3? Anything to pop the last element off the array will work. What a headache!

[128kb_com]

Thats funny, cause the manual says array_pop was introduced in v4 and the output of this command line with a 4.3 install returns "yes":

$ php -r 'if (function_exists("array_pop")) echo "yes\n"; else echo "no\n";'

prints yes

What error message does php print to screen when you use it?

[ElectusUnum]

Nothing, it just doesnt work - which is what makes this so irritating. When I remove it, the script works (except for the extra post value) and php 4.1 on my mac - as I said before - uses array_pop fine. There must be another function that does a similar task?

[128kb_com]

Why not just make your own?

function myarray_pop(&$array)
{
	if (is_array($array)) {
		$last_elm = $array[sizeof($array)];
		unset($array[sizeof($array)]);
		return $last_elm;
	}
	else
		return NULL;
}

[ElectusUnum]

I tried that, but it doesnt work :/

even

unset($_POST[sizeof($_POST)]);

[planetsim]

unset($POST[sizeof($POST)]);

problem is there

[ElectusUnum]

I downgraded to 4.23 and all is working perfectly with array_pop shakes fist at the sky

[PyroX]

Can't you just take the name value off your submit button? I am not 4 sure.

<INPUT TYPE=SUBMIT VALUE=go>

[ereptur]

I agree with PyroX. Just remove the name attribute from your input tag and it won't have a key to pass the value with. Voila. No submit value passed.

[ElectusUnum]

But that doesnt work for a button like Update or Add User. I could just use submit for all my buttons, which is what I'll probably do in the future seeing as I'll upgrade sooner or later. Still, the fact that array_pop doesnt work is frustrating.

[PyroX]

Why are you using it at all? Give me a code example or describe your reasons to justify your method.

USE: unset($array[count($array)]);

Are you sure your data is getting there at all with 4.3?
Have you tried to debug by outputting some of the values?

You should be more presise when getting values from forms, IMO.

[ElectusUnum]

It works fine if I remove the array_pop, but it includes the buttons name as a value. unset doesnt seem to work either, is that because post is a namebased arrray?

function DBSubmit()
{

if($_POST['update'] || $_POST['updateuser'])
{
  array_pop($_POST);
  $sqlcall = $this-> DBFormatRequest("update");
}
else if($_POST['delete']) 
{
  $sqlcall = $this-> DBFormatRequest("delete");
} 
else if($_POST['submit'] || $_POST['adduser'])
{
  array_pop($_POST);
  $sqlcall = $this-> DBFormatRequest("add");
}
echo $sqlcall;
mysql_query($sqlcall);

}

[PyroX]

snip...
...
if($POST['update'] || $POST['updateuser'])
{
@unset($POST['update']);
@unset($POST['updateuser']);
$sqlcall = $this-> DBFormatRequest("update");
}
...
...snip

[ElectusUnum]

Ah, now that makes sense. Thanks for helping a n00b such as myself.
-Matt