Whats wrong with this Insert statement???

[mark_h_uk]

Hi,

Basically ive got the below in a while loop going through each row in the mysql db:

$query = "UPDATE manuf SET show='0' WHERE manuf=$manufa";
$result = mysql_query($query) or die(mysql_error);

for some reason it returns hidemysql_error and the db is not updated. Anyone know what the problem is?

Thanks,

Mark

[mkarabulut]

I think it is really hard to make comment upon it cos anything can cause an error..

If table manuf doesn't exist, or field manuf doesn't exist or type of field manuf is not integer..

You didn't cover the variable $manufa with quotations what means if the field type is different from a numerical type it may cause an error..

I think, it will be nice if you write here what mysql_error() says..

[mark_h_uk]

The tables and fields are there mate, the manuf field is text so i've just tried putting quotes around it but still no joy.

Sorry fot being dumb but how do i get the contents of mysql_error() because the error is hidden when it returns to the browser.

[mark_h_uk]

Abit more background and code to see the bigger picture:

Ok ive got a form on another page that contains checkboxes of all the cars manufaturers in the database when the form is posted it goes the below script is called. When the checkboxes are unclicked i want the show field to be updated with a 0.

All the variables work as i've tested it without using the insert statement so the problem must be in that statement.

<? include ("connect1.php");
        // Compose SQL command 
    $SQL = "SELECT * FROM $table"; 


//        Query the Database 
    $result = mysql_query($SQL) or die("could not complete your query"); 
    while($row = mysql_fetch_array($result)) { 
            $id = $row["id"]; 
            $manufa = $row["manuf"]; 
        $show = $row["show"];

        echo $$manufa;

        echo $manufa;

        if ($manufa == $$manufa) 
        { 
            echo "    ==show";

        }
        if ($manufa != $$manufa) 
        { 
            echo "    ==hide";

            $query = "UPDATE manuf SET show=0 WHERE manuf='$manufa'";
                            echo $result = mysql_query($query) or die(mysql_error) ;


        }
?><br> <?  } ?>

[xblue]

I may be wrong on this, but I doubt that the syntax you use

$result = mysql_query($query) or die(mysql_error) ;

will work.

Try

$result = mysql_query($query) or die(mysql_error()) ;

This should bring up the propper mysql error (if there is one).

Another thought that may increase efficiency:
say you name your checkboxes like this
<input type="checkbox" name="manufacturers[]" value="...">
you could easily generate a comma-separated list with all selected manufacturers using implode(), like this (mind the singlequotes)

$list="'".implode("','"$_POST['manufacturers'])."'";

and use it in just one sql query which would update all value that are not in the list at once:

$sql="UPDATE manuf SET show=0 WHERE manuf NOT IN ($list)";
mysql_query($sql) or die(mysql_error());

[mark_h_uk]

I found the error 🙂 I had a field called show and it seems that show is a keyword in mysql and that whats was messing my update statement up.