Help with Coding

[phpnewbie911]

Hello everyone,
I've got a script that I wrote but it keeps failing at Line 33(my closing tags).
Would someone look at it and see what I'm missing.
I've checked it over and over, and it looks ok to me.
But any help will be appreciated.
Its a processing script for login and my way of monitoring login by email. Its failing at the closing tags for some reason.
Heres the script and I am a newbie some its not perfect.

<?

if((!$Username) | (!$Password)) {
print ("Please Click Your Browsers Back Button And Enter A Username and Password");
}
#db connection
$dbh=mysql_connect("localhost","username","password");
mysql_select_db("db_name");

# Making my login page have the main value of Password
$Password = "69zh($Password)";

$sql = "select * from my_table where Username=$Username and Password=$Password";
$result = mysql_query($sql);
$num = mysql_numrows($result);

# If Login Is Okay I will create variables for an email to me 
if ($num == "1") {
#my email variables
$message = "Username:\t$Username";
$message .= "Password:\t$Password";

#Here is where I send mail and I use Password variable as a email filter
mail( "[e-mail]", "Subject",
	$message, "Wrom: XZOWCONEUQZAA
header("Location: [url]http://www.mydomain.com/secure/[/url]$Password.htm");
exit;

# And default error message if login fails
if ($num == "0"){
print ("Sorry You Do Not Have Access. Please Contact Support.");
}
?>

Any and all suggestion will be appreciated.
Thanks In Advance.
😕

[daphreeek]

This bit of code is missin a bit I think:

# If Login Is Okay I will create variables for an email to me 
if ($num == "1") {
#my email variables
$message = "Username:\t$Username";
$message .= "Password:\t$Password";

#Here is where I send mail and I use Password variable as a email filter
mail( "[e-mail]", "Subject",
    $message, "Wrom: XZOWCONEUQZAA
header("Location: <a href="http://www.mydomain.com/secure/" target="_blank">[url]http://www.mydomain.com/secure/[/url]</a>$Password.htm");
exit;

There is no end } to the if statement. also the end of the mail() command is missing, but thats probably just a bit you didnt copy 2 here coz at the end of ur mail("....", "....", ..., ".... you need a closing quote + bracket ie: ");

hope that helps a bit 🙂
- Matt

http://daphreeek.kicks-ass.net

[phpnewbie911]

Thanks Daphreek.
I corrected the mail function and added the bracket to my second if statement and now my error is on the mail function line. Here's that code if anybody has any suggestions.

<?

if((!$Username) | (!$Password)) {
print ("Please Click Your Browsers Back Button And Enter A Username and Password");
}
#db connection
$dbh=mysql_connect("localhost","username","password");
mysql_select_db("db_name");

# Making my login page have the main value of Password
$Password = "69zh($Password)";

$sql = "select * from my_table where Username=$Username and Password=$Password";
$result = mysql_query($sql);
$num = mysql_numrows($result);

# If Login Is Okay I will create variables for an email to me 
if ($num == "1") {
}
#my email variables
$message = "Username:\t$Username";
$message .= "Password:\t$Password";

#Here is where I send mail and I use Password varible as a filter
mail()"[e-mail]", "Subject",
	$message, "Wrom: KEDOTWFAOBUZX
header("Location: [url]http://www.mydomain.com/secure/Password.htm[/url]");
exit;

# And we must a have a default error message if login fails
if ($num == "0"){
print ("Sorry You Do Not Have Access. Please Contact Support.");
}
?>

I still don't see whats wrong.
Thanks😕

[diego25]

mail()"[e-mail]", "Subject",

$message, "Wrom: KEDOTWFAOBUZX

Isn't that error a bit too obvious? Anyway, it should be:

mail("[e-mail]", "Subject",

$message, "From: KEDOTWFAOBUZX");

Diego

[daphreeek]

diego said wot i meant (and thaught i said). also when u put the end } on the if statement, u need to put it so it encloses something or its useless.

I think this is what u where meaning to do:

# If Login Is Okay I will create variables for an email to me 
if ($num == "1") {
#my email variables
$message = "Username:\t$Username";
$message .= "Password:\t$Password";

#Here is where I send mail and I use Password variable as a email filter
mail("[e-mail]", "Subject", $message, "From: KEDOTWFAOBUZX"); 
header("Location: <a href="http://www.mydomain.com/secure/" target="_blank">[url]http://www.mydomain.com/secure/[/url]</a>$Password.htm");
exit;
}

• Matt