Recursive Drectory Listing

[rpanning]

I'm trying to make a recursive directory listing script, I've seen another one at http://www.phpbuilder.com/snippet/detail.php?type=snippet&id=865 that does what I want but the coding looks a little bad. I've tried to clean it up and this is what I've got.

<?php 
function SiteMap($SiteRoot) {
  if ($OpenDir = opendir($SiteRoot)) {
    while (false !== ($Item = readdir($OpenDir))) {
      if (is_dir($Item) && $Item != "." && $Item != "..") {
        echo "<b>$Item</b>\n";
        echo "<blockquote>\n";
        SiteMap($SiteRoot."/".$Item);
        echo "</blockquote>\n";
      }
      elseif (is_file($Item)) {
        echo "$Item<br>\n";
      }
    }
    unset ($Item);
    closedir($OpenDir);
  }
  unset ($OpenDir);
}
SiteMap($_SERVER['DOCUMENT_ROOT']);
?>

What happens is I get a listing of the first dir. The blockquotes also show up so I know that it's getting that far but when it comes to calling the function again it doesn't work. The other script (posted below) works just fine. I don't know what I'm doing wrong. I THINK my script is doing the same as below but just with a little cleaner code. Any help with this would be great!

Thanks,
Ryan

<?
// Copyright 2002 Adam Taylor
// Email [email][e-mail][/email]

function ListFiles($root) {
	if (!$root) $root = $_SERVER["DOCUMENT_ROOT"]."/";  // No brackets, I know this will be set, no need for it in my script
		if ($dir = @opendir($root)) {
		echo "<B>$root</b><BR\n>";                      // I don't need this, took it out on my script
		$file = readdir($dir);                          // This is set later...
		$file = readdir($dir);                          // Ah, ya...
		$num = "";                                      // varify folder or dir later (I used is_dir and is_file instead)
		  while (($file = readdir($dir)) !== false) {   // A little backwards but it still works
		  $num =  strstr($file, '.') ;                  // Sets the extention or if there is a . in $file

	   if ($num != "") {                            // If there was a . in $file...
	     echo "$file<BR>\n";
	   } else {                                     // If there is no . in $file must be folder (ya, I'd hope so)
	   $newroot = $root.$file;                      // Sets the new docroot
		 echo "<BLOCKQUOTE>\n";
		 ListFiles($newroot."/");                   // Calles the function again with new doc root
		 echo "</BLOCKQUOTE>\n";
	}

	}  
	closedir($dir);
}
}


// Syntax: ListFiles( Root Directory);
//
// The following will show all files in the document folder
// of your server.
ListFiles($_SERVER["DOCUMENT_ROOT"]."/");

?>

[milind24]

Try this :

function SiteMap($SiteRoot) 
{
    print "<b>".$SiteRoot."</b><br>";
    if ($OpenDir = @opendir($SiteRoot))
	{
        $file = readdir($OpenDir);
        $file = readdir($OpenDir);
		while (false !== ($file = readdir($OpenDir))) 
		{
			$num =  strstr($file, '.') ;
            if ($num != "")
			{                           

             echo "$file<BR>\n";
			}
			else
			{
				$newroot = $SiteRoot.$file;
				echo "<BLOCKQUOTE>\n";
				SiteMap($newroot."/");
				echo "</BLOCKQUOTE>\n";
			}
		}
		unset ($file);
		closedir($OpenDir);
	}
	else
	{
		print "unable to open dir : ".$SiteRoot;
	}
    unset ($OpenDir);
}
SiteMap($_SERVER["DOCUMENT_ROOT"]."/");

[bobthedog]

You were just missing the SiteRot variable on you is_dir() and is_file() function calls

$Item only contains the file/dir name (i.e. fred.php) and so you need to make sure it has the whole path (i.e. $SiteRoot . "/" . $Item) in the function call.

if (is_dir($SiteRoot . $Item) && $Item != "." && $Item != "..") 

My version below has omitted the need for this by ensuring that all values of $SiteRoot have a slash at the end from the start (i.e. use "/tmp/" as the initial value instead of "/tmp").

function SiteMap($SiteRoot) {
  if ($OpenDir = opendir($SiteRoot)) {
    while (false !== ($Item = readdir($OpenDir))) {
      if (is_dir($SiteRoot . $Item) && $Item != "." && $Item != "..") {
        echo "<b>$Item</b>\n";
        echo "<blockquote>\n";
        SiteMap($SiteRoot. $Item . "/");
        echo "</blockquote>\n";
      }
      elseif (is_file($SiteRoot . $Item)) {
        echo "$Item<br>\n";
      }
    }
    unset ($Item);
    closedir($OpenDir);
  }
  else
  {
  	echo "Cannot open " . $SiteRoot;
  }
  unset ($OpenDir);
}
SiteMap("/tmp/");

[rpanning]

Thanks bobthedog, that's just what I was looking for (and couldn't see, lol). milind24, that is almost exactly the same code I was trying to fix up because of some unusefull code in it (bottom of my first post). With bobthedogs change my script above works great. It's a little different than your script but it does what I need. Thanks for the reply anyway!

Ryan