Could i get a little help?

Eryqu

Hay everyone...

I am new to php and im picking it up kinda slow... i now have run into a stump and figured i should ask for some help here...

This is what im trying to do...

I have a db made that has 2 fields attack and defence (and id but im not including that) I can update the 2 fields by editing the values in the UPDATE SET thing. but what i really want to be able to do is... When a link is clicked then bonus attack or defence is added...

here is my code as of now:

<?
$db= mysql_connect("localhost", "*", "");
mysql_select_db("***",$db);
$table="practice";
$values = "'300','250'";
$result = mysql_query("SELECT attack, defence FROM $table",$db);
$row = mysql_fetch_array($result);

$attack = $row["attack"]; 
$defence = $row["defence"]; 
$atk_bonus = "$attack";
$dfs_bonus = "$defence";
$query = "UPDATE $table SET attack=$atk_bonus, defence=$dfs_bonus";
mysql_query($query);

echo "Attack: $attack Defence: $defence <a href=#>Add Attack</a>     <a href=#>Add Defence</a>";
mysql_close($db);
?>

so now... on the "add attack" and "add defence" link i want it to be incermented like +50 or something...

Mostly to like stimulate buying something... say you bought a gun or a shield... your atk and dfs would go up...

Thanks for any help in advance
Erik~~~

reidme

//notice the '+50'
$query = "UPDATE $table SET (attack=$atk_bonus +50), (defence=$dfs_bonus +50)";

Eryqu

I mean when a link is click... the attack or defence is increased...

would it be like:

<a href="$attack=$attack+50">Add Attack</a>
??

As u can see lol im a little lost with where to go next... do i need javascript to do a function?

Thanks
Erik~~~

bernouli

hmm, i think its not a good idea solving that with links/get-methode

what would happen, when a user type in the url http://games.gov/addatack.php?attack=10000000 😃

Eryqu

Ok that point is taken very well...

which direction should i lean with this then?

and if not to hard, this is only for practice... So i wouldnt mind making it a link still

but like i said above... what would be a better approch to this?

Any input?
Erik~~~

reidme

say u have a link:
<a href="<? echo $PHP_SELF."?buy=".$buy_type; ?>">
Then you need to update that users inventory in the db,
after the buying update query is sent, put another query in: "attack = attack +50".

bernouli

<?
$db= mysql_connect("localhost", "****", "****");
mysql_select_db("****",$db);
$table="practice";
$values = "'300','250'";
$result = mysql_query("SELECT attack, defence FROM $table",$db);
$row = mysql_fetch_array($result);

$attack = $row["attack"];
$defence = $row["defence"];
$atk_bonus = "$attack";
$dfs_bonus = "$defence";
$query = "UPDATE $table SET attack=$atk_bonus, defence=$dfs_bonus";
mysql_query($query);

if(isset($attack_bonus)) {
$query = "UPDATE $table SET attack=attack+$attack_bonus";
mysql_query($query);
}
echo "Attack: $attack <br>Defence: $defence<br>
<a href="file.php?attack_bonus=50">Add Attack</a> 
mysql_close($db);

?>

Eryqu

Ok after playing with this a bit... i do relize its not very sacure 😉 but it dose work... this is my code:

<?
$db= mysql_connect("localhost", "*", "");
mysql_select_db("***",$db);
$table="practice";

$result = mysql_query("SELECT attack, defence FROM $table",$db);
$row = mysql_fetch_array($result);

$attack = $row["attack"];
$defence = $row["defence"];
$atk_bonus = "$attack";
$dfs_bonus = "$defence";
$query = "UPDATE $table SET attack=$atk_bonus, defence=$dfs_bonus";
mysql_query($query);

if(isset($attack_bonus)) {
$query = "UPDATE $table SET attack=attack+$attack_bonus";
mysql_query($query);
}

if(isset($defence_bonus)) {
$query = "UPDATE $table SET defence=defence+$defence_bonus";
mysql_query($query);
}

echo "<center>Attack: $attack Defence: $defence 
<a href=\"test.php?attack_bonus=50\">Add Attack</a>          <a href=\"test.php?defence_bonus=50\">Add Defence</a>
</center>";
mysql_close($db)
?>

and you can view my progress here: Madclouds.com/test.php

but it dose something weird... When you click the attack... it adds 50, then when you click defence it adds another 50 attack.. and then the next link you click adds the 50 defence...
I hope you understand what i mean..
If not try it out lol

What would be a better way of incramenting the attack and defence by a link?
Thanks
Erik~~~

bernouli

atk_bonus = "$attack";
$dfs_bonus = "$defence";
$query = "UPDATE $table SET attack=$atk_bonus, defence=$dfs_bonus";
mysql_query($query);

is the problems
you update the table again with the old value.
delete those lines, and your problem will be solved

Eryqu

ok now the points arn't showing up untill after you refresh the page... Is there a way to fix this...

Code:
<?
$db= mysql_connect("localhost", "", "");
mysql_select_db("",$db);
$table="practice";

$result = mysql_query("SELECT attack, defence FROM $table",$db);
$row = mysql_fetch_array($result);

$attack = $row["attack"];
$defence = $row["defence"];

if(isset($attack_bonus)) {
$query = "UPDATE $table SET attack=attack+$attack_bonus";
mysql_query($query);
}

if(isset($defence_bonus)) {
$query = "UPDATE $table SET defence=defence+$defence_bonus";
mysql_query($query);
}

And what would be a different approch to this all together?

Thanks
Erik~~~

bernouli

na, put this, below the update

$result = mysql_query("SELECT attack, defence FROM $table",$db); 
$row = mysql_fetch_array($result); 

$attack = $row["attack"]; 
$defence = $row["defence"];

the complete script would be

<? 
$db= mysql_connect("localhost", "", ""); 
mysql_select_db("",$db); 
$table="practice"; 




if(isset($attack_bonus)) { 
$query = "UPDATE $table SET attack=attack+$attack_bonus"; 
mysql_query($query); 
} 

if(isset($defence_bonus)) { 
$query = "UPDATE $table SET defence=defence+$defence_bonus"; 
mysql_query($query); 
} 

$result = mysql_query("SELECT attack, defence FROM $table",$db); 
$row = mysql_fetch_array($result); 

$attack = $row["attack"]; 
$defence = $row["defence"]; 

echo "<center>Attack: $attack <br>Defence: $defence<br> 
<a href=\"test.php?attack_bonus=50\">Add Attack</a>          <a href=\"test.php?defence_bonus=50\">Add Defence</a> 
</center>"; 
mysql_close($db) 
?>

reidme

I think the best approach would be to add the attack bonus when you subtract the money for the item bought 😃

Eryqu

U guys have been hella helpful so far... and my code is looking pretty good... but i hit another bump.

This isnt working (part in red):

if(isset($attack_bonus)) {
$query = "UPDATE $table SET attack=attack+$attack_bonus";
mysql_query($query);
}

if(isset($defence_bonus)) {
$query = "UPDATE $table SET defence=defence+$defence_bonus";
mysql_query($query);
}

$result = mysql_query("SELECT attack, defence, money FROM $table",$db);
$row = mysql_fetch_array($result);
$attack = $row["attack"];
$defence = $row["defence"];
$money = $row["money"];

$result = mysql_query("SELECT * FROM $table");
$NumEntries = mysql_num_rows($result);
if($NumEntries == "0") {
$values="'50','50','500',";
$query = "INSERT INTO $table ('attack', 'defence', 'money') VALUES($values)";
$result = MYSQL_QUERY($query);
echo "debug";
}

its just not posting into the fields... its leaving them blank but posting debug (just to check if the if statment is working)

So why are my fields not being inserted into?

Thanks
Erik~~~

bernouli

well, have you tried the normal one?

if($NumEntries == "0") {
$query = "INSERT INTO $table ('attack', 'defence', 'money') VALUES('50','50','500')";
$result = MYSQL_QUERY($query);
echo "debug";
}

Eryqu

ok bernouli I tried that, but it only prints debug to the screen and dosnt insert the values into the fields... any clues?

Thanks
Erik~~~

Code:
if(isset($attack_bonus)) {
$query = "UPDATE $table SET attack=attack+$attack_bonus";
mysql_query($query);
}

if(isset($defence_bonus)) {
$query = "UPDATE $table SET defence=defence+$defence_bonus";
mysql_query($query);
}

$result = mysql_query("SELECT attack, defence, money FROM $table",$db);
$row = mysql_fetch_array($result);
$attack = $row["attack"];
$defence = $row["defence"];
$money = $row["money"];

$result = mysql_query("SELECT * FROM $table");
$NumEntries = mysql_num_rows($result);
if($NumEntries == "0") {
$query = "INSERT INTO $table ('attack', 'defence', 'money') VALUES('50','50','500')";
$result = MYSQL_QUERY($query);
echo "debug";
}

bernouli

try to get the sql-error with

$query = "INSERT INTO $table ('attack', 'defence', 'money') VALUES('50','50','500')";
$result = MYSQL_QUERY($query) or die(mysql_error());

Eryqu

well i got it to work.... by going into phpMyAdmin and inserting into the fields then it told me it used this line:

INSERT INTO practice (id, attack, defence, money) VALUES('','50', '50', '500')

so i used that... and it worked 🙂

Now i added even more... I fixed it so you cant "cheat" and add 100000 attack or defence, and I also added code so you can sell attack and defence as long as u have enough :-D

Check my code:
$table="practice";
$try = mysql_query("SELECT * FROM $table");
$NumEntries = mysql_num_rows($try);
if($NumEntries == "0") {
$test = "INSERT INTO $table (id, attack, defence, money) VALUES('','50', '50', '500')";
MYSQL_QUERY($test);
}
if(isset($attack_bonus)) {
$result = mysql_query("SELECT attack, defence, money FROM $table",$db);
$row = mysql_fetch_array($result);
$money = $row["money"];
if($money < $attack_bonus){
echo "<center>Sorry u dont have enough money</center>";
}
else{

$query = "UPDATE $table SET attack=attack+$attack_bonus, money=money-$attack_bonus";
mysql_query($query);
}
}
if(isset($defence_bonus)) {
$result = mysql_query("SELECT attack, defence, money FROM $table",$db);
$row = mysql_fetch_array($result);
$money = $row["money"];
if($money < $defence_bonus){

	echo "<center>Sorry u dont have enough money</center>";
}
else {

$query = "UPDATE $table SET defence=defence+$defence_bonus, money=money-$defence_bonus";

mysql_query($query);
}
}

if(isset($defence_sell)){
$result = mysql_query("SELECT attack, defence, money FROM $table",$db);
$row = mysql_fetch_array($result);
$defence = $row["defence"];
if($defence < $defence_sell){
echo "<center>Sorry you dont have enough defence to sell right now</center>";
}
else{
$query = "UPDATE $table SET money=money+$defence_sell, defence=defence-$defence_sell";
mysql_query($query);
}
}
if(isset($attack_sell)){
$result = mysql_query("SELECT attack, defence, money FROM $table",$db);
$row = mysql_fetch_array($result);
$attack = $row["attack"];
if($attack < $attack_sell){
echo "<center>Sorry you dont have enough attack to sell right now</center>";
}
else{
$query = "UPDATE $table SET money=money+$attack_sell, attack=attack-$attack_sell";
mysql_query($query);
}
}
$result = mysql_query("SELECT attack, defence, money FROM $table",$db);
$row = mysql_fetch_array($result);
$money = $row["money"];
$attack = $row["attack"];
$defence = $row["defence"];

echo "<center>Attack: $attack Defence: $defence Money: $money 
<a href=\"test.php?attack_bonus=50\">Add Attack</a>          <a href=\"test.php?defence_bonus=50\">Add Defence</a> 
<a href=\"test.php?attack_sell=50\">Sell Attack</a>          <a href=\"test.php?defence_sell=50\">Sell Defence</a>
</center>";
mysql_close($db)
?>

U guys have been so helpfull so far
THANKS!
Erik~~~

Eryqu

Im so happy i just feel like letting everyone know that my script is working PERFECTLY...

got here and play around if you wana see what my first php script was...

TEST.PHP

Thanks a lot and i will be posting much more often now i bet :p

Erik~~~

bernouli

Now i added even more... I fixed it so you cant "cheat" and add 100000 attack or defence, and I also added code so you can sell attack and defence as long as u have enough :-D

nice trick. but ... 😉
what happen when I do this

test.php?defence_bonus=-100000

now i have $100000 and then

test.php?attack_bonus=100000

😃 😃 😃 😃

Eryqu

wow that you very much for finding that "bug" i fixed it now with this code:

if($attack_sell < 0){
$status = "Are you trying to cheat???";
}

and i have one for $attack_bonus, $defence_bonus, $defence_sell so it should be all fixed now...

If ya find anything else let me know 😃

I liked fixing that
Thanks
Erik~~~