unexpected T_STRING? i duno whats wrong....

Monkee_Of_Evil

Hey, I'm pretty much a noob when it comes to php, I'm trying to (very slowly) code my own CMS for my site that runs off of our forums database (kind of a portal system). I figured out how to connect to a database, run a query, and then print the results of the query to my site, but When i tried turning that around and using querys from the results as variables I get errors. I don't really know why it won't work, but i'm figuring its a syntax error since the error i get when i run the script is this...

Parse error: parse error, unexpected T_STRING in /home/www/napjunk/content_retrieval.php on line 19

here is the code i have, I've documented it (for both my sake and yours..lol)

<?
// config stuff
$db_name='my_db';
$db_uname='my_user_name';
$db_pass='my_pass';
$db_host='my_db_host';
$website_address='my_site';

//connect to the database and then select the table
mysql_connect($db_host,$db_uname,$db_pass);
@mysql_select_db($db_name);

//Query to get stuff from phpbb_topics
$q0 = mysql_query("SELECT * FROM phpbb_topics WHERE forum_id=32 ORDER BY topic_time DESC LIMIT 0,2");
$phpbb_topics_db_array = mysql_fetch_array($q0);
$str_topic_id = $phpbb_topics_db_array['topic_id'];

//Query to get stuff from phpbb_posts
$q1 = mysql_query("SELECT * FROM phpbb_posts WHERE topic_id =". $str_topic_id . " ORDER BY post_time DESC LIMIT 0,2");
$phpbb_title_db_array = mysql_fetch_array($q1);
$str_cur_post = $phpbb_title_db_array['post_id'];

//Query to get stuff from phpbb_posts_text
$q2 = mysql_query("SELECT * FROM phpbb_posts_text WHERE post_id=". $str_cur_post ." ORDER BY post_time DESC LIMIT 0,2");
$phpbb_post_text_array = mysql_fetch_array($q2);

echo($post_text['post_subject'] . "<br><br>");
echo($post_text['post_text'] . "<br><br>");
echo("<a href=\"" . $website_address . "viewtopic.php?t=" . $phpbb_post_text_array['topic_id'] . "\">" . $phpbb_post_text_array['topic_title'] . "</a>");
?>

Edit: oh yeah, the script runs @ this url:

http://www.napjunk.net/content_retrieval.php

scoppc

I guess ... that error come out because you forgot to put a ";" sign on one of your line.

Kerry_Kobashi

Your missing a semicolon on these lines:

$str_topic_id = $phpbb_topics_db_array['topic_id']
$str_cur_post = $phpbb_title_db_array['post_id']

Also, capitalize the E in ORDER on the first query

Monkee_Of_Evil

ugh, i knew it was going to be something stupid like that...i guess thats what happens when you look @ code long enough....anyway thanks for the help, I was thinking of starting to hang around these forums so i can pick up some pointers and learn from the more experienced users

🙂

edit: Sorry, but it still doesnt seem to be working, although i did add the additional ; at the end of those lines...still says line 19 which is this line

$q1 = mysql_query("SELECT * FROM phpbb_posts WHERE topic_id =". $str_topic_id . " ORDER BY post_time DESC LIMIT 0,2");

i just don't get it...im going on something like 11 hours of trying to get this code to work and i'm wondering if it'd be better just to give up on it for the night and look @ it in the morning...

xblue

Hi, do you use an editor with syntax highlighting?
It makes some syntax errors easier to spot.

Here in the forum, put [php] [/php] around your code (you can even edit your original post), then you will see that you are missing the quotes at the end of this string:

("SELECT * FROM phpbb_topics WHERE forum_id=32 ORDeR BY topic_time DESC LIMIT 0,2);

Monkee_Of_Evil

Originally posted by xblue
Hi, do you use an editor with syntax highlighting?
It makes some syntax errors easier to spot.

Here in the forum, put [php] [/php] around your code (you can even edit your original post), then you will see that you are missing the quotes at the end of this string:
("SELECT * FROM phpbb_topics WHERE forum_id=32 ORDeR BY topic_time DESC LIMIT 0,2); 
[/B]

ah, thanks...for code editing i use none other than notepad. what do y'all recomend?

xblue

Lots and lots of editors here
http://www.phpbuilder.com/board/showthread.php?s=&threadid=10209798

I use one called proton myself and like it quite well, but I don't think it is very popular.

Monkee_Of_Evil

well i played around with proton and i think its pretty cool, but I gotta say i like phped better, kinda easier to use i guess..

still can't figure out whats going on with this thing. now its saying its not a valid sql arguement....

xblue

this will tell you what is going wrong with your query in more detail. echoing the query sometimes helps, too.

$sql="SELECT * FROM phpbb_topics WHERE forum_id=32 ORDeR BY topic_time DESC LIMIT 0,2";
echo $sql."<br />";
$q0 = mysql_query($sql) or die (mysql_error());

repeat this for all sql queries that may cause trouble.

Monkee_Of_Evil

Thanks! That helps a lot, for some reason its saying the query was empty, but when i ran the exact same sql in phpMyAdmin it returns a value of 244 (which is the topic id of the last post in that forum), Sorry if i get anoying w/ all the questions, but i'd rather learn it than have someone else do it for me...i'm gonna try browsing through some of the stuff in the SQL area of the forums as well as reading that thing on retrieving stuff from a DB that was posted in another thread i saw...

xblue

Hi, that's okay, I'm sure you would use mysql_error() right away next time 🙂

However, I have no idea yet what may cause this failure. What exactly was the output?

Also, you might want to check if you happen to use reserved words as column names, I've seen this resulting in fairly strange behaviour sometimes...
http://www.mysql.com/doc/en/Reserved_words.html

And you might change ORDeR to ORDER just for cosmetic reason, but I don't think mysql will care at all.