Value being passed to wrong variable?

[Manat]

I have a problem with my PHP code, it's lenghty code that I will paste, but somewhere, certain values are being passed to the wrong variables, but I cannot tell where.

I don't have an online URL to show the error because this is on my Dev server, and is destined as an extranet only, but I would apreciate any help.

Below is my code:

/
These are the variables passed by the get request
/
$ageId = $HTTP_GET_VARS["cboAge"];
$priceId = $HTTP_GET_VARS["cboPrix"];
$cat = $HTTP_GET_VARS["cat"];
$pieceId = $HTTP_GET_VARS["cboPiece"];
$awardWinner = $HTTP_GET_VARS["AW"]; //A True or False value
$newProduct = $HTTP_GET_VARS["New"]; //A True or False value
$pageIndex = isset($HTTP_GET_VARS["iPage"]) ? $HTTP_GET_VARS["iPage"] : 1; //The page of the results to dislay. If not defined, display 1st page.

$txtKey = $HTTP_GET_VARS["txtKey"]; //Not sure what this is for.

/
These variables, passed by the get request, are a bit more complicated and therefore more difficult to create valid search criterion. These variables are, therefore, not used in this current implementation. They are declared for future development.
/
$typeList = $HTTP_GET_VARS["cboType"]; //comma separated list of type ids.
$skillList = $HTTP_GET_VARS["cboSkill"]; //comma separated list of skill ids.

$imgDir = $uppathImg;
$numToDisplay = $NB_ELEM_AFFICHER;
$pagesToDisplay = 10;

//This function returns an array of products which matched the search criterion.(none,one,many)
$products = searchProducts($db,$ageId,$priceId,$cat,$pieceId,$awardWinner,$newProduct,$pageIndex,$numToDisplay);

//This function returns the total number of products matching the search criterion.
$numFound = countProducts($db,$ageId,$priceId,$cat,$pieceId,$awardWinner,$newProduct);

//This function returns a string of links which are used to navigate through the search results.
$navigation = searchNavigation($ageId,$priceId,$cat,$pieceId,$awardWinner,$newProduct,$numFound,$numToDisplay,$pagesToDisplay,$pageIndex);

//Display, using the given templates, the given products, the navigation links and search count.
displayPage($prodTableTemp,$prodRowTemp,$prodTemp,$products,$numFound,$navigation,$pageIndex,$typeList,$imgDir,$txtKey );

/ End of Script /

/ Functions /

//This function displays the products page
function displayPage($prodTableTpl,$prodRowTpl,$prodTpl,&$products,$numFound,$navigation,$pageIndex,$typeId,$imgDir,$txtKey ) {

//Create a Template to parse the HTML template files.
$template = new Template();

//Set the Product Table HTML Template
$template->set_file($prodTableTpl,$prodTableTpl);

//Write Search Count
$template->set_var("NUM_PRODS_FOUND",$numFound);

//Write Search Navigation links
$template->set_var("PROD_SEARCH_PAGES",$navigation);

//Write the products.
writeProducts($template,$prodRowTpl,$prodTpl,$products);

$template->set_var(array (
"IMAGE_DIR"=>$imgDir,
"PAGE_INDEX"=>$pageIndex,
"PROD_TYPE_ID"=>$typeId,
"PROD_KEY"=>$txtKey ) );

$template->pparse("display",$prodTableTpl);//out put the parsed html

}

//This function counts the total number of products matchin the search criteria
function countProducts(&$db,$ageId,$priceId,$cat,$pieceId,$awardWinner,$newProduct) {

$countQuery = countQuery($ageId,$priceId,$cat,$pieceId,$awardWinner,$newProduct);
$countQuery->doQuery2($db);
$row = $countQuery->getrow();
    return $row["count"];

}

Code will continue in next child thread.....

[Manat]

Code continuing from previous parent thread....

//Returns a string of links to navigate the search results.
function searchNavigation($ageId,$priceId,$cat,$pieceId,$awardWinner,$newProduct,$numFound,$numToDisplay,$pagesToDisplay,$curPage){

$numPages = modCount($numFound,$numToDisplay); // determine, from the number of prods and prods/page, the number of pages of search results.
$numSets = modCount($numPages,$pagesToDisplay);//determine, from number of pages and pages/set, the number of sets of pages of search results.
$curSet = (int)($curPage/$pagesToDisplay); // the current set of pages being displayed.

if( $curPage % $pagesToDisplay == 0 ) { //A new set starts at 1, not 0.   
	$curSet = $curSet -1;
}

$nextSet = ""; //Image Link to first page of next set.
$prevSet = ""; //Image Link to first page of previous set.
$next = ""; //Image Link to next page of results.
$prev = ""; //Image Link to previous page of results.
$pages = ""; //String of text links to particular pages of results in the current set.


if( $curSet > 0 ) { //A previous set of pages exist
	$page = ($pagesToDisplay * ($curSet-1)) + 1; //first page of previous set.
	$image = "flecheg2.gif"; 
	$prevSet = navImageLink($ageId,$priceId,$cat,$pieceId,$awardWinner,$newProduct,$image,$page);
}

if( $curSet < ($numSets-1) ) { //A next set of pages exist 
	$page = (($curSet + 1 ) * $pagesToDisplay) + 1; //first page of next set.
	$image = "fleched2.gif";
	$nextSet = navImageLink($ageId,$priceId,$cat,$pieceId,$awardWinner,$newProduct,$image,$page);
}

if( $curPage > 1 ) { //A previous page exists
	$page = $curPage - 1;
	$image = "flecheg1.gif";
        $prev = navImageLink($ageId,$priceId,$cat,$pieceId,$awardWinner,$newProduct,$image,$page);
}
if( $curPage < $numPages ) { //A next page exists
	$page = $curPage + 1;
	$image = "fleched1.gif";
	$next = navImageLink($ageId,$priceId,$cat,$pieceId,$awardWinner,$newProduct,$image,$page);
}	

if ($numPages >= ($pagesToDisplay * ($curSet + 1)) ) { //Current set is at least full
	$pagesInSet = $pagesToDisplay; //Display a full set of pages
} else { //Current set is not full
	$pagesInSet =  $numPages - ($curSet * $pagesToDisplay); // display remainder pages
}

$offset = $pagesToDisplay * $curSet;

echo "curPage = $curPage pagesInSet = $pagesInSet Category = $cat numPages = $numPages, numSets = $numSets curSet = $curSet setOffset = $setOffset ";
    for( $i=1; $i<=$pagesInSet; $i++ ) { //loop throught the ages in the set.
	$pages .= navLink($ageId,$priceId,$cat,$pieceId,$awardWinner,$newProduct,$curPage,($i+$offset));
}

//Return the navigation links & images.
    return $prevSet . $prev . $pages . $next . $nextSet;		

}

function navImageLink($ageId,$priceId,$cat,$pieceId,$awardWinner,$newProduct,$image,$page) {
global $PHP_SELF;

$link = "<a href=\"".$PHP_SELF."?cboAge=$ageId&dir=products&cboPrix=$priceId&cat=$cat&cboPiece=$pieceId&AW=$awardWinner&New=$newProduct&iPage=$page\" class=MyNavBar>"; 
return $link. "<img src=../../images/img_site/client/$image border=0 ></a>";

}

function navLink($ageId,$priceId,$cat,$pieceId,$awardWinner,$newProduct,$curPage,$page) {
global $PHP_SELF;

 $link = "<a href=\"".$PHP_SELF."?cboAge=$ageId&dir=products&cboPrix=$priceId&cat=$cat&cboPiece=$pieceId&AW=$awardWinner&New=$newProduct&iPage=$page\" class=MyNavBar>";  
 if( $page == $curPage ) {
	$page = "[ $page ]";
 }
 return $link . " ".$page . "</a> ";

}

//Returns the number of pages, or sets needed to display all the products or pages found.
function modCount($numFound,$numDisplay) {
$rem = ($numFound % $numDisplay) ? 1:0;
return ((int)($numFound / $numDisplay) + $rem );
}

//This function displays the products found in a 2X2 table.
function writeProducts(&$template,$prodRowTpl,$prodTpl,&$products) {

//Count the number of products found.
$count = is_array($products) ? count($products) : 0;
//Set the Product Row and Product HTML templates.

$template->set_file($prodRowTpl,$prodRowTpl);
$template->set_file($prodTpl,$prodTpl);

    if( !$count ) { //If there are no products to display, display "no products message" and return.
            $noProductsHTML = "<tr><td align=center height=100 width=130>No product found for this criteria.</td></tr>";
            $template->set_var("PROD_ROWS",$noProductsHTML);
            return;
    }   //Otherwise, there exists at least one product to display...


//Determine if there are an even number of products
if( $count % 2 == 0 ) {
	$odd = false;
	$c = floor($count/3); 
} else {
	$odd = true;
	$c = floor($count/3); 
}

$i = 0;
for( $i; $i<$c; $i++ ) { //write an even number of products
writeThreeProducts($products,$i3,$prodTpl,$template);
$template->parse("PROD_ROWS",$prodRowTpl,true);
}
if ($count%3==2) {
writeTwoProducts($products,$i3,$prodTpl,$template);
$template->parse("PROD_ROWS",$prodRowTpl,true);
}
elseif ($count%3==1) {
writeOneProduct($products,$i*3,$prodTpl,$template);
$template->parse("PROD_ROWS",$prodRowTpl,true);
}
}

//Write two products in the template
function writeTwoProducts(&$products,$i,$prodTpl,&$template) {
$p = $products[$i];

writeProduct($p,$template);
$template->parse("PRODUCT",$prodTpl);
$p = $products[++$i];

writeProduct($p,$template);
$template->parse("PRODUCT",$prodTpl,true);
}

function writeThreeProducts(&$products,$i,$prodTpl,&$template) {
$p = $products[$i];
writeProduct($p,$template);
$template->parse("PRODUCT",$prodTpl);
$p = $products[++$i];
writeProduct($p,$template);
$template->parse("PRODUCT",$prodTpl,true);
$p = $products[++$i];
writeProduct($p,$template);
$template->parse("PRODUCT",$prodTpl,true);
}

//Write only one product
function writeOneProduct(&$products,$i,$prodTpl,&$template) {
$p = $products[$i];
writeProduct($p,$template);
$template->parse("PRODUCT",$prodTpl);
}

//Writes the product to the template
function writeProduct(&$prod,&$template) {

//Get the individual data items of the product
list($prodId,$prodName,$prodAge,$prodPieces,$catProd,$prodPrice,$prodSKU,$prodThmImg,$prodPopUpImg,
$awardProd,$newProd,$ageId,$skillId,$piecesId,$priceId) = $prod;

//Fill the product HTML template with the product data.
$template->set_var( array (
	"PROD_ID"=>$prodId,
	"PROD_NAME"=>$prodName,
	"PROD_AGE"=>$prodAge,
	"PROD_PIECES"=>$prodPieces,
	"PROD_CATEGORY"=>$catProd,
	"PROD_PRICE"=>$prodPrice,
	"PROD_SKU"=>$prodSKU,
	"PROD_IMAGE"=>$prodThmImg,
	"PROD_AWARD"=>$awardProd,
	"PROD_NEW"=>$newProd,
	"PROD_AGE_ID"=>$ageId,
	"PROD_SKILL_ID"=>$skillId,
	"PROD_PIECES_ID"=>$piecesId,
	"PROD_PRICE_ID"=>$priceId ) );

writePopUpImg($prodId,$prodPopUpImg,$template); //write HTML to template for pop up image of template
writeNewText($newProd,$template);//write HTML to template to display "New" text for the product

}

//If a product has a popUp Image, writes a link-javascript function for a popup window with the image.
function writePopUpImg($prodId,$popUp="",&$template) {

$html = "";
if( $popUp != "" ) {
	$html = "<a href=\"#\" onClick=\"MM_openBrWindow('showimage.php?iID=$prodId&img=1','pop','width=390,height=320')\">\n".
    "<img src=\"../../images/img_site/client/loup.gif\" border=\"0\"></a>";
}

$template->set_var("PROD_IMG_POPUP",$html);

}

//If the product is new, writes in red "New" for new products.
function writeNewText($newProd="",&$template ) {

$html = "";
if( $newProd == "1" ) {
	$html = "<font color=\"red\"> New!</font>";
}
$template->set_var("PROD_NEW_TEXT",$html);

}

//This function searches the product table for products matching the given criteria.
function searchProducts(&$db,$ageId,$priceId,$cat,$pieceId,$awardWinner,$newProduct,$pageIndex,$numToDisplay) {

//Query the database for matching products
$prodQuery = productQuery($ageId,$priceId,$cat,$pieceId,$awardWinner,$newProduct,$pageIndex);
$prodQuery->doquery2($db);
$i=0;
$products = array();
    while( $p = $prodQuery->getrow() ) {//Loop through the rows in the product table which matched the criteria.
	$prod = createProduct($db, $p ); //Creates a product from the given data.
	$products[$i++] = $prod; //put product into array.

}

echo " search products: curPage = $curPage pagesInSet = $pagesInSet Category = $cat numPages = $numPages, numSets = $numSets curSet = $curSet setOffset = $setOffset ";
return $products; //return the products found.
}

//Gets product information from other tables and returns a Product.
function createProduct(&$db,$prodRow) {

//data elements in the $prodRow
list($prodId,$newProd,$awardProd,$prodName,$prodThmImg,$catProd,$prodPopUpImg,$prodSKU,$piecesId,$priceId,$ageId) = $prodRow;

//get the pieces
$pieceQuery = piecesQuery($piecesId);
$pieceQuery->doquery2($db);
list($prodPieces) = $pieceQuery->getrow();

//get the price
$priceQuery = priceQuery($priceId);
$priceQuery->doquery2($db);
list($prodPrice) = $priceQuery->getrow();

//get the age
$ageQuery = ageQuery($ageId);
$ageQuery->doquery2($db);
list($prodAge) = $ageQuery->getrow();

echo "create product: curPage = $curPage pagesInSet = $pagesInSet Category = $cat numPages = $numPages, numSets = $numSets curSet = $curSet setOffset = $setOffset ";
//return the Product
return array($prodId,$prodName,$prodAge,$prodPieces,$catProd,$prodPrice,$prodSKU,$prodThmImg,$prodPopUpImg,
$awardProd,$newProd,$ageId,$skillId,$piecesId,$priceId);
}

Due to size limit, code will continue again on next thread.....

[Manat]

Code continuing....

//Returns the query which searches the product table
function productQuery($ageId,$priceId,$cat,$pieceId,$awardWinner,$newProduct,$pageIndex=1,$numToDisplay=6) {

$offset = ($pageIndex-1)*$numToDisplay;
$limit = " LIMIT $offset,$numToDisplay "; 
$whereClause = constructWhereClause($ageId,$priceId,$cat,$pieceId,$awardWinner,$newProduct);
$strSQL =
"SELECT DISTINCT 

	prod.Produit_ID AS prodId,
	prod.Is_New AS newProduct,
	prod.Is_Award_Winner AS awardProd,
	prod.Nom AS prodName,
	prod.img_thumb_1 AS prodThmImg,
	prod.img_pop_1 AS prodPopUpImg,
	prod.SKU AS prodSKU,
	prod.Number_Piece_Range_ID AS piecesId,
	prod.Price_Range_id AS priceId,
	prod.List_Group_Age_ID AS ageId,
	prod.Category as catProd

FROM
	Prod2 AS prod,
	AgeGr AS age

WHERE
".$whereClause." 
ORDER BY prod.Nom ASC
". $limit;
$q = new Query();
$q->setSQL($strSQL);
return $q;

}

function countQuery($ageId,$priceId,$cat,$pieceId,$awardWinner,$newProduct) {

$strSQL = "

SELECT COUNT(DISTINCT Produit_ID) AS count

FROM 
	Prod2 prod,
	AgeGr age

WHERE " .constructWhereClause($ageId,$priceId,$cat,$pieceId,$awardWinner,$newProduct);

$q = new Query();
$q->setSQL($strSQL);
return $q;

}

//Constructs the where clause for the product search query
function constructWhereClause($ageId="",$priceId="",$cat="",$pieceId="",$awardWinner="",$newProduct="") {

$i = 0; //Count the number of clauses
$whereStmts = array();//an array to hold each clause

if( $ageId != "" ) {
	$whereStmts[$i++] = " prod.List_Group_Age_Id = age.Groupe_Age_ID ";
	$whereStmts[$i++] = " age.ageCatId = '$ageId' ";
}

if( $priceId != "" ) {
	$whereStmts[$i++] = " prod.Price_Range_id = '$priceId' ";
}

if( $cat != "" ) {
	$whereStmts[$i++] = " prod.Category = '$cat' ";
}

if( $pieceId != "" ) {
	$whereStmts[$i++] = " prod.Number_Piece_Range_ID = '$pieceId' ";
}

if( $awardWinner != "" ) {
	$whereStmts[$i++] = " prod.Is_Award_Winner = '$awardWinner' ";
}

if( $newProduct != "" ) {
	$whereStmts[$i++] = " prod.Is_New = '$newProduct' ";
}

$whereStmts[$i++] = " prod.Is_Active = '1' ";


$numClauses = $i;
$whereClause = "";
for( $j = 0; $j <$numClauses - 1; $j ++ ) { // loop through each clause, construct proper SQL
	$whereClause .= $whereStmts[$j]. " AND ";
}

$whereClause .= $whereStmts[$numClauses-1];
return $whereClause;

}

//Returns the query which gets the price name from the prices table
function priceQuery($priceId) {

$strSQL =
"SELECT

	price.Nom AS prodPrice
FROM
	PRrange price
WHERE
	price.Price_Range_ID='$priceId'";
    $q = new Query();
    $q->setSQL($strSQL);
    return $q;

}

//Returns the query which gets the pieces name from the pieces table
function piecesQuery($piecesId) {

$strSQL =
"SELECT
	piece.Nom AS prodPieces	
FROM
	Number_Piece_Range piece
WHERE
	piece.Number_Piece_Range_ID='$piecesId'";


    $q = new Query();
    $q->setSQL($strSQL);
    return $q;

}

//Returns the query which gets the age name from the ages table
function ageQuery($ageId) {

$strSQL =
"SELECT
	age.Nom AS prodAge
FROM
	AgeGr age
WHERE
	AgeGr_Id='$ageId'";

    $q = new Query();
    $q->setSQL($strSQL);
    return $q;

}

?>

Ok, here is the problem... First there was not Category or $cat variable, I added that recently. So I'm able to search by category.

But now, on the when I echo variable outputs, $cat is not equal to $cat, $cat seems to be equal to $prodThmImg, I don't know why or where.

And $ageId seems to be equal to to my $cat value.

I would really appreciate any help that anyone can provide to me.
I have reached an impasse....

Thank You
MK

[Rohan_Hill]

Eeek! That's a look of code to look through if we're not even sure what we're looking for. Could you tell us how you know the values are being passed to the wrong variables, and what we're actually looking for in this script?

[Manat]

Well, suppose you have a catalog, and 3 columns show and max 2 rows. So max 6 items per page.

$ageId = $HTTP_Get_Vars cboAge
$priceId = cboPrix
$cat = cat
$pieceId = cboPiece
$awardWinner = AW
$newProduct = New
$pageIndex = isset($HTTP_GET_VARS["iPage"]) ? $HTTP_GET_VARS["iPage"] : 1; //The page of the results to dislay.

With each item, it's corresponding age is listed(it's maturity), it's price, and how many pieces it consits of. These details are written below the product image.

But the wep page does not allow to search by category, so I modified the code so it's corresponding Category Name is also fetched. But when I added $cat in the script, in what I think is, in the correct places, the image no longer shows. As if the array is not containing the last variable that $cat pushed one element foward. $cat is not equal to $cat.

Now, $cat seems to be equal to $prodThmImg, and $ageId seems to be equal to to my $cat value. $prodThmImg is the file name of the the product's image.

I cannot find where my $cat is not well positioned, or where or how the product image's name is in $cat, or how the $ageId is equal to the product's category name.

Also, in displayPage(), $cat is equal to nothing, and my SQL statement is fine.

I would appreciate any help in this.

Thank You in advance.

MK

[Manat]

Would anyone know where my variable is not well passed?

I did a print_r of the array $prod, and it seems that the problem resides in $prod.

$prodAge is empty

$catProd contains the value of $prodThmImg

$prodThmImg is correct, yet the value is repeated for some reason in $catProd

$prodPopUpImg is actually equal to $prodSKU

And the value of $ageId is equal to $catProd.

Anyone have any idea why I have this spaghetti Array?

[Manat]

I still didn't find the problem, but I think the problem resides with $prod.

Can anyone help me?