hey all. can some1 take a look at this code and tell me what is wrong.

Jimboy

<?php
$qdate = $row_rsBUFFDATA['QuotationDate'];

$cost_str = $row_rsBUFFDATA['Cost'];

$cdate = $row_rsBUFFDATA['DateConfirmed'];

$insertSQL = sprintf("INSERT INTO tblquotations (QuotationDate, Cost, DateConfirmed) VALUES ($qdate, $cost_str, $cdate)");
mysql_select_db($database_mAROFFICE, $mAROFFICE);
$Result1 = mysql_query($insertSQL, $mAROFFICE) or die(mysql_error()); //End of section
?>

hello all! first post here ;] right im using this code to write the three variables to table tblquotations. i can echo the variables and they all display the correct values. when i write them to the table the two date variables ($qdate and $cdate) show as 0001-01-01. the table fields are mysql date fields the variables are formatted correctly eg yyyy-mm-dd. i have done this before with no troubles. was just wondering if anyone out there maybe able to see where im going wrong. banging head against wall here ;] cheers

cahva

I dont know why you put the $insertSQL through sprintf(). Also you have forgot to put ' ' around the values...

<?php 
$qdate = $row_rsBUFFDATA['QuotationDate']; 

$cost_str = $row_rsBUFFDATA['Cost']; 

$cdate = $row_rsBUFFDATA['DateConfirmed']; 

$insertSQL = "INSERT INTO tblquotations (QuotationDate, Cost, DateConfirmed) VALUES ('$qdate','$cost_str','$cdate')"; 
mysql_select_db($database_mAROFFICE, $mAROFFICE); 
$Result1 = mysql_query($insertSQL, $mAROFFICE) or die(mysql_error()); //End of section 
?>

Jimboy

Cheers. Sorry im new. Also came to PHP via Dreamweaver MX which aint really the best teacher of syntax! Will try that now.

Jimboy

You probably think its faily lame lol. I have just been hacking and modifying code whilst learning what it does.

Out of interest how come this works without the ' '

<?php
$year_url = "1974";

if (isset($HTTP_GET_VARS['year'])) {
$year_url = (get_magic_quotes_gpc()) ? $HTTP_GET_VARS['year'] : addslashes($HTTP_GET_VARS['year']);
}
$month_url = "11";
if (isset($HTTP_GET_VARS['month'])) {
$month_url = (get_magic_quotes_gpc()) ? $HTTP_GET_VARS['month'] : addslashes($HTTP_GET_VARS['month']);
}
$day_url = "22";
if (isset($HTTP_GET_VARS['day'])) {
$day_url = (get_magic_quotes_gpc()) ? $HTTP_GET_VARS['day'] : addslashes($HTTP_GET_VARS['day']);
}

$date_url = $year_url . $month_url . $day_url;
$OpID = $HTTP_GET_VARS['operator'];
$JobID = $HTTP_GET_VARS['job'];
$JobType = $HTTP_GET_VARS['jobtype'];

$insertSQL = sprintf("INSERT INTO date_buffer (Date, OpID, JobID, JobType) VALUES ($date_url, $OpID, $JobID, $JobType)");
mysql_select_db($database_mAROFFICE, $mAROFFICE);
$Result1 = mysql_query($insertSQL, $mAROFFICE) or die(mysql_error()); //End of section
?>

cahva

I never really looked into this issue. I think you can use numbers without single quotes, but with letters it would give an error.

example:

This would work...
SELECT * FROM table where id=7

But this wouldnt
SELECT * FROM table where name=myname

and thats because mysql would try to find name which is the same as FIELD myname. If myname is quoted, it would search a name from table which contains 'myname'.

Sorry, I am LAME explainer 🙂

Jimboy

no no you are a fine explainer! ok i get it. basically ecapsulate the lot in single quote ' ' to be safe. thanks again your answer early helped loads. stopped banging head, started banging keyboard ;] ;]