Search multiple words

PJNEW

I am completely at a loss as to why this simple search query is spitting out everything in my database when either a single or series of words is entered in my form.

// Get the search variable from URL

$var = @$_GET['q'] ;

// rows to return
$limit = 10 ;

$array = explode ( ' ', $var ) ;

// check for an empty array
if (count($array) == 0)
  {
  echo "<p>Please enter a search</p>";
  exit;
  }

$searchQuery = "" ;

for ($i = 0 ; $i > sizeof($array) ; $i++)
{
  $searchQuery .= " \"%$array[$i]%\" " ;
} 

$query = "select imageindex, model, image, thumbimage, description, dim from images where keywords like \"%$searchQuery%\" order by model";

If anyone can throw some light on this it would be appreciated

xblue

your for loop is not executed since $i is never greater than the number of array elements 😉
therefore $searchQuery remains empty.

PJNEW

Thanks Xblue,

I tried that before but was thrown off the scent because I got a
Warning: Supplied argument is not a valid MySQL result resource in /u/web/user/searchtest.php on line 40
Line 40 is

 $numrows=mysql_num_rows($numresults);

I thought this might be a red herring, maybe I was wrong?

xblue

Okay, let's start over:
This does nothing.

for ($i = 0 ; $i > sizeof($array) ; $i++)
{
  $searchQuery .= " \"%$array[$i]%\" " ;
}

Therefore your query would be

select imageindex, model, image, thumbimage, description, dim from images where keywords like "%%" order by model

which is valid, but returns all rows.

Using lesser than in the for loop is an improvement despite of the error message. This just means the query you create in the for loop is invalid (probably due to the quotes). To fix this, you'd probably want to build a valid query.

For debugging, I'd recommend to echo the $query and to print the mysql error e.g.
mysql_query($query) or die mysql_error();
and to post it here if you can't find what is wrong yourself.

RedDragon

try this code:

for ($i=0;$i<sizeof($array);$i++)
{
$searchQuery .= "$array[$i] " ;
}

$query = "select imageindex, model, image, thumbimage, description, dim from images where (keywords like '%$searchQuery%') order by model";

i dont really understand what you are trying to do,
first you seperate all words with explode and in the end you put them all together with .=
??? why