Trouble getting insert file to work

roavanet

I am having some issues getting some code to work. What is supposed to happen is that I pull the record to be edited (Same Record everytime only 1 record posted), edit it, and resubmit it. This is to rapidly update scores for live streaming sporting events.

What basically happens is it pulls the record and allows edit with no problems. After you submit it, the screen never returns and the database is not updated...

Here is the code:

ScoreUpdate.php

<html>
<Title>Score Update</Title>
<BODY>
<CENTER><H1>Score Update</H1></CENTER>
<table cellpadding="0" cellspacing="0" width="400">
<form method="POST" action="ScoreInsert.php">
<CENTER><H1>Score Update</H1></CENTER>
<CENTER>
<tr>
<td width="50%">
Visitor Team
</td>
<td width="50%">
<input type="text" name="Vteam" size="20">
</td>
<td width="50%">
Score
</td>
<td width="50%">
<input type="text" name="Vscore" size="2">
</td>
</tr>
<td width="50%">
Visitor Team
</td>
<td width="50%">
<input type="text" name="Hteam" size="20">
</td>
<td width="50%">
Score
</td>
<td width="50%">
<input type="text" name="Hscore" size="2">
</td>
</tr>
<td width="50%">
Period
</td>
<td width="50%">
<input type="text" name="Period" size="20">
</td>
<td width="50%">
ID
</td>
<td width="50%">
<input type="text" name="id" size="1">
</td>
</tr>
<tr>
<td width="50%">
</td>
<td width="50%">
<input type="submit" value="Update Score" name="btnSubmit">
</td>
</tr>
</table>
</form>
</BODY>
</html>

ScoreInsert.php

<?php
echo "Code Started<br>" ;
$id = $POST['ID'];
$Vteam = $POST['Vteam'];
$Vscore = $POST['Vscore'];
$Hteam = $POST['Hteam'];
$Hscore = $POST['Hscore'];
$Period = $POST['Period'];

if (!isset $POST["$Vteam"]) && !isset $POST["$Vscore"]) && !isset $POST["$Hteam"]) && !isset $POST["$Hscore"]) && !isset $_POST["$Period"])) {
$loc = "Error.php"?e=3;
header("Location: " . $loc);
exit(1);
}
echo "Code Passed If<br>";
$dbLink = mysql_connect("localhost", "xxxx", "xxxx") or die("could not connect to database");
echo "Code Passed dbLink<br>";

$result = mysql_select_db("LiveScore") or die("could not select to database");
echo "Code Passed select_db LiveScore<br>";

$sql = "update score set VisitorTeam = '$Vteam', VisitorScore = '$Vscore', $HomeTeam = '$Hteam', HomeScore = '$Hscore', Period = '$Period' where ID = '$id'";
echo "Code Passed sql update score;<br>";

$result = mysql_close($dbLink) or die("query failed");
echo "Code Passed result = mysql_close <br>" ;

$loc = "http://sec.lavaa.net/livescore/ScoreUpdate.php";
header("Location: " . $loc);
echo "Code Passed LOC <br>" ;
exit;
?>

Any ideas on this would be appreaciated.

gottes_tod

try to correct your code

<?php 
//echo "Code Started<br>" ; 
//!! not  $_POST['ID']  but  $_POST['id'] 
// cause in your html
//<input type="text" name="id" size="1"> 
$id = $_POST['id']; 
$Vteam = $_POST['Vteam']; 
$Vscore = $_POST['Vscore']; 
$Hteam = $_POST['Hteam']; 
$Hscore = $_POST['Hscore']; 
$Period = $_POST['Period']; 
// && => || 
if (!isset($_POST["$Vteam"]) || !isset($_POST["$Vscore"]) 
    || !isset ($_POST["$Hteam"]) || !isset($_POST["$Hscore"]) 
    || !isset($_POST["$Period"]) || ($_POST["$Vteam"]=="") 
/** no fields can be empty.. uncomment if you need it..
    || ($_POST["$Vscore"]=="") || ($_POST["$Hteam"]=="") 
    || ($_POST["$Hscore"]=="") || ($_POST["$Period"]=="")
/**/
) 
{ 
$loc = "Error.php"?e=3; 
header("Location: " . $loc); 
exit(1); 
} 
//echo "Code Passed If<br>"; 
$dbLink = mysql_connect("localhost", "xxxx", "xxxx") or die("could not connect to database"); 
//echo "Code Passed dbLink<br>"; 
$result = mysql_select_db("LiveScore") or die("could not select to database"); 
//echo "Code Passed select_db LiveScore<br>"; 
$sql = "update score set VisitorTeam = '$Vteam', VisitorScore = '$Vscore', $HomeTeam = '$Hteam', HomeScore = '$Hscore', Period = '$Period' where ID = '$id'"; 
//echo "Code Passed sql update score;<br>"; 
$result = mysql_close($dbLink) or die("query failed"); 
//echo "Code Passed result = mysql_close <br>" ; 
$loc = "http://sec.lavaa.net/livescore/ScoreUpdate.php"; 
header("Location: " . $loc); 
//echo "Code Passed LOC <br>" ; 
exit; 
?>

roavanet

I made the changes mentioned... Still having problems. When I go into make the changes, when it goes to the Insert program, it just does nothing... Like it is ignoring the code? I have combed through the file and the database and all the Caps are Capped, and etc... Any ideas?

Thanks
John

gottes_tod

ohohoh... sorry but where is your insert code?? is it right construction?? it needs:

$sql = "update score set VisitorTeam = '$Vteam', 
VisitorScore = '$Vscore', $HomeTeam = '$Hteam', 
HomeScore = '$Hscore', Period = '$Period' where ID = '$id'"; 
//!!---
$result = mysql_query($sql) or die("query failed"); 
//!!---
mysql_close($dbLink) or die("failed to close");

if it will not work try debug step by step, say, echo $sql, "select * from VisitorTeam", execute your $sql-query in external mysql-client & so on..
good luck!!

roavanet

I did not think it needed the insert since I am pulling the original record and writing over top of it?

$sql = "update score set VisitorTeam = '$Vteam', VisitorScore = '$Vscore', $HomeTeam = '$Hteam', HomeScore = '$Hscore', Period = '$Period' where ID = '$id'";

John

xblue

Hi John,

I think what s/he was trying to tell you is:

it is not enough to assign the update query to a variable, you need to execute it as well by calling mysql_query($sql).

$result = mysql_query($sql) or die("query failed: ".mysql_error());

(I've inserted the mysql_error because in case your query fails you will get a more meaningful error reflected.)