help w recoding function for register globals off

philosophia

i'm having trouble getting this function



function register($firstname, $middlename, $lastname, $address1, $address2, $address3, $city, $state, $zip, $country, $phone1, $phone2, $intenrmo, $intenryr, $institution, $major, $journalism, $imc, $pmp, $email, $password)

// register new person with db

// return true or error message

{

 // connect to db

  $conn = db_connect();

  if (!$conn)

return "Could not connect to database server - please try later."; 





  // check if firstname is unique 

  $result = mysql_query("select * from user where email='$email'"); 

  if (!$result)

 return "Could not execute query";

  if (mysql_num_rows($result)>0) 

 return "That email address is already in the database - please go back and enter another email address.";




  // if ok, put in db

  $result = mysql_query("insert into user values 

                     ('$userid','$firstname','$middlename','$lastname', '$address1', '$address2', '$address3', '$city', '$state', '$zip', '$country', '$phone1', '$phone2', '$intenrmo', '$intenryr', '$institution', '$major', '$journalism', '$imc','$pmp', password('$password'), '$email', now('$dateregistered'))");

  if (!$result)

return "Could not register you  in database - please try again later.";



  return true;

}

to work with register globals off.

this doesn't seem to work



function register($firstname, $middlename, $lastname, $address1, $address2, $address3, $city, $state, $zip, $country, $phone1, $phone2, $intenrmo, $intenryr, $institution, $major, $journalism, $imc, $pmp, $email, $password)

// register new person with db

// return true or error message

{

 // connect to db

  $conn = db_connect();

  if (!$conn)

return "Could not connect to database server - please try later."; 





  // check if firstname is unique 

  $result = mysql_query("select * from user where email='$_POST['email']'"); 

  if (!$result)

 return "Could not execute query";

  if (mysql_num_rows($result)>0) 

 return "That email address is already in the database - please go back and enter another email address.";




  // if ok, put in db

  $result = mysql_query("insert into user values 

                     ('$userid','$_POST['firstname']','$_POST['middlename']','$_POST['lastname']', '$_POST['address1']', '$_POST['address2']', '$_POST['address3']', '$_POST['city']', '$_POST['state']', '$_POST['zip']', '$_POST['country']', '$_POST['phone1']', '$_POST['phone2']', '$_POST['intenrmo']', '$_POST['intenryr']', '$_POST['institution']', '$_POST['major']', '$_POST['journalism']', '$_POST['imc']','$_POST['pmp']', password('$_POST['password'), '$_POST['email']', now('$dateregistered'))");

  if (!$result)

return "Could not register you  in database - please try again later.";



  return true;

}

can someone please tell me what i'm doing wrong?

thanks

JakesSA

what version you running? also set certain vars to global with in your function

philosophia

4.2.3

can you give me an example of what you mean about setting those var's to global?

this function is part of a larger app, and the only global variables i would like to use are session variables

JakesSA

try using 4.3.

I recently had a similiar error in one of my search engines on a site, when I upgraded to 4.3 and had globlas off, it didnt come up with a error. :eek:

tell me what happens, when you done.

🙂

philosophia

i'm not able to do this, i don't run this particular server, if i did i'd just turn register globals on and avoid this whole problem of having to recode for reg globals =off

jerdo

Ok use the first way that you defined your function, before you put the _POST vars in. Then when you actually call your function you supply the post vars.

function register($firstname, $middlename, $lastname, $address1, $address2, $address3, $city, $state, $zip, $country, $phone1, $phone2, $intenrmo, $intenryr, $institution, $major, $journalism, $imc, $pmp, $email, $password)

// register new person with db

// return true or error message

{

 // connect to db

  $conn = db_connect();

  if (!$conn)

return "Could not connect to database server - please try later."; 





  // check if firstname is unique 

  $result = mysql_query("select * from user where email='$email'"); 

  if (!$result)

 return "Could not execute query";

  if (mysql_num_rows($result)>0) 

 return "That email address is already in the database - please go back and enter another email address.";




  // if ok, put in db

  $result = mysql_query("insert into user values 

                      ('$userid','$firstname','$middlename','$lastname', '$address1', '$address2', '$address3', '$city', '$state', '$zip', '$country', '$phone1', '$phone2', '$intenrmo', '$intenryr', '$institution', '$major', '$journalism', '$imc','$pmp', password('$password'), '$email', now('$dateregistered'))");

  if (!$result)

return "Could not register you  in database - please try again later.";



  return true;

}

Then call it like this:

 register($_POST['firstname'], $_POST['middlename'], $_POST['lastname'], $_POST['address1'], $_POST['address2'], $_POST['address3'], $_POST['city'], $_POST['state'], $_POST['zip'], $_POST['country'], $_POST['phone1'], $_POST['phone2'], $_POST['intenrmo'], $_POST['intenryr'], $_POST['institution'], $_POST['major'], $_POST['journalism'], $_POST['imc'], $_POST['pmp'], $_POST['email'], $_POST['password'])

This is assuming that all those variables came from a form using the post method.
The second way you entered for doing this, you should have gotten an error because you were trying to use variables that shouldn't have existed within the scope of this function.