stupid question, but still need help.

[guerrillase7en]

ok i'm making a small challenge thing and right now here's the code for if they get it right... , but i always get the else statement, i know js1 is 0 in the database can someone please tell me what i'm doing wrong?

<?
$javascript1 = mysql_query("SELECT `js1` FROM users WHERE `username` = '".$_SESSION['username']."'");
if ($javascript1 == 0) {
mysql_query("UPDATE users SET `points`=`points`+88 WHERE `username` = '".$_SESSION['username']."'");
mysql_query("UPDATE users SET `js1`=1 WHERE `username` = '".$_SESSION['username']."'");
}
else
{
echo ("You already beat this challenge.");
}
?>

[xblue]

mysql_query will only return false if the query fails, it does never return the number of rows.

to get the number of records, either use mysql_num_rows() or use COUNT(*) in your query and read the result with one of the mysql_fetch_... functions.

hope this helps,
xblue

[guerrillase7en]

this gets the same thing...

<?
$javascript1 = mysql_query("SELECT `js1` FROM users WHERE `username` = '".$_SESSION['username']."'");
if (mysql_num_rows($javascript1) == 0) {
mysql_query("UPDATE users SET `points`=`points`+88 WHERE `username` = '".$_SESSION['username']."'");
mysql_query("UPDATE users SET `js1`=1 WHERE `username` = '".$_SESSION['username']."'");
}
else
{
echo ("You already beat this challenge.");
}
?>

[xblue]

add some basic debugging statements to find out what is going wrong.

<?
$javascript1 = mysql_query("SELECT `js1` FROM users WHERE `username` = '".$_SESSION['username']."'") or die (mysql_error());
echo mysql_num_rows($javascript1).'<br />';
if (mysql_num_rows($javascript1) == 0) {
    mysql_query("UPDATE users SET `points`=`points`+88 WHERE `username` = '".$_SESSION['username']."'");
    mysql_query("UPDATE users SET `js1`=1 WHERE `username` = '".$_SESSION['username']."'");
} else {
    echo ("You already beat this challenge.");
}
?>

Btw, you don't need to quote column names in your queries.

[examancer]

i think this will work better:

<?

$javascript1 = mysql_query("SELECT `js1` FROM users WHERE `username` = '".$_SESSION['username']."'") or die (mysql_error());

$js_results = mysql_fetch_array($javascript1);

if ($js_results['js1'] == 0) {

mysql_query("UPDATE users SET `points`=`points`+88 WHERE `username` = '".$_SESSION['username']."'");

mysql_query("UPDATE users SET `js1`=1 WHERE `username` = '".$_SESSION['username']."'");

} else {

echo ("You already beat this challenge.");

}

?>

[xblue]

yes you may be right on this. I did not realize that guerrillase7en probably did not want to know if a row exists, but what value the field had.

[guerrillase7en]

thanks, that got it, don't know what i would do without my phpbuilding buddys:-P