looping help...

vaska

i'm in over my head on this one...i just don't know how to structure things...i'm completely lost...i have two separate things that work...but i don't know how to make them work together...

helpos muchos appreciados...jv

<?
$id = $row['id'];

//// if row_count equal zero it prints NOTHING...

$count = mysql_query ("SELECT count(*) FROM comments WHERE '$id'=commid");
$row_count = mysql_fetch_row($count);
if ($row_count[0] == 0) {
print "";

//// if row_count equals anything greater than zero...i want it to exectute a loop...but i don't know how to make this work in here...if it's even possible...

} elseif ($row_count[0] > 0) { 

//// the loop that don't work...i've played with it much...and i put back in much of the code so it might be easier to understand...maybe...

<? do { ?><p><strong><? echo $row_comm['cname']; ?></strong> says...</span><br>
<? echo $row_comm['comment']; ?></p>
<p>&nbsp;&nbsp;&raquo; by <a href="<? echo $row_comm['cemail']; ?>"><? echo $row_comm['cname']; ?></a> on <? echo $row_comm['cdate']; ?></p><?php } while($row_comm = mysql_fetch_array($query_comm));?>; 

} else { 
print ""; } 
?>

cgraz

try this

<?
$id = $row['id'];

$count = mysql_query ("SELECT count(*) FROM comments WHERE commid='$id'") or die(mysql_error()); // you had this backwards
$row_count = mysql_num_rows($count); // mysql_num_rows will let you know how many results were found

   if ($row_count == '0') {
      echo "No results Found";
   } else { 

  while($row_comm = mysql_fetch_array($count)) {

     <p><strong><? echo $row_comm['cname']; ?></strong> says...</span><br>
     <? echo $row_comm['comment']; ?></p>
     <p>&nbsp;&nbsp;&raquo; by <a href="<? echo $row_comm['cemail']; ?>">
     <? echo $row_comm['cname']; ?></a> on 
     <? echo $row_comm['cdate']; ?></p>

<?

// end while loop
      }
?>

Cgraz

vaska

thanks...interesting how you've combined the loops...i get it...

but...it's not working...see code below...jv

<?
$id = $row['id'];
$count = mysql_query ("SELECT count(*) FROM comments WHERE '$id'=commid");
$row_count = mysql_num_rows($count);
if ($row_count == "0") {
echo "";
} else {
while($row_comm = mysql_fetch_array($count)) {

///// IT DOES NOT LIKE THE LINE BELOW...it returns a "parse error"...

<p><strong><? echo $row_comm['cname']; ?></strong> says...<br>

<? echo $row_comm['comment']; ?></p>
<p>&nbsp;&nbsp;&raquo; by <a href="<? echo $row_comm['cemail']; ?>"><? echo $row_comm['cname']; ?></a> on <? echo $row_comm['cdate']; ?></p>
<? } ?>

sgoku01

Maybe because you didn't exit from php??
Put ?> after the while statement:

while($row_comm = mysql_fetch_array($count)) {
?>  // <<-- THERE YOU HAVE IT

<p><strong><? echo $row_comm['cname']; ?></strong> says...<br>

cgraz

You forgot to end the PHP tags. See code below

<?
$id = $row['id'];
$count = mysql_query ("SELECT count(*) FROM comments WHERE '$id'=commid");
$row_count = mysql_num_rows($count);
if ($row_count == "0") {
echo "";
} else {
while($row_comm = mysql_fetch_array($count)) {

///// IT DOES NOT LIKE THE LINE BELOW...it returns a "parse error"...

// end php tag here
?>

<p><strong><? echo $row_comm['cname']; ?></strong> says...<br>

<? echo $row_comm['comment']; ?></p>
<p>&nbsp;&nbsp;&raquo; by <a href="<? echo $row_comm['cemail']; ?>"><? echo $row_comm['cname']; ?></a> on <? echo $row_comm['cdate']; ?></p>
<? } ?>

Cgraz

vaska

hmmm...not working...it's not outputting ANYTHING in the loop...actually...it's outputting as though their ARE results...but where it should output 3 results it only does one and then it doesn't insert any of the results...

the queries to feed the loops...

$query = mysql_query ("SELECT * FROM main WHERE id='$id'") or die ("Yo, it's not working! - Code1A.");
$row = mysql_fetch_array($query);

$query_comm = mysql_query ("SELECT * FROM comments WHERE '$id'=commid ORDER BY cid DESC") or die ("Yo, it's not working! - Code1B.");
$row_comm = mysql_fetch_array($query_comm);

the looping stuff...outputs...

<?
$id = $row['id'];
$count = mysql_query ("SELECT count(*) FROM comments WHERE '$id'=commid");
$row_count = mysql_num_rows($count);
if ($row_count == "0") {
echo "";
} else {
while($row_comm = mysql_fetch_array($count)) { ?>
<p><strong><? echo $row_comm['cname']; ?></strong> says...<br>
<? echo $row_comm['comment']; ?></p>
<p>&nbsp;&nbsp;&raquo; by <a href="<? echo $row_comm['cemail']; ?>"><? echo $row_comm['cname']; ?></a> on <? echo $row_comm['cdate']; ?></p>
<? } ?>

what have i missed?

thanks...jv

cgraz

You still have your query backwards. Here is the format:

SELECT * FROM your_table WHERE field_name = 'value'

You're doing

SELECT * FROM your_table WHERE 'value'=field_name

change

$count = mysql_query ("SELECT count(*) FROM comments WHERE '$id'=commid");

$count = mysql_query ("SELECT count(*) FROM comments WHERE commid='$id'") or die(mysql_error());

By adding mysql_error, you'll know if there was an error executing the query.

You will also want to change

$query_comm = mysql_query ("SELECT * FROM comments WHERE '$id'=commid ORDER BY cid DESC") or die ("Yo, it's not working! - Code1B.");

$query_comm = mysql_query ("SELECT * FROM comments WHERE commid='$id' ORDER BY cid DESC") or die (mysql_error());

Cgraz

MeX

it makes no difference:

SELECT FROM your_table WHERE field_name = 'value';
SELECT FROM your_table WHERE 'value' = field_name;

both are alright!!!

ceeyaa.MeX

MeX

but try something like this:

<?
$result = mysql_query ("SELECT * FROM comments WHERE '$id'=commid");

if (mysql_num_rows($result)) {
  while($data = mysql_fetch_array($result)) {
    echo "<p><strong>" .  $data['cname'] . "</strong> says...<br>";
} else {
  echo "NOTHING FOUND";
}
?>

ceeyaa.MeX

cgraz

Since you're using count, don't you have to access the variables like this:

$data[count(cname)];

rather than

$data["cname"];

Cgraz

MeX

i think, if you make

$result = mysql_query(SELECT COUNT(*) FROM table_name);

you just have one field with the count-value, you HAVE NO data then!

you can't make a $data = mysql_fetch_array($result);
and try to get $data['field_name'];

ceeyaa.MeX

vaska

athough it might not be the most logical solution...i have it working to my specifications...the user selects whether they want users to respond...so doing the count in that situation is extraneous...

it only is a problem before the first response...but i can live with this for now...although the count would be nice...it's clearly not working properly...

this is what i'm ending up with...moved things around...

<?
$id = $row['id'];
//$count = mysql_query ("SELECT count(*) FROM comments WHERE commid='$id'");
//$row_count = mysql_num_rows($count);
if ($row[comm] == '0') {
echo "";
} else {
do { ?>
<p><strong><? echo $row_comm['cname']; ?></strong> says...<br>
<? echo $row_comm['comment']; ?></p>
<p>&nbsp;&nbsp;&raquo; by <a href="mailto:<? echo $row_comm['cemail']; ?>"><? echo $row_comm['cname']; ?></a> on <? echo $row_comm['cdate']; ?></p>
<? } while($row_comm = mysql_fetch_array($query_comm))  ?>