Stupid if statement...

[VooDooRT]

This is really ticking me off. I'm pretty sure it's accurate. It worked yesterday, but it doesn't work today...It's always displaying "Join Newsletter"

    $result = @mysql_query("SELECT * FROM members WHERE username = \"$username\"");
  $row = mysql_fetch_array($result);
  $email = $row[email];

  echo("
<table border='0' cellpadding='0' cellspacing='0' style='border-collapse: collapse' bordercolor='#111111' width='100%' id='AutoNumber1'>
  <tr>
    <td width='100%' align='center'>$fontString
	<b>Member's Menu</b> <table width=95% border=0 cellspacing=0 cellpadding=0></td>
  </tr>
  <tr>
    <td width='100%' align='center'>$fontString <a href='member_actions.php?action=info_edit'>Change 
    Info</a> | <a href='member_actions.php?action=pass'>Change Password</a> |
    <a href='member_actions.php?action=edit_record'>Change Stats</a> | <a href='logs.php'>View Logs</a> | <a href='member_actions.php?action=chat'>Goto Members Chat</a>
	");
				  $result = @mysql_query("SELECT * FROM nl_member WHERE email = \"$email\"");
 					 $test = @mysql_fetch_array($result);
  							if($test[email] == NULL) 
									{
										echo("
										 | <a href='add_nl.php'>Join Newsletter</a>");
									}
							else {
										echo("
										 | <a href='remove_nl.php'>Quit Newsletter</a>");
									}

	echo("
</td>
  </tr>
</table>
<br>
  ");

[DigitalExpl0it]

hows this?

<?
$result = @mysql_query("SELECT * FROM members WHERE username = '$username'");
  $row = mysql_fetch_array($result);
  $email = $row[email];
?>

<table border='0' cellpadding='0' cellspacing='0' style='border-collapse: collapse' bordercolor='#111111' width='100%' id='AutoNumber1'>
  <tr>
    <td width='100%' align='center'><? echo $fontString; ?>
    <b>Member's Menu</b> <table width=95% border=0 cellspacing=0 cellpadding=0></td>
  </tr>
  <tr>
    <td width='100%' align='center'><? echo $fontString; ?> <a href='member_actions.php?action=info_edit'>Change 
    Info</a> | <a href='member_actions.php?action=pass'>Change Password</a> |
    <a href='member_actions.php?action=edit_record'>Change Stats</a> | <a href='logs.php'>View Logs</a> | <a href='member_actions.php?action=chat'>Goto Members Chat</a>
<?

              $result = @mysql_query("SELECT * FROM nl_member WHERE email = '$email'");
                  $test = @mysql_fetch_array($result);
                          if($test["email"] == "") {
                                    echo"| <a href='add_nl.php'>Join Newsletter</a>";
                                } else {
                                    echo "| <a href='remove_nl.php'>Quit Newsletter</a>";
                                }
?>
</td>
  </tr>
</table>

[Weedpacket]

What DigitalExpl0it said; I'd also suggest changing the query: if all you need is to see if it's there, you don't need to return the entire row.

$result = @mysql_query("SELECT COUNT(*) FROM nl_member WHERE email = \"$email\"");
$test = @mysql_fetch_row($result);
if($test[0] == 0)  {
	echo("\n| <a href='add_nl.php'>Join Newsletter</a>");
}
else {
	echo("\n| <a href='remove_nl.php'>Quit Newsletter</a>");
}

Of course, if you're using anything from the $test array (gotcha!) further on, ignore this suggestion.

[Mce]

I'd have to agree that using count() is a better way to go, but when using count() don't you have to use a group by clause?

-Mce

[examancer]

you can use count with a group by claus, but its not required.

[Mce]

Hmmmn...There must be some condition where you can't because I always seem to get SQL errors complaining that there's no group by clause when I don't put one in.

Any ideas on why?

-Mce

[Weedpacket]

Originally posted by Mce
Hmmmn...There must be some condition where you can't because I always seem to get SQL errors complaining that there's no group by clause when I don't put one in.

You can't use an aggregate function (like COUNT or MAX) if there are other fields you're selecting - unless you use GROUP BY on those fields so that all the records with the same values for those fields are grouped together for aggregating.

[VooDooRT]

I've tried both and they are both coming up as me not being joined. Ideas?

[VooDooRT]

I've tried
if($test[email] == NULL)
if($test[0] == NULL)
if($test[email] == 0)
if($test[0] == 0)

I've even tried mysql_num_rows($result) == NULL and mysql_num_rows($result) == 0 and NOTHING will work.

ARGH!

[The_Chancer]

What do you get when you echo $test[email] for both those with and without a subscription to the newsletter ? Do you get the E-Mail address... ?

[VooDooRT]

figured it out finally. I didn't register a global...ARGH!

It's always something simple ya know...

[The_Chancer]

Just had the same thing.... so bloody stupid... now another part of my code fails, just as I thought it was almost all working... d'oh..