Help with function

7thgencivic_com

I created this function...

	function countRows($table) {
		$row_count = mysql_query("SELECT COUNT(1) FROM $table");
		$numOfRows =  mysql_num_rows($row_count);
		printf("$numOfRows");	
		//mysql_free_result();
		}

to return the amount of rows in a given db. Problem is that it always returns 1. What is the problem?
This is how I call it...

<?echo countRows("parts_list") ?>

Derek

Mce

Ok the problem is that you are telling count to return 1.

change the query to: (this assumes that you have a field called id in your table and that your table is name mytable for sake of example. You can use any fieldname from your table to get the desired effect) Also you prob should add a where clause to define the result set it's actually counting. the group by goes after the where clause.

$stmt = "select count(*) from table where blah='blah' group by id";
$row_count = mysql_query($stmt);

Originally posted by 7thgencivic.com
I created this function...
	function countRows($table) {
		$row_count = mysql_query("SELECT COUNT(1) FROM $table");
		$numOfRows =  mysql_num_rows($row_count);
		printf("$numOfRows");	
		//mysql_free_result();
		}
to return the amount of rows in a given db. Problem is that it always returns 1. What is the problem?
This is how I call it...
<?echo countRows("parts_list") ?>
Derek [/B]

milind24

ok , first u change this row as

$row_count = mysql_query("SELECT COUNT(*) FROM $table");

And what about connection handler , you have not passed it as variable to function or defined it as global ? for connect todatabase ?

Rohan_Hill

Also instead of

printf("$numOfRows");

you should use

return $numOfRows;

7thgencivic_com

ok...

select count(1) or select count(*) returns the same number of rows. 1 just means to use column 1 for the count.

THe connection has already been established.

THere is no need for a where or a group. It's just excess SQL processing that is unneccessary.

THe SQL is fine, it's the function that is wrong.

I have also tried the return statement instead of printing. Same deal.

Any other thoughts?

7thgencivic_com

well, i figured it out. was my sql statement after all. :o
i was trying to return the number of rows and the rows will always be 1 with a count. I was already getting the result in the sql, so I just needed to output that.

	function countRows($table) {
		$rows_count = mysql_query("SELECT COUNT(id) as thecount FROM $table");
		$row = mysql_fetch_array($rows_count);
		$thecount = $row["thecount"]; 
		return $thecount;	
		mysql_free_result();
		}