Script worked, now doesnt

[mdj]

Hi All.

Yesterday before i went to bed i was well chuffed because i got this little script working. (newbie)

But now when i try to use it i get the error query was empty!

The form that posts the data is below, plus the code it posts it to, any ideas why its now not working???

echo '<form action="activate.php" method="post" name="activate" id="activate">

<input name="username" type="text" id="username">
<input name="code" type="text" id="code">
<input type="submit" name="Submit" value="Submit">
</form>';

---

<?php require_once('Connections); ?>

<?php
// Check activation code.
// Create variables from URL.

$username = $HTTP_POST_VARS['username'];
$code = $HTTP_POST_VARS['code'];

$sql = mysql_query("UPDATE customers SET activated='1' WHERE username='$username' AND randc='$code'");

mysql_select_db($database_smslist, $smslist);
$sql = mysql_query($insertSQL, $smslist) or die(mysql_error());

$sql_doublecheck = mysql_query("SELECT * FROM customers WHERE username='$username' AND randc='$code' AND activated='1'");
$doublecheck = mysql_num_rows($sql_doublecheck);

if($doublecheck == 0){
echo "<strong><font color=red>Your account could not be activated!</font></strong>";
} elseif ($doublecheck > 0) {
echo "<strong>Your account has been activated!</strong> You may login below!<br />";
}

?>

[nnichols]

When posting code please put it between [ PHP][/code] tags as it makes it much easier to read!!

The problem is with -

$sql = mysql_query($insertSQL, $smslist) or die(mysql_error());

but you don't have a sql string in a variable "$insertSQL".

When writing code it is good practice to structure it like this -

$db = mysql_connect('','','') or die('MySQL error: ' . mysql_error());

mysql_select_db($db_name) or die('MySQL error: ' . mysql_error());

$sql = "SELECT * FROM tbl_name";

$res = mysql_query($sql, $db) or die('MySQL error: ' . mysql_error() . '<br>Query: ' . $sql);

It makes it much easier to track errors.

Assuming that you are storing the "activated" data in a TINYINT - it should not be 'quoted' although it won't cause errors with MySQL at the moment

Hope this helps 😉