Array storage.. data there but not there!

ecg

I think I'm having a bad day... but here goes...
my script
1) retrives data from the file
2) displays it
3) updates it

the first 2 work... but I have two different updates.. 1 to a temp table and another back to the file. The temp table works and the file doesn't. They do exactly the same thing (except for the filename). My problem seems to be with the array... it doesn't have data...

 //Actions  

(psuedo code) if (button pressed  == "save") {
$errmsg = SaveData($ID, $Info);
}   else if (buttonpressed == "temp") {
$ErrMsg =SavetempData($Info, $ID);   } 

 //first display.... 
$ConObj = ConnectDatabase();  

$Query = pg_query("Select * from myfilename;");
if (pg_num_rows($Query) > 0) {

for($i = 0 ; $i < pg_num_rows($Query); $i++) {
	$Row = pg_fetch_object($Query, $i);
	$Info[$i]["id"] = $Row->ID;
	$Info[$i]["name"] = $Row->Name;
	}
}
pg_close($conObj);

function SavetempData($Info, $ID){
$ConObj = ConnectDatabase();  

foreach($Info as $array){
	$ID = $array["id"];
	$Name = $array["name"];
	$sSQL = "update mytempfile set Name = $Name where ID = $ID";
	ExecuteQuery($sSQL);
	}
pg_close($conObj);
}

function SaveData($ID, $Info){
$ConObj = ConnectDatabase();  

foreach($Info as $array){
	$ID = $array["id"];
	$Name = $array["name"];
	$sSQL = "update myfilename set Name = $Name where ID = $ID";
	ExecuteQuery($sSQL);
	}
pg_close($conObj);
}

Now if neither worked I'd figure that I had to populate the array first... but temp works and save doesn't!!

Any ideas would be appreciated!!
Thanks
Beth

tomhath

I assume this was a typo on your post, it doesn't look like it would compile with the extra space between "button" and "pressed".

if (button pressed  == "save") {

I'd also make the parameter lists consistent between these two functions (shouldn't matter, but this is asking for bugs):

function SaveData($ID, $Info){
...
function SavetempData($Info, $ID){

I suspect the problem is in the query itself. You don't check to see if it succeeded, it seems like $Name should be in quotes since I assume its a character value (don't know why it would appear to work in one place and not the other, probably something else is faking you out):

$sSQL = "update myfilename set Name = $Name where ID = $ID";

ecg

Thanks for your reply :-)

the 'button pressed' was kinda psuedo code as it really uses Javascript etc and thats not the issue....

I know that it gets to the function in both cases.. but its a matter of whether or not the array ($Info) has any data. I've tried a

print_r($Info);

in both functions
I thought $Info was populated on entry to the SavetempData function... but I can't see it... and I can't figure out how its getting the data...
The only thing I can see is that the temp button is part of the form that displays $Info...??

Can I change my q slightly?
I need to save the data on a form into a temp table while I go to another page to get more info. On return I populate the screen from the temptable... and then I want to save to the file...

but if I do the display data first it means the screen values get lost...
and if I do the if (button = save) first it means that I lose the values...

I seem to be going round in circles here... (my 4th cup of coffee didn't help)
:-(
Thanks

tomhath

I can only guess that $Info is getting coming in through a POST or GET from one form but not the other, are you sure it gets put on the form somewhere after the temp file is written and you are gathering more information?

The code doesn't make a lot of sense, it's passing $ID into the functions but not using the parameter's value. And I don't understand the temp file, how do you ever get back to the rows that were written to it?

I suspect what you really need here are either sessions, cookies, or hidden form fields to maintain some information (called "state") across pages. Temp tables are okay to use if you also keep a key into the table (with a session, cookie, or hidden field...)

ecg

Thanks again for your reply.. I've been trying to keep it simple as the filenames are ugly (I didn't create the D😎

I can get rid of the $ID in my passing to functions if you like... in reality I pass a few more values as well and check them against each other...

I choose to use a temp table as I need to save up to 10 rows which 4 values each...
passing as a hidden value didn't seem to be a good idea. (and I already pass one of the ids through)
I just tried a session variable.. but it created $Info[0] which interferred with my processing
and I would have to manually unset it cause my app has 10 pages and I only want it around on this one page...
*and I know nothing bout cookies ... yet..

Could a still open database connection do it?
if so I don't understand why the print_r shows nothing...

The only thing on the form is that the temp button is in a table with the $Info data and the save button is in another table?
I don't GET or POST this data....

any ideas??
Thanks
Beth