ARG! simple code driving me NUTS whats going on?

gte806e

Ok im basically trying to see if my userId has been assigned a value if so do NOT run login() and print statments. Yet every test i've tried doesnt work it rues them each time. What is going on?

i've tried the following tests:

if(empty($userId))
if(!$userId)

and the one below help!!! what am I doing wrong.

<?php
session_start();
session_register("userId");

function login($user){
   global $userId;
   if($user)
      $userId = $user;
}
?>

<html><body>
<?php
	global $userId;

if($userId == ""){
	login($user);
	print("<form action=\"ses.php\">");
	print("UserName <input type=\"text\" name=\"user\"><br>");
	print("Password <input type=\"password\" name=\"password\"><br>");
	print("<input type=\"submit\"></form>");
}
print("UserID: ".$userId);

?>
</body></html>

swon

Do you have set register_globals to 'On' in the php.ini file?

gte806e

I'm not sure its a remote server. If they do not, what would be the best way for em to handle it?

diego25

Try this in a PHP script:

print 'register_globals = ' . ini_get('register_globals') . "\n";

and tell us if you have register_globals on or off...

Diego

gte806e

Looks liek they are on.

Thanks,

Jesse

Weedpacket

Instead of $userId and
session_start();
session_register("userId");

Try $_SESSION['userId'] and
session_start();

You won't need to say global $_SESSION in the login function.

Then to test to see if it's there or not,
if(empty($_SESSION['userId']))

If the version of PHP you're using is older than 4.1 (echo phpversion() to see if you don't know), then you'll want to use $HTTP_SESSION_VARS instead of $_SESSION and use global $HTTP_SESSION_VARS in the login() function.

You don't need the second "global $userId" because you're not inside a function.

And one last point: because your call to login() is placed inside the block controlled by the $userId=="" test, it will only run when $userId=="".