might have a simple solution

itworks

i have this function:

function frontProducts() {
                $sql = "SELECT * FROM products ORDER BY RAND() LIMIT 0,6";
                $rs=$this->bd->executeSQL($sql);

            $n=0;
            while(mysql_fetch_row($rs) && n<3) {
                    echo "<br>";
					echo "<center><img src=\"images/".mysql_result($rs, $n, "foto")."\"><br><br>";
					echo "".mysql_result($rs, $n, "category")."<br>";
					echo "<a href=\"index.php?page=product&cod=".mysql_result($rs, $n, "cod")."\">".mysql_result($rs, $n, "model")."</a><br>";
					echo "<b>".mysql_result($rs, $n, "price")."€</b><br>";
					echo "<br>";
                    $n++;
            }
    }

it's called into a table in the main page of a online store i'm making.

the problem is that the way it is done, it shows 6 products each one below the other.

i have no idea how to make them appear in 2 rows with 3 products in each row?

thanks in advance

jpmoriarty

your problem is all those 's: if you take them out, and then put in something like:

if ($n % 3 == 0)
  echo "<br><br>";

then if $n / 3 has no remainder (ie $n = 3, 6, 9 etc) then it prints out the breaks. Otherwise, it'll give you the next image (which will make it next to the previous one).

Hope that helps

itworks

either i'm doing something wrong or i didn't get your idea 'cause now it prints the products still one below the other but with the product name, model and price after the foto instead of below the foto (that's the reason of the 's).

would you be kind enough to show me the modifications you said inside the piece of code i gave you so i can see it more clearly?

thanks in advance.

jpmoriarty

you cant break a line to write the text below the photo and then jump back up to put in another photo. That's just not how html works.

However, you could use a table (it sounds like relatively tabulated data that you're using). something like...

  echo "<table>\n";
  $n = 0;
  while(mysql_fetch_row($rs))
  {
     if ($n % 3 == 0)
       echo "<tr>\n";
     echo "<td><img src=\"".$imagename."\"><br>\n";
     echo $text_underneath;
     echo "</td>";
     $n++;
     if($n % 3 == 0)
     {
       echo "</tr>\n";
       $n = 0;
     }
   }
  echo "</table>\n";

Just put your bits of code to replace my "simplified" bits and that should work.

Also, it's always a good idea to make sure you can do the HTML for something before you start worrying about doing the PHP for it - if the PHP is generating the HTML and you're not sure what HTML you want to achieve, then you're giving yourself a rather tricky task. ALWAYS work out the HTML, then work out how you can make your PHP generate it automatcially - saves a lot of time in the end.

If that doesnt work or any other queries, then just ask.

itworks

i must be doing it the wrong way.

it messes the whole thing and nothing appears in screen.
i know it must be done using tables, i just don't know how.

i guess i could make a table the way i want and call that script in each cell for 1 random product, but there is a possibility that at some point i'll have repeated products.

itworks

Originally posted by itworks
i have this function:
function frontProducts() {
 $sql = "SELECT * FROM products ORDER BY RAND() LIMIT 0,6";
 $rs=$this->bd->executeSQL($sql);

 $n=0;
 while(mysql_fetch_row($rs) && n<3) {
 echo " ";
					echo "<center><img src=\"images/".mysql_result($rs, $n, "foto")."\"> ";
					echo "".mysql_result($rs, $n, "category")." ";
					echo "<a href=\"index.php?page=product&cod=".mysql_result($rs, $n, "cod")."\">".mysql_result($rs, $n, "model")."</a> ";
					echo "".mysql_result($rs, $n, "price")."€ ";
					echo " ";
 $n++;
 }
 }
it's called into a table in the main page of a online store i'm making.

the problem is that the way it is done, it shows 6 products each one below the other.

i have no idea how to make them appear in 2 rows with 3 products in each row?

thanks in advance [/B]

IS THIS IMPOSSIBLE?!?!😕 😕

jpmoriarty

OKay we're going to have to make this as blatant as we can:

function frontProducts() {
                $sql = "SELECT * FROM products ORDER BY RAND() LIMIT 0,6";
                $rs=$this->bd->executeSQL($sql);

            $n=0;
            echo "<table>"
            while(mysql_fetch_row($rs))
// dont know why you had a && n<3 in here - the variable is called $n, but even then it would only make the while run three times - it's [b]still[/b] the <br>'s that are spacing the thing out - I dont know how you intended to do it without a table...
                {
                        if ($n  == 0)
                           echo "<tr>";
                        echo "<td>";
                        echo "<center><img src=\"images/".mysql_result($rs, $n, "foto")."\"><br><br>";
                        echo "".mysql_result($rs, $n, "category")."<br>";
                        echo "<a href=\"index.php?page=product&cod=".mysql_result($rs, $n, "cod")."\">".mysql_result($rs, $n, "model")."</a><br>";
                        echo "<b>".mysql_result($rs, $n, "price")."€</b><br>";
                        $n++;
                        echo "</td>";
                        if ($n  == 0)
                        {
                          $n = 0;
                          echo "</tr>";
                        }
                        $n++;
                }
                echo "</table>";
        }

IF that doesnt work, then please post a response which is of more use than "blank screen" - it should at least give some errors, or output some HTML.

You will also notice that all I've done above is use the code that i posted before and inserted your code into it in the bits I told you to (just slightly modified to add the start and end tables - realised there was no need for the modulus function). If there's any part you dont understand then please shout.

itworks

i'm sorry for the trouble i am causing you with my inexperience.

the script didn't work, i get a blank page (no output).

i'm beggining to think that either this is not possible or it's to much complicated for mortals.

abnfire

try this:

function frontProducts() {
$sql = "SELECT * FROM products ORDER BY RAND() LIMIT 0,6";
$rs=$this->bd->executeSQL($sql);

            while($row = mysql_fetch_array($rs)) {
                    echo "<br>";
                    echo "<center><img src=\"$row['foto']\"><br><br>";
                    echo $row[category]."<br>";
                    echo "<a href=\"index.php?page=product&cod=".$row['cod'])."\">".$row[model]."</a><br>";
                    echo "<b>".$row[price]."€</b><br>";
                    echo "<br>";
            }
    }

itworks

i've not tried your piece of code yet 'cause i think, at first look, that it doesn't solve my problem.

see, i'm not having problems selecting 6 random products from the products tables and showing them. i'm having trouble formating it so that they appear in a table with 2 rows with 3 columns instead of the 6, one below the other.

but thanks anyway.

jpmoriarty

if the code i've given you is not giving an output at all then it's a problem with the way you're calling the function. If you strip it out of a function (lets solve one problem at a time before we start creating new ones) and just try it on a page by itself (obviously containing any connections ect that you need) then you should get at least something out.

I really am trying my best to help you out here, but you've got to meet me half way! if it's doing nothing (what i gave you last time) then try taking it all out and just putting in a "echo 'Test page'" line instead - if you dont even get that then it's definitely a problem with you calling the function.

Whihc has just made me think - you are calling the function aren't you? You realise that it wont do anything until you call it?

itworks

i must remind you that the first piece of code i've posted here worked. so the function is beeing called and properly called, the script you gave me must be broken is someway and that's why it doesn't output nothig.

i'm very inexperienced so maybe it's just me, but defenetly not on calling the function, maybe implementing it.

anyway i've thought of a solution to my problem by designing the table and instead of selecting 6 random products, i select one from a different category to each of the table's cell.

i was just finding out an easier way to do this all in one function with the table formating and all, but maybe it is too much complicated.

thanks for all the help you gave me, you've been more than a pall.

😉

feldon23

When you say it "doesn't work", I assume you are loading the page and then looking at "View Source" to see what HTML is being generated? That should give you plenty of clues. Can you post an example of the HTML that's being generated?

itworks

i already had the problem solved by doing what i said in my last post by i went back to give it another shot, but i'm not sure about what you want.

the script that call the function is called within the index.php page.

do you want the html code generated by the index.php page or the one that is beeing callled and that call the function?

feldon23

I mean run some of the "problem" scripts that other people have suggested and look in View Source in your web browser and see if anything is coming through, even if you just get a blank space in the browser.

itworks

i don't use that technique, i usually try finding the error in the script if i
can't figure out by watching what is displayed in the browser.

do you use this, is it a common technique? in what way does it help?

in this specific case i get the code of the table i've designed and in which
should be displayed the results and then when it comes to the calling the
function part it doesn't show in the view source, that's the blank part.

anyway it would be great to get this done the way i wanted before, but
i've solved it now in another way but that has the same results i was looking for.