inserting problems

cybersounds

I'm finding that while the following code allows me to successfully connect with, select, and insert records into my database, the records turn out blank (new rows appear but there is no data in the rows). I'm a newbie, and assume that I'm leaving out a vital step(s). Could someone please look at my code and let me know how I'm screwing this up? Thanks!!!

<?php

$connect=mysql_connect("localhost","root");
if (!$connect) { print "ERROR: " . mysql_error() . "\n"; }
$select=mysql_select_db("jbierhoff",$connect);
if (!$select) { print "ERROR: " . mysql_error() . "\n"; }

mysql_query ("INSERT INTO webform (fullname, email, city, state, phone, extension, service, review, reviewyear,
reviewduemonth, reviewdueday, reviewdueyear, comments)
VALUES ('$POST[fullname]', '$POST[email]', '$POST[city]', '$POST[state]', '$POST[phone]', '$POST[extension]',

'$POST[service]', '$POST[review]', '$POST[reviewyear]','$POST[reviewduemonth]', '$POST[reviewdueday]', '$POST[reviewdueyear]', '$_POST[comments]') ");

<form action="processor.php" method="post" onSubmit="return checkData()" name="form">
<table width="600">
<tr>
<td class="bodytext" align="right"><b>Name:</b></td>
<td><input type="text" name="fullname" size="35" /></td>
<td class="bodytext" align="right"><b>Email:</b></td>
<td><input type="text" name="email" size="32" /></td></tr>
<tr><td class="bodytext" align="right"><b>City:</b></td>
<td><input type="text" name="city" size="35" /></td>
<td class="bodytext" align="right"><b>State:</b></td>
<td><input type="text" name="state" size="2" /></td></tr>
<tr><td class="bodytext" align="right"><b>Phone:</b></td>
<td><input type="text" name="phone" size="15" maxlength="15" /></td>
<td class="bodytext" align="right"><b>Extension:</b></td>
<td><input type="text" name="extension" size="5" maxlength="5" />
    <font face="verdana" size="2" color="darkred"></font><font face="verdana" size="1"

color="darkred">MANDATORY FIELDS</font>
</td>
</tr>
</table>

<table cellspacing="10" width="700">
<tr>
<td class="bodytext" valign="top" align="right">
<table align="right"><td align="left" class="bodytext">
<b>Service(s) of interest:</b><br>
<INPUT TYPE=CHECKBOX NAME="service" VALUE="Accounting/Auditing">Accounting/Auditing<br>
<INPUT TYPE=CHECKBOX NAME="service" VALUE="Tax Services">Tax Services<br>
<INPUT TYPE=CHECKBOX NAME="service" VALUE="Management Advisory">Management Advisory<br>
<INPUT TYPE=CHECKBOX NAME="service" VALUE="Investment Planning">Investment Planning<br>
<INPUT TYPE=CHECKBOX NAME="service" VALUE="Peer Review">Peer Review</td></table></td>

<table align="left"><td align="left" class="bodytext">
<b>Peer Review type if applicable:</b><br>
<input type="radio" name="review" value="System">System Review<br>
<input type="radio" name="review" value="Engagement">Engagement Review<br>
<input type="radio" name="review" value="Report">Report Review<br>

<b>Peer Review Year:</b>
<select name="reviewyear">
<option selected>2003
<option>2004
<option>2005
<option>2006
<option>2007
<option>2008
</select><br>

<b>Due Date:</b>
<select name="reviewduemonth">
<option selected>January
<option>February
<option>March
<option>April
<option>May
<option>June
<option>July
<option>August
<option>September
<option>October
<option>November
<option>December
</select>

<tr>
<td align="center" colspan="4"><br>
<textarea name="comments" class="bodytext" rows="5" cols="75">Include any questions or comments here.</textarea>
<br></td></tr>

</form>

jpmoriarty

dont know where you got $_POST from : my manual says to use $HTTP_POST_VARS["variable"] - so you'd want yours to read:

mysql_query ("INSERT INTO webform (fullname, email, city, state, phone, extension, service, review, reviewyear, 
reviewduemonth, reviewdueday, reviewdueyear, comments) 
VALUES ('$HTTP_POST_VARS[\"fullname\"]', '$HTTP_POST_VARS[\"email\"]', '$HTTP_POST_VARS[\"city\"]', '$HTTP_POST_VARS[\"state\"]', '$HTTP_POST_VARS[\"phone\"]', '$HTTP_POST_VARS[\"extension\"]', 
'$HTTP_POST_VARS[\"service\"]', '$HTTP_POST_VARS[\"review\"]', '$HTTP_POST_VARS[\"reviewyear\"]','$HTTP_POST_VARS[\"reviewduemonth\"]', '$HTTP_POST_VARS[\"reviewdueday\"]', '$HTTP_POST_VARS[\"reviewdueyear\"]', '$HTTP_POST_VARS[\"comments\"]') ");

You'll also notice that i think you have to enclose them with quotes, so i've put in escaped versions of those too. Hope that helps

cybersounds

Thanks for the suggestion! I plugged in your suggestion, but I get this error now:

Parse error: parse error, unexpected T_CHARACTER, expecting T_STRING or T_VARIABLE or T_NUM_STRING in C:\Program Files\Apache Group\Apache2\htdocs\jabcpa\contact.php on line 138

Any idea of what might be causing this?

Thanks in advance,
cybersounds

jpmoriarty

well that depends on what's in your contact.php file - but the error will be on line 138 of that (check things like ending lines with ; that sort of thing).