agh these bracets are killing me! what the heck is wrong?

itandme

Hi!

I am doing a little newsletter list for my website. Its made so that the user can enter his/her email in $email, and then úse the checkboxes $action to choose to sub or unsubscribe.

This is the code, and it ALWAYS gives me error msg on line number 18! (which is the "header("Location: mailinglist_index.php?page=subscribed");" line under the insert query.

I am pretty sure i have not got all those {} bracets right.

Annyone? Please 😕

mysql connections comes here.... 
$check = "select email from newsletter where email = $email";
$check_result = mysql_query($check)
		or die("Can't execute check e-mail address.");
$check_num = mysql_num_rows($check_result);

if ($action == sub) {
if ((!$email || !ereg(".+\@.+\..+", $email)) || (!ereg("^[a-zA-Z0-9_@.-]+$", $email))) {
header("Location: mailinglist_index.php?page=emailerror");
} else {
if ($check_num == 0) {
$sql = "INSERT into newsletter (email,date) VALUES ('$email',now());
$insert = mysql_query($sql) or die (mysql_error());
header("Location: mailinglist_index.php?page=subscribed");
}
else {
header("Location: mailinglist_index.php?page=match");
}
}
}
if ($action == unsub) {
if (!$check_num == 0) {
$sql = "DELETE FROM newsletter WHERE email = $email";
$outsert= mysql_query($sql) or die (mysql_error());
header("Location: mailinglist_index.php?page?=unsubscribed");
else {
header("Location: mailinglist_index.php?page=nomach");
}
}
}
?>

xblue

I love the syntax highlighting ...
you missed a closing doublequote in this line

$sql = "INSERT into newsletter (email,date) VALUES ('$email',now());

if there are more problems with unmatched bracket, indenting the code often helps.

itandme

coughs.. ehrm... yeah.. i know that.. 😃

thankyouverymuch!

now i get a error message involving the email variable.

if i for example submit the email viktorhs@swipnet.se then i get a error sáying "You have an error in your SQL syntax near '@swipnet.se' at line 1"

er?? WHAT?

I happend to know that the error comes from this code, as i identified it with diffirent error messages:

$check_result = mysql_query($check)
		or die(mysql_error());

😕

xblue

😃
if you want to pass a non-numeric value to mysql, enclose it in singlequotes as you do in your insert query, but not in the select and delete queries.

itandme

WHAT? Say that again please: What is causing the problem?

Thanks 😃

Char

In order to put a non-numeric value into SQL (ex. an email address) you need to enclose it in single quotes.

For example, your code is:

$sql = "DELETE FROM newsletter WHERE email = $email";

but in order for it to work, it should be:

$sql = "DELETE FROM newsletter WHERE email = '$email'";

Note the single quotes around $email. This needs to be done for your select query as well.

Charlotte Genevier
Webligo Group
http://www.webligo.com