Code

[LukeO]

Hey there, could someone look over this code? I know there are a couple of errors in there but I just cant get them.

<?php 

@mysql_connect(localhost, user, password) or die("ERROR--CAN'T CONNECT TO SERVER"); 
@mysql_select_db("database") or die("ERROR--CAN'T CONNECT TO DB"); 

$limit        = 25;                  
$query_count    = "SELECT users FROM table";      
$result_count    = mysql_query($query_count);       
$totalrows    = mysql_num_rows($result_count);  

if(empty($page)) 
    $page = 1; 


$limitvalue = $page * $limit - ($limit);  
$query     = "SELECT * FROM table LIMIT $limitvalue, $limit";           
$result    = mysql_query($query) or die("Error: " . mysql_error());  

if(mysql_num_rows($result) == 0) 
    echo("Nothing to Display!"); 

$bgcolor = #E0E0E0; // light gray 

echo("<table>"); 

while($row = mysql_fetch_array($result)){ 
    if($bgcolor == #E0E0E0) 
        $bgcolor = #FFFFFF; 
    else 
        $bgcolor = #E0E0E0;      

echo("<tr bgcolor=".$bgcolor.">\n<td>"); 
echo($row[users]); 
echo("<td>\n\<td>"); 
echo($row[usersID]); 
echo("<td>\n</tr>"); 
} 

echo("</table>"); 

if($page != 1){  
    $pageprev = $page--; 

    echo("<a href=\"$PHP_SELF&page=$pageprev\">PREV</a>&nbsp;");  
}else 
    echo("PREV&nbsp;"); 

$numofpages = $totalrows / $limit;  

for($i = 1; $i <= $numofpages; $i++){ 
    if($i == $page) 
        echo($i."&nbsp;"); 
    else 
        echo("<a href=\"$PHP_SELF&page=$i\">$i</a>&nbsp;");  


if(($totalrows % $limit) != 0){ 
    if($i == $page) 
        echo($i."&nbsp;"); 
    else 
        echo("<a href=\"$PHP_SELF&page=$i\">$i</a>&nbsp;"); 

if(($totalrows - ($limit * $page)) > 0){ 
    $pagenext     = $page++; 

    echo("<a href=\"$PHP_SELF&page=$pageprev\">NEXT</a>");  
}else 
    echo("&nbsp; NEXT ".$limit);  

mysql_free_result($result); 

?>

[eoghain]

What are the errors that this generates?

[LukeO]

At the moment a parse error.

Thank you!

Luke

[[deleted]]

And which parse error is that?

Quote the error, we don't have the time/desire to try to re-create your error...

[[deleted]]

Nevermind, just pasting it into a syntax-aware editor shows that you are not quoting any of your strings.

As a side note:
Always use curlybrackets for the IF statements, all other syntaxes are too confusing, you will mess up.

[LukeO]

Nevermind, just pasting it into a syntax-aware editor shows that you are not quoting any of your strings.

Sorry, I dont understand 😕 I am a little new at this and really cant work out whats happening.

All it says is- Parse error: parse error in /home/2pol/public_html/cat.php

Again, thank you for any light you can shed on this 🙂.

Luke

[eoghain]

Your problem is here:

if(mysql_num_rows($result) == 0) 
        echo("Nothing to Display!"); 

$bgcolor = #E0E0E0; // light gray 

echo("<table>"); 

while($row = mysql_fetch_array($result)){ 
    if($bgcolor == #E0E0E0) 
        $bgcolor = #FFFFFF; 
    else 
        $bgcolor = #E0E0E0;      

It should look like this:

if(mysql_num_rows($result) == 0) 
        echo("Nothing to Display!"); 

$bgcolor = "#E0E0E0"; // light gray 

echo("<table>"); 

while($row = mysql_fetch_array($result)){ 
    if($bgcolor == "#E0E0E0") 
        $bgcolor = "#FFFFFF"; 
    else 
        $bgcolor = "#E0E0E0";      

See the different colors of the hex color values? When they aren't quoted PHP can't figure out what you are trying to say since they aren't valid code.

[LukeO]

Thank you all so much 🙂. With the help of vincente and eoghain I was able to debug the code. It came from a tutorial, which I can now see was a bad one, even before I posted here, I had to correct several errors I discovered myself. Anyway, next time, I'll be sure to use a more reliable source.

Thank you all again,

Luke