HTML FORMS and PHP

smp

Hi,

I am trying to insert data from a form into an Oracle database, but i keep gettting errors saying undefined variable or index....I have even tried to get a simpler example to work, and I still get the same error, can someone tell me if there is something wrong with this code...this might help me to figure out my more complicated code...

thanks

<? if (submit== "click"){ 
echo "Hello, $UserName"; 
} 
else{ 
  echo ' 
  <html><body> 

  <form method="post" action="hello.php"> 

  Enter Your Name 
  <input type="text" name="UserName"></input><br> 

  <input type="submit" name="submit" value="click"></input> 

  </form> 

  </body></html> 
  '; 
} 

?>

this is the error i keep getting

Notice: Undefined variable: submit in E:\Inetpub\wwwroot\allnorth_test\admin\hello.php on line 4

cap97

The "value" in the submit button is simply the text that's going to appear in the button. So PHP is looking for a submit that equals "click" but your form isn't passing one. Instead, have PHP simply look for submit:


<?php 

 if ($submit)
 { 
  echo "Hello, $UserName"; 
 } 
 else
 { 
  echo ' 
  <html><body> 

  <form method="post" action="hello.php"> 

  Enter Your Name 
  <input type="text" name="UserName"></input><br> 

  <input type="submit" name="submit" value="click"></input> 

  </form> 

  </body></html> 
  '; 
 } 
?>

Now a text field is different. There the value could matter or not, depending on what you want.

if ($UserName == Somebody)
{
 echo "Do this\n";
}
else
{
 echo "Do that\n";
}

Or if it doesn't matter what the UserName's variable is, you could simply have the form make sure it got filled out:

if ($UserName)
{
 echo "Do this\n";
}
else
{
 echo "Hey you didn't fill out UserName!\n";
}

Or you could combine it all:

<?php 

 if ($submit)
 { 
  if ($UserName)
  {
   echo "Hi $UserName!\n";
  }
  else
  {
   echo "Hey, you need to fill out the username!\n";
  }
 } 
 else
 { 
  echo ' 
  <html><body> 

  <form method="post" action="hello.php"> 

  Enter Your Name 
  <input type="text" name="UserName"></input><br> 

  <input type="submit" name="submit" value="click"></input> 

  </form> 

  </body></html> 
  '; 
 } 
?>

ahundiak

if $submit == blah blah blah

smp

i have tried what you suggested, but i am still getting the same error message...

undefined variable submit....

could it be something with my global variables being turned off??how can i fix this in the code, as i don't have access to the ini file on the network server??

thanks,

cgraz

if(isset($_POST['submit'])) {

or for older versions of PHP

if(isset($HTTP_POST_VARS['submit'])) {

Cgraz

smp

thanks, that got rid of one error, then i got the same thing for $Username, so i did the same thing for that...and now i am getting this on my page...

Hello, Array(UserName)

....it is not giving me a chance to fill out the form first...which is why i was using if($_POST['submit'] == "click") to signify that a form was filled out and then submitted...however someone else wrote to me that my original code was not doing that...

do you know how i can make it so that it shows the form first, until the button is pressed?

thanks

cap97

The following works on my server:

http://www.livinglegend.org/TEST/form.php

Copy and paste the code directly from below and if it still doesn't work, then maybe you have other issues:



<?php

 if(isset($_POST['submit']))
 {
  echo "Hello, $UserName";
 }   

 else
 {

?>


  <html><body>

  <form method="post" action="<?php echo $PHP_SELF;?>">

  Enter Your Name
  <input type="text" name="UserName"></input><br>

  <input type="submit" name="submit" value="click"></input>

  </form>

  </body></html>

<?php

 }

?>

smp

ok, that did work better, but now i am getting the same error after i insert the username.....using your code it gives me this error:

Notice: Undefined index: 'UserName' in E:\Inetpub\wwwroot\allnorth_test\Admin\hello.php on line 8
Hello,

so i am not sure what is needed to fix it, since it works fine on your web site??

cap97

No idea what's wrong then. Yes it works on my site, if you check the link I posted. What version of PHP are you using? Did you install it yourself or is your site hosted?

cgraz

instead of $UserName, use $_POST['UserName']

change all of your form variables like that. If you have a form variable called $var, then access it using $_POST['var']

Sounds to me like you have register globals set to off. This should fix your problem.

Cgraz

smp

this is the code that i am using now:

<?php

 if(isset($_POST['submit']))
 {
  echo "Hello, $_POST['UserName']";
 }   

 else
 {

?>

Enter Your Name
<input type="text" name="UserName"></input><br>

</form>

</body></html>

<?php

 }

?>

but i am still getting this error...i cannot figure out why it will not work for me?

ERROR:
Notice: Undefined index: 'UserName' in E:\Inetpub\wwwroot\allnorth_test\admin\hello.php on line 8
Hello,

Can anyone else see anything wrong with this code?

thanks

smp

never mind, i have figured it out...i was missing a " after hello, which was giving me an error...

thanks for your help

horsefaceba

I am having the same problem with the submit function and have attempted it on my server, however, the message that I am recieving is :
FORBIDDEN:
You don't have permission to access /<br /><b>Notice</b>: Undefined variable: PHP_SELF in <b>e:/apache group/apache/htdocs/newtestform.php</b> on line <b>15</b><br /> on this server

I am in control of the server so if this is a configuration issue, I should be able to modify it to work.

Thanks for any help that can be given.

Jim🙂

atzi

Hi there,

I found a very simple but unprofessional solution to the "Notice: Undefined Variable" - problem.

Just change the "error_reporting" in the php.ini to
error_reporting= E_ALL & ~E_NOTICE (see descriptin within the php.ini)

Afterwards all notice-messages will not be display further more.

regards,
Atzi