string concatenation

[vinylblare]

can someone tell me if this concatenantion is right? i'm getting an error.
i have wrote a script to open a document in a new window using the following code

<script>
//function to open new window
function openWindow() {
PopupWindow=window.open
("","name","width=850, height=950");
}
</script>

inside the php tags i have the following

echo"<tr><td bgcolor='#FFFFEE'><a href='" .moredetail . ".php?Moduleno=$Modno. "'target='".name. "' onClick='".openWindow()."'> " . $Modname . "</td>";

whats wrong with this string?

[xblue]

echo"<tr><td bgcolor='#FFFFEE'><a href='" .moredetail . ".php?Moduleno=$Modno. "'target='".name. "' onClick='".openWindow()."'> " . $Modname . "</td>"; 

syntax highlighting let's you easily spot what's wrong.

the dot as concatenation operator works like this: say you've got an alternation of strings, enclosed in quotes, and php variables, and before and after each variable you need a dot.

BTW, why did you post this in the database forum? Can't see any relation to databases...

[vinylblare]

it still doesnt work. i got it to display without errors but it says undefined function call?

[stolzyboy]

most of the time it is easier to hop in and out of php, and makes no difference on load time or anything and is usually easier to read and don't have to worry about quotes

just close your php and put this in there, then you can open your php after if you want

<tr><td bgcolor="#FFFFEE"><a href="moredetail.php?Moduleno=<? echo $Modno; ?>" target="name" onClick="openWindow()"><? echo $Modname; ?></td>

[vinylblare]

cheers for that. how good are you with checkboxes?

see i have checkboxes next to each module that a person clicks on. the modules are pulled from the database by the person choosing a certain year of study and semester.
i want the person to click the modules they want to study and when they click register the modules chosen are displayed on a new page. heres the query

<?php
$checkboxno==1;
echo "<td><input type=checkbox name='Module". $checkboxno . "' value='". $Modname . "'";
$checkboxno++;
if ($Modtyp=='Core') {
echo " checked 'DISABLED'";
}

the checkbox number is incremented each time so you have
Module1= ABC
Module2=CDE etc.

now in another php script i can display each module with the following code
$Check = $POST['Module'];
$Check1 = $POST['Module1'];

echo".$Check."<br>";
echo".$Check1."<br>";

i havent used a select query i have just echoed each row. my problem is i have about 15 modules and with the way i have done it if a person picks the 1st module and the 8th then theres a big gap when they r displayed. how can i put this into a loop?

doi need to do a select?

[stolzyboy]

is there an example online that i can see to further my understanding of what you are doing, i just need some clarification on what you are doing